\\n>

⚙️ Run configuration

\\n> \\n> **Configuration used**: defaults\\n> \\n> **Review profile**: CHILL\\n> \\n> **Plan**: Pro\\n> \\n> **Run ID**: `179f3410-b62a-4058-9639-fd78a3b293ad`\\n> \\n>

\\n> \\n>

\\n>

📥 Commits

\\n> \\n> Reviewing files that changed from the base of the PR and between b95750d6e9239aee45d7b68ac8b55dd890a25e86 and 02782f08228ce8643709cfcf2f338a7fb29aeeff.\\n> \\n>

\\n> \\n>

\\n>

⛔ Files ignored due to path filters (1)

\\n> \\n> * `go.sum` is excluded by `!**/*.sum`\\n> \\n>

\\n> \\n>

\\n>

📒 Files selected for processing (63)

\\n> \\n> * `adapter/add_voter_join_test.go`\\n> * `adapter/distribution_milestone1_e2e_test.go`\\n> * `adapter/distribution_server_test.go`\\n> * `adapter/dynamodb.go`\\n> * `adapter/dynamodb_failure_test.go`\\n> * `adapter/dynamodb_test.go`\\n> * `adapter/internal.go`\\n> * `adapter/redis.go`\\n> * `adapter/redis_info_test.go`\\n> * `adapter/redis_keys_pattern_test.go`\\n> * `adapter/redis_list_raft_benchmark_test.go`\\n> * `adapter/redis_retry_test.go`\\n> * `adapter/s3.go`\\n> * `adapter/s3_test.go`\\n> * `adapter/test_util.go`\\n> * `cmd/etcd-raft-migrate/main.go`\\n> * `cmd/etcd-raft-rollback/main.go`\\n> * `cmd/server/demo.go`\\n> * `go.mod`\\n> * `internal/raftengine/etcd/hashicorp_fsm_adapter.go`\\n> * `internal/raftengine/etcd/migrate_test.go`\\n> * `internal/raftengine/hashicorp/engine.go`\\n> * `internal/raftengine/hashicorp/engine_test.go`\\n> * `internal/raftengine/hashicorp/factory.go`\\n> * `internal/raftengine/hashicorp/leadership_err_test.go`\\n> * `internal/raftengine/hashicorp/migrate.go`\\n> * `internal/raftengine/hashicorp/migrate_test.go`\\n> * `internal/raftstore/pebble.go`\\n> * `internal/raftstore/pebble_test.go`\\n> * `kv/coordinator.go`\\n> * `kv/coordinator_dispatch_test.go`\\n> * `kv/coordinator_leader_test.go`\\n> * `kv/fsm.go`\\n> * `kv/fsm_occ_test.go`\\n> * `kv/fsm_txn_test.go`\\n> * `kv/grpc_conn_cache.go`\\n> * `kv/grpc_conn_cache_test.go`\\n> * `kv/leader_proxy.go`\\n> * `kv/leader_proxy_test.go`\\n> * `kv/leader_routed_store.go`\\n> * `kv/leader_routed_store_test.go`\\n> * `kv/lease_state_test.go`\\n> * `kv/lock_resolver_test.go`\\n> * `kv/raft_engine.go`\\n> * `kv/shard_router_test.go`\\n> * `kv/shard_store_txn_lock_test.go`\\n> * `kv/sharded_coordinator.go`\\n> * `kv/sharded_coordinator_abort_test.go`\\n> * `kv/sharded_coordinator_del_prefix_test.go`\\n> * `kv/sharded_coordinator_leader_test.go`\\n> * `kv/sharded_integration_test.go`\\n> * `kv/snapshot.go`\\n> * `kv/snapshot_test.go`\\n> * `kv/transaction.go`\\n> * `kv/transaction_batch_test.go`\\n> * `main.go`\\n> * `main_bootstrap_e2e_test.go`\\n> * `main_bootstrap_test.go`\\n> * `main_s3.go`\\n> * `multiraft_runtime.go`\\n> * `multiraft_runtime_test.go`\\n> * `shard_config.go`\\n> * `shard_config_test.go`\\n> \\n>

\\n> \\n> ```ascii\\n> _____________________________\\n> < Don't hate the know-it-all. >\\n> -----------------------------\\n> \\\\\\n> \\\\ (\\\\__/)\\n> (•ㅅ•)\\n> / 　づ\\n> ```\\n\\n\\n\\n\\n\\n\\n

\\n

✨ Finishing Touches

\\n\\n

\\n

📝 Generate docstrings

\\n\\n- [ ] Create stacked PR\\n- [ ] Commit on current branch\\n\\n

\\n

🧪 Generate unit tests (beta)

\\n\\n- [ ] Create PR with unit tests\\n- [ ] Commit unit tests in branch `chore/drop-hashicorp-raft`\\n\\n

\\n\\n

\\n\\n\\n\\n\\n\\n---\\n\\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=bootjp/elastickv&utm_content=590)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\\n\\n

\\n

❤️ Share

\\n\\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\\n\\n

\\n\\n_{Comment `@coderabbitai help` to get the list of available commands and usage tips.}\\n\\n\",\"path\":null,\"side\":null,\"line\":null}{\"type\":\"pull_request_comment\",\"body\":\"\\n### 💡 Codex Review\\n\\nHere are some automated review suggestions for this pull request.\\n\\n**Reviewed commit:** `a35245a411`\\n \\n\\n

ℹ️ About Codex in GitHub

\\n
\\n\\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\\n- Open a pull request for review\\n- Mark a draft as ready\\n- Comment \\\"@codex review\\\".\\n\\nIf Codex has suggestions, it will comment; otherwise it will react with 👍.\\n\\n\\n\\n\\nCodex can also answer questions or update the PR. Try commenting \\\"@codex address that feedback\\\".\\n \\n

\",\"path\":null,\"side\":null,\"line\":null}{\"type\":\"pull_request_comment\",\"body\":\"**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Pass peer config when creating demo Raft engines**\\n\\nThis `Create` call never sets `Peers`, so in demo mode the non-bootstrap nodes (`raftBootstrap=false` for n2/n3 in the same file) start with an empty peer list and etcd rejects startup before `joinCluster` runs. I reproduced this by running `./server` and seeing node startup fail with “no persisted peers and no peer list was supplied”. As written, the 3-node demo path cannot form a cluster.\\n\\nUseful? React with 👍 / 👎.\",\"path\":\"cmd/server/demo.go\",\"side\":\"RIGHT\",\"line\":546}{\"type\":\"pull_request_comment\",\"body\":\"**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Keep rejecting legacy Hashicorp raft artifacts**\\n\\n`detectRaftEngineFromDataDir` now only checks etcd markers, so a pre-marker data dir that still contains Hashicorp artifacts (`raft.db`, `logs.dat`, `stable.dat`) is treated as empty and gets an etcd marker written. On upgrade this can allow bootstrapping an incompatible engine over existing state instead of failing fast with `ErrRaftEngineDataDir`, which risks losing committed cluster history.\\n\\nUseful? React with 👍 / 👎.\",\"path\":\"multiraft_runtime.go\",\"side\":\"RIGHT\",\"line\":151}{\"type\":\"pull_request_comment\",\"body\":\"\\n### 💡 Codex Review\\n\\nHere are some automated review suggestions for this pull request.\\n\\n**Reviewed commit:** `c5dc58a523`\\n \\n\\n

ℹ️ About Codex in GitHub

\",\"path\":null,\"side\":null,\"line\":null}{\"type\":\"pull_request_comment\",\"body\":\"**_{_{![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)}} Validate demo Raft data dir before creating engine**\\n\\nThis code opens the etcd engine directly from `raftDir` without any compatibility check for legacy Hashicorp Raft artifacts; the previous `setupStorage` path rejected `logs.dat`/`stable.dat` before startup. In a restart/upgrade where `--raftDataDir` still contains legacy state, the node can initialize a fresh etcd Raft store instead of failing fast, which effectively ignores prior committed history and risks silent data loss. Add the same data-dir engine validation used in the main runtime before calling `factory.Create`.\\n\\nUseful? React with 👍 / 👎.\",\"path\":\"cmd/server/demo.go\",\"side\":\"RIGHT\",\"line\":546}","text_elements",[],{"_451":996,"_438":439,"_453":441},{"_454":997,"_456":-5,"_41":-5,"_457":-5,"_94":308,"_90":459},[998],{"_45":992,"_90":999},"input_text","turn/started",{"_438":439,"_85":1002},{"_101":-5,"_41":441,"_442":1003,"_444":1004},[],"inProgress",{"_444":1006,"_438":439},{"_1007":1008,"_90":1009},"activeFlags",[],"active",{"_451":1011,"_438":439,"_453":1012},{"_454":1013,"_456":-5,"_41":-5,"_457":-5,"_94":308,"_90":459},"auto-compact-0",[1014,1015],{"_45":1017,"_90":999},{"_45":1016,"_90":999},"\n /workspace/elastickv\n bash\n 2026-04-22\n Etc/UTC\n","# AGENTS.md instructions for /workspace/elastickv\n\n\n# Repository Guidelines\n\n## Project Structure & Modules\n- `cmd/server`, `cmd/client`: entrypoints for running the KV server and client.\n- `store/`: MVCC storage engine, OCC/TTL, and related tests.\n- `kv/`: hybrid logical clock (HLC) utilities and KV interfaces.\n- `adapter/`: protocol adapters (e.g., Redis), plus integration tests.\n- `jepsen/`, `jepsen/redis/`: Jepsen test harnesses and workloads.\n- `proto/`, `distribution/`, `internal/`: supporting protobufs, build assets, and shared helpers.\n\n## Build, Test, and Development Commands\n- `go test ./...` — run unit/integration tests. If macOS sandbox blocks `$GOCACHE`, prefer `GOCACHE=$(pwd)/.cache GOTMPDIR=$(pwd)/.cache/tmp go test ./...`.\n- `GOCACHE=$(pwd)/.cache GOLANGCI_LINT_CACHE=$(pwd)/.golangci-cache golangci-lint run ./... --timeout=5m` — full lint suite.\n- `HOME=$(pwd)/jepsen/tmp-home LEIN_HOME=$(pwd)/jepsen/.lein LEIN_JVM_OPTS=\"-Duser.home=$(pwd)/jepsen/tmp-home\" /tmp/lein test` (from `jepsen/` or `jepsen/redis/`) — Jepsen tests.\n- `go run ./cmd/server` / `go run ./cmd/client` — start server or CLI locally.\n\n## Coding Style & Naming\n- Go code: `gofmt` + project lint rules (`golangci-lint`). Avoid adding `//nolint` unless absolutely required; prefer refactoring.\n- Naming: Go conventions (MixedCaps for exported identifiers, short receiver names). Filenames remain lowercase with underscores only where existing.\n- Logging: use `slog` where present; maintain structured keys (`key`, `commit_ts`, etc.).\n\n## Testing Guidelines\n- Unit tests co-located with packages (`*_test.go`); prefer table-driven cases.\n- TTL/HLC behaviors live in `store/` and `kv/`; add coverage when touching clocks, OCC, or replication logic.\n- Integration: run Jepsen suites after changes affecting replication, MVCC, or Redis adapter.\n - `cd jepsen && HOME=$(pwd)/tmp-home LEIN_HOME=$(pwd)/.lein LEIN_JVM_OPTS=\"-Duser.home=$(pwd)/tmp-home\" /tmp/lein test`\n - `cd jepsen/redis && HOME=$(pwd)/../tmp-home LEIN_HOME=$(pwd)/../.lein LEIN_JVM_OPTS=\"-Duser.home=$(pwd)/../tmp-home\" /tmp/lein test`\n\n## Commit & Pull Request Guidelines\n- Messages: short imperative summary (e.g., “Add HLC TTL handling”). Include scope when helpful (`store:`, `adapter:`).\n- Pull requests: describe behavior change, risk, and test evidence (`go test`, lint, Jepsen). Add repro steps for bug fixes.\n\n## Security & Configuration Tips\n- Hybrid clock derives from wall-clock millis; keep system clock reasonably synchronized across nodes.\n- Avoid leader-local timestamps in persistence; timestamp issuance should originate from the Raft leader to prevent skewed OCC decisions.\n\n\n## Skills\nA skill is a set of local instructions to follow that is stored in a `SKILL.md` file. Below is the list of skills that can be used. Each entry includes a name, description, and file path so you can open the source for full instructions when using a specific skill.\n### Available skills\n- skill-creator: Guide for creating effective skills. This skill should be used when users want to create a new skill (or update an existing skill) that extends Codex's capabilities with specialized knowledge, workflows, or tool integrations. (file: /opt/codex/skills/.system/skill-creator/SKILL.md)\n- skill-installer: Install Codex skills into $CODEX_HOME/skills from a curated list or a GitHub repo path. Use when a user asks to list installable skills, install a curated skill, or install a skill from another repo (including private repos). (file: /opt/codex/skills/.system/skill-installer/SKILL.md)\n### How to use skills\n- Discovery: The list above is the skills available in this session (name + description + file path). Skill bodies live on disk at the listed paths.\n- Trigger rules: If the user names a skill (with `$SkillName` or plain text) OR the task clearly matches a skill's description shown above, you must use that skill for that turn. Multiple mentions mean use them all. Do not carry skills across turns unless re-mentioned.\n- Missing/blocked: If a named skill isn't in the list or the path can't be read, say so briefly and continue with the best fallback.\n- How to use a skill (progressive disclosure):\n 1) After deciding to use a skill, open its `SKILL.md`. Read only enough to follow the workflow.\n 2) When `SKILL.md` references relative paths (e.g., `scripts/foo.py`), resolve them relative to the skill directory listed above first, and only consider other paths if needed.\n 3) If `SKILL.md` points to extra folders such as `references/`, load only the specific files needed for the request; don't bulk-load everything.\n 4) If `scripts/` exist, prefer running or patching them instead of retyping large code blocks.\n 5) If `assets/` or templates exist, reuse them instead of recreating from scratch.\n- Coordination and sequencing:\n - If multiple skills apply, choose the minimal set that covers the request and state the order you'll use them.\n - Announce which skill(s) you're using and why (one short line). If you skip an obvious skill, say why.\n- Context hygiene:\n - Keep context small: summarize long sections instead of pasting them; only load extra files when needed.\n - Avoid deep reference-chasing: prefer opening only files directly linked from `SKILL.md` unless you're blocked.\n - When variants exist (frameworks, providers, domains), pick only the relevant reference file(s) and note that choice.\n- Safety and fallback: If a skill can't be applied cleanly (missing files, unclear instructions), state the issue, pick the next-best approach, and continue.\n",{"_451":1019,"_438":439,"_453":1012},{"_454":1020,"_456":-5,"_41":-5,"_457":-5,"_94":1021,"_90":459},[1022],"developer",{"_45":1023,"_90":999},"\nFilesystem sandboxing defines which files can be read or written. `sandbox_mode` is `danger-full-access`: No filesystem sandboxing - all commands are permitted. Network access is enabled.\nApproval policy is currently never. Do not provide the `sandbox_permissions` for any reason, commands will be rejected.\n","thread/started",{"_1026":1027},"thread",{"_1028":-5,"_1029":-5,"_1030":1031,"_1032":1033,"_494":495,"_1034":15,"_1035":-5,"_41":439,"_1036":1037,"_166":-5,"_155":1038,"_1039":184,"_1040":1041,"_444":1042,"_75":1043,"_1044":1033},"agentNickname","agentRole","cliVersion","0.114.0","createdAt",1776887844,"ephemeral","gitInfo","modelProvider","openai","/opt/codex/sessions/2026/04/22/rollout-2026-04-22T19-57-24-019db6c4-d066-73c0-8302-b419566700a1.jsonl","preview","source","vscode",{"_90":448},[],"updatedAt",[],"messages",[1048],{"_41":1049,"_1050":1051,"_1052":1053,"_1054":1053,"_454":1055,"_444":1056,"_456":-5,"_1057":31,"_1058":1059,"_1060":283,"_1061":-5},"3b02d1ee-3f4e-41c8-8a71-9146ac209b83","author",{"_94":308,"_166":-5,"_1058":1070},"create_time",1776887844.461397,"update_time",{"_1066":45,"_1067":1068},"finished_successfully","weight","metadata",{"_1062":1063},"recipient","channel","l1239dk1",{"_1064":1065},"inline_comments",[],"content_type","parts",[1069],"@codex address that feedback — commits 02782f08 (demo peers + legacy artifact rejection) and c5dc58a5 (test leader transfer).\nchore(raft): drop hashicorp/raft backend, kv/ on raftengine natively\n\n## Summary\n- Delete the `internal/raftengine/hashicorp` backend, the etcd/hashicorp FSM adapter, `internal/raftstore`, and `cmd/etcd-raft-migrate` / `cmd/etcd-raft-rollback`.\n- Flip `kv/` to implement `raftengine.StateMachine` directly — `kvFSM.Apply([]byte)`, `Snapshot() (raftengine.Snapshot, error)`, `Restore(io.Reader)`. Drop the legacy `NewCoordinator(*raft.Raft)` / `NewTransaction` / `NewLeaderProxy` shims.\n- Replace `raft.ServerAddress` / `raft.ServerID` / `raft.Server` / `raft.Voter` with plain `string` and `raftengine.Server` throughout `kv/`, `adapter/`, `main.go`, `shard_config.go`, `cmd/server/demo.go`.\n- Rewrite the in-process test clusters (`kv/sharded_integration_test.go`, `adapter/test_util.go`, `adapter/s3_test.go`, `adapter/distribution_milestone1_e2e_test.go`) on top of the etcd factory with `t.TempDir()` data dirs.\n- Remove hashicorp-specific tests that exercised AddVoter / InmemTransport / boltdb legacy detection (`adapter/add_voter_join_test.go`, `adapter/dynamodb_failure_test.go`, `adapter/redis_list_raft_benchmark_test.go`, bootstrap and mixed-artifact cases in `multiraft_runtime_test.go`).\n- `go mod tidy` drops `hashicorp/raft`, `Jille/raft-grpc-transport`, `hashicorp/go-hclog` and transitive hashicorp deps.\n\nStats: 64 files, +487 / -3703.\n\n## Test plan\n- [x] `go build ./...`\n- [x] `go vet ./...`\n- [x] `go test ./kv/...` (passes in ~5s)\n- [x] `go test ./internal/...` (etcd engine conformance, raftadmin, s3keys)\n- [ ] `go test ./adapter/...` — heavy sequential test `Test_consistency_satisfy_write_after_read_sequence` (9999 × 3 sequential Puts on a 3-node loopback etcd cluster) hangs on `Propose(context.Background())` where it used to complete quickly with hashicorp's InmemTransport. Parallel variant (`Test_consistency_satisfy_write_after_read_for_parallel`, 1000 goroutines) passes in <1s. Other adapter tests pass individually. Needs follow-up on either test timing or etcd engine behavior under slow sequential back-pressure.\n- [ ] bootstrap e2e (`main_bootstrap_e2e_test.go`) — now only exercises the etcd engine variant.\n\n## Notes for reviewers\n- `adapter/test_util.go` now uses the etcd factory with a temp dir per node. Leader election relies on etcd's randomized election timeouts rather than the previous \"node 0 has electionTimeout=0, others wait 10s\" trick; this means the leader is not deterministic, but `waitForRaftReadiness` converges on whichever node wins.\n- `cmd/server/demo.go` now goes through the engine factory instead of constructing a raft instance directly. `setupStorage` / `bootstrapClusterIfNeeded` are gone.\n- `multiraft_runtime.go` no longer tries to detect mixed hashicorp/etcd artifacts — only etcd markers remain.\n> [!WARNING]\n> You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!\n/gemini review @codex review\n> [!WARNING]\n> You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!\n\n\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n>

\n>

⚙️ Run configuration

\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro\n> \n> **Run ID**: `179f3410-b62a-4058-9639-fd78a3b293ad`\n> \n>

\n> \n>

\n>

📥 Commits

\n> \n> Reviewing files that changed from the base of the PR and between b95750d6e9239aee45d7b68ac8b55dd890a25e86 and 02782f08228ce8643709cfcf2f338a7fb29aeeff.\n> \n>

\n> \n>

\n>

⛔ Files ignored due to path filters (1)

\n> \n> * `go.sum` is excluded by `!**/*.sum`\n> \n>

\n> \n>

\n>

📒 Files selected for processing (63)

\n> \n> * `adapter/add_voter_join_test.go`\n> * `adapter/distribution_milestone1_e2e_test.go`\n> * `adapter/distribution_server_test.go`\n> * `adapter/dynamodb.go`\n> * `adapter/dynamodb_failure_test.go`\n> * `adapter/dynamodb_test.go`\n> * `adapter/internal.go`\n> * `adapter/redis.go`\n> * `adapter/redis_info_test.go`\n> * `adapter/redis_keys_pattern_test.go`\n> * `adapter/redis_list_raft_benchmark_test.go`\n> * `adapter/redis_retry_test.go`\n> * `adapter/s3.go`\n> * `adapter/s3_test.go`\n> * `adapter/test_util.go`\n> * `cmd/etcd-raft-migrate/main.go`\n> * `cmd/etcd-raft-rollback/main.go`\n> * `cmd/server/demo.go`\n> * `go.mod`\n> * `internal/raftengine/etcd/hashicorp_fsm_adapter.go`\n> * `internal/raftengine/etcd/migrate_test.go`\n> * `internal/raftengine/hashicorp/engine.go`\n> * `internal/raftengine/hashicorp/engine_test.go`\n> * `internal/raftengine/hashicorp/factory.go`\n> * `internal/raftengine/hashicorp/leadership_err_test.go`\n> * `internal/raftengine/hashicorp/migrate.go`\n> * `internal/raftengine/hashicorp/migrate_test.go`\n> * `internal/raftstore/pebble.go`\n> * `internal/raftstore/pebble_test.go`\n> * `kv/coordinator.go`\n> * `kv/coordinator_dispatch_test.go`\n> * `kv/coordinator_leader_test.go`\n> * `kv/fsm.go`\n> * `kv/fsm_occ_test.go`\n> * `kv/fsm_txn_test.go`\n> * `kv/grpc_conn_cache.go`\n> * `kv/grpc_conn_cache_test.go`\n> * `kv/leader_proxy.go`\n> * `kv/leader_proxy_test.go`\n> * `kv/leader_routed_store.go`\n> * `kv/leader_routed_store_test.go`\n> * `kv/lease_state_test.go`\n> * `kv/lock_resolver_test.go`\n> * `kv/raft_engine.go`\n> * `kv/shard_router_test.go`\n> * `kv/shard_store_txn_lock_test.go`\n> * `kv/sharded_coordinator.go`\n> * `kv/sharded_coordinator_abort_test.go`\n> * `kv/sharded_coordinator_del_prefix_test.go`\n> * `kv/sharded_coordinator_leader_test.go`\n> * `kv/sharded_integration_test.go`\n> * `kv/snapshot.go`\n> * `kv/snapshot_test.go`\n> * `kv/transaction.go`\n> * `kv/transaction_batch_test.go`\n> * `main.go`\n> * `main_bootstrap_e2e_test.go`\n> * `main_bootstrap_test.go`\n> * `main_s3.go`\n> * `multiraft_runtime.go`\n> * `multiraft_runtime_test.go`\n> * `shard_config.go`\n> * `shard_config_test.go`\n> \n>

\n> \n> ```ascii\n> _____________________________\n> < Don't hate the know-it-all. >\n> -----------------------------\n> \\\n> \\ (\\__/)\n> (•ㅅ•)\n> / 　づ\n> ```\n\n\n\n\n\n\n

✨ Finishing Touches

\n\n

📝 Generate docstrings

\n\n- [ ] Create stacked PR\n- [ ] Commit on current branch\n\n

🧪 Generate unit tests (beta)

\n\n- [ ] Create PR with unit tests\n- [ ] Commit unit tests in branch `chore/drop-hashicorp-raft`\n\n

\n\n

\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=bootjp/elastickv&utm_content=590)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n

❤️ Share

\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n

\n\n_{Comment `@coderabbitai help` to get the list of available commands and usage tips.}\n\n\n\n### 💡 Codex Review\n\nHere are some automated review suggestions for this pull request.\n\n**Reviewed commit:** `a35245a411`\n \n\n

ℹ️ About Codex in GitHub

\n
\n\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\n- Open a pull request for review\n- Mark a draft as ready\n- Comment \"@codex review\".\n\nIf Codex has suggestions, it will comment; otherwise it will react with 👍.\n\n\n\n\nCodex can also answer questions or update the PR. Try commenting \"@codex address that feedback\".\n \n

\n**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Pass peer config when creating demo Raft engines**\n\nThis `Create` call never sets `Peers`, so in demo mode the non-bootstrap nodes (`raftBootstrap=false` for n2/n3 in the same file) start with an empty peer list and etcd rejects startup before `joinCluster` runs. I reproduced this by running `./server` and seeing node startup fail with “no persisted peers and no peer list was supplied”. As written, the 3-node demo path cannot form a cluster.\n\nUseful? React with 👍 / 👎.\n**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Keep rejecting legacy Hashicorp raft artifacts**\n\n`detectRaftEngineFromDataDir` now only checks etcd markers, so a pre-marker data dir that still contains Hashicorp artifacts (`raft.db`, `logs.dat`, `stable.dat`) is treated as empty and gets an etcd marker written. On upgrade this can allow bootstrapping an incompatible engine over existing state instead of failing fast with `ErrRaftEngineDataDir`, which risks losing committed cluster history.\n\nUseful? React with 👍 / 👎.\n\n### 💡 Codex Review\n\nHere are some automated review suggestions for this pull request.\n\n**Reviewed commit:** `c5dc58a523`\n \n\n

ℹ️ About Codex in GitHub

\n**_{_{![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)}} Validate demo Raft data dir before creating engine**\n\nThis code opens the etcd engine directly from `raftDir` without any compatibility check for legacy Hashicorp Raft artifacts; the previous `setupStorage` path rejected `logs.dat`/`stable.dat` before startup. In a restart/upgrade where `--raftDataDir` still contains legacy state, the node can initialize a fresh etcd Raft store instead of failing fast, which effectively ignores prior committed history and risks silent data loss. Add the same data-dir engine validation used in the main runtime before calling `factory.Create`.\n\nUseful? React with 👍 / 👎.",{},"created",1776888300.0815291,"Completing the task","event_type","info",{"_90":459,"_94":91,"_454":2004},{"_90":1078,"_1079":1080},"partial_repo_snapshot","files",[1081,1082,1083],{"_155":875,"_1084":-5,"_1085":1548,"_1087":-5},{"_155":849,"_1084":-5,"_1085":1400,"_1087":-5},{"_155":793,"_1084":-5,"_1085":1086,"_1087":-5},"contents","line_range_contents",[1088],"missing_reason",{"_1089":1090,"_1091":1092,"_454":1093,"_1094":57},"line_range_start",1,"line_range_end",444,[1095,184,1096,1097,1098,1099,1100,1101,1102,1103,1104,184,1105,1106,1107,1108,1109,1110,1111,1112,1113,1114,1115,1116,1117,184,1118,1119,1120,1121,1122,1123,1117,184,1124,1125,1126,1127,1128,1129,1130,1131,1132,184,1133,1134,1135,1136,1137,1138,1139,1140,1141,1142,1137,1143,1144,1145,1137,1146,1147,1148,1142,1137,1149,1150,1151,1142,1137,1152,1132,184,1153,1154,1155,1156,1157,1158,1159,1160,1161,1132,184,1118,1162,1163,1164,1165,1166,1117,184,1167,1168,1169,1170,1171,184,1172,1173,1174,1175,1176,1132,184,1177,1178,1179,1180,1181,1182,1183,1184,1185,1186,1187,1188,1189,1190,1191,1192,1152,1132,184,1193,1158,1159,1160,1161,1194,1195,1196,1197,1198,1199,1200,1132,184,1201,1202,1203,1204,1205,1206,1207,1208,1209,1210,1211,1212,1213,1152,1132,184,1214,1215,1216,1217,1218,1219,184,1220,184,1221,184,1222,1223,184,1224,1225,184,1226,1132,184,1227,1228,1229,1230,1132,184,1231,1232,1233,1234,1235,1137,1236,1152,184,1237,1233,1238,1234,1235,1137,1236,1152,184,1239,1233,1238,1240,1234,1235,1137,1236,1152,184,1241,1242,1243,1244,1245,1132,184,1246,1220,1247,1134,1248,1249,1250,1251,1142,1252,1253,1250,1251,1142,1252,1254,1255,1152,1132,184,1256,1220,184,1257,1258,1259,1260,1261,1262,184,1263,1264,1265,1266,1267,1251,1142,1268,1269,1270,1251,1142,1137,1271,1272,1273,1274,1142,1137,1275,1276,1132,184,1277,1278,1279,1280,1220,184,1281,1282,1152,1283,184,1284,1263,1265,1285,1274,1142,1137,1275,1286,184,1287,1288,1289,1290,1263,1291,1254,1137,1265,1292,1293,1142,1294,1295,1251,1142,1296,1297,1298,1299,1137,1275,1300,1132,184,1301,1302,1303,1304,1152,1305,1132,184,1306,1307,1303,1308,1309,1310,1311,1312,1152,1313,1132,184,1314,1220,1315,1316,1317,1318,1319,1303,1320,1321,1322,1323,1324,1325,1326,1327,1328,1329,1330,1293,1142,1331,1332,1299,1137,1152,184,1333,1334,1335,1336,1152,184,1337,184,1303,1338,1339,1340,1341,1342,1343,184,1344,1345,1346,1347,184,1348,1349,1350,1351,1352,1353,1354,1312,1355,184,1356,1357,1358,1359,1360,1361,1362,1363,1364,1365,1137,1366,1367,1368,1369,184,1370,1371,1372,1373,1374,184,1375,1376,1377,1378,1325,1379,1380,1381,184,1382,1383,1384,1385,184,1386,1387,1388,1389,1390,1391,1392,1393,1394,1395,1396,1397,1398,1152,184,1399,1132],"contains_end_of_file","package adapter","import (","\t\"context\"","\t\"log\"","\t\"net\"","\t\"strconv\"","\t\"sync\"","\t\"sync/atomic\"","\t\"testing\"","\t\"time\"","\tinternalutil \"github.com/bootjp/elastickv/internal\"","\tinternalraftadmin \"github.com/bootjp/elastickv/internal/raftadmin\"","\t\"github.com/bootjp/elastickv/internal/raftengine\"","\tetcdraftengine \"github.com/bootjp/elastickv/internal/raftengine/etcd\"","\t\"github.com/bootjp/elastickv/kv\"","\tpb \"github.com/bootjp/elastickv/proto\"","\t\"github.com/bootjp/elastickv/store\"","\t\"github.com/cockroachdb/errors\"","\t\"github.com/stretchr/testify/assert\"","\t\"github.com/stretchr/testify/require\"","\t\"golang.org/x/sys/unix\"","\t\"google.golang.org/grpc\"",")","const (","\ttestEngineTickInterval = 10 * time.Millisecond","\ttestEngineHeartbeatTick = 1","\ttestEngineElectionTick = 10","\ttestEngineMaxSizePerMsg = 1 << 20","\ttestEngineMaxInflight = 256","func newTestFactory() raftengine.Factory {","\treturn etcdraftengine.NewFactory(etcdraftengine.FactoryConfig{","\t\tTickInterval: testEngineTickInterval,","\t\tHeartbeatTick: testEngineHeartbeatTick,","\t\tElectionTick: testEngineElectionTick,","\t\tMaxSizePerMsg: testEngineMaxSizePerMsg,","\t\tMaxInflightMsg: testEngineMaxInflight,","\t})","}","func shutdown(nodes []Node) {","\tfor _, n := range nodes {","\t\tif n.opsCancel != nil {","\t\t\tn.opsCancel()","\t\t}","\t\tn.grpcServer.Stop()","\t\tif n.grpcService != nil {","\t\t\tif err := n.grpcService.Close(); err != nil {","\t\t\t\tlog.Printf(\"grpc service close: %v\", err)","\t\t\t}","\t\tn.redisServer.Stop()","\t\tif n.dynamoServer != nil {","\t\t\tn.dynamoServer.Stop()","\t\tif n.engine != nil {","\t\t\tif err := n.engine.Close(); err != nil {","\t\t\t\tlog.Printf(\"engine close: %v\", err)","\t\tif n.closeFactory != nil {","\t\t\tif err := n.closeFactory(); err != nil {","\t\t\t\tlog.Printf(\"factory close: %v\", err)","\t}","type portsAdress struct {","\tgrpc int","\traft int","\tredis int","\tdynamo int","\tgrpcAddress string","\traftAddress string","\tredisAddress string","\tdynamoAddress string","\t// raft and the grpc requested by the client use grpc and are received on the same port","\tgrpcPort = 50000","\traftPort = 50000","\tredisPort = 63790","\tdynamoPort = 28000","var mu sync.Mutex","var portGrpc atomic.Int32","var portRaft atomic.Int32","var portRedis atomic.Int32","var portDynamo atomic.Int32","func init() {","\tportGrpc.Store(raftPort)","\tportRaft.Store(grpcPort)","\tportRedis.Store(redisPort)","\tportDynamo.Store(dynamoPort)","func portAssigner() portsAdress {","\tmu.Lock()","\tdefer mu.Unlock()","\tgp := portGrpc.Add(1)","\trp := portRaft.Add(1)","\trd := portRedis.Add(1)","\tdn := portDynamo.Add(1)","\treturn portsAdress{","\t\tgrpc: int(gp),","\t\traft: int(rp),","\t\tredis: int(rd),","\t\tdynamo: int(dn),","\t\tgrpcAddress: net.JoinHostPort(\"localhost\", strconv.Itoa(int(gp))),","\t\traftAddress: net.JoinHostPort(\"localhost\", strconv.Itoa(int(rp))),","\t\tredisAddress: net.JoinHostPort(\"localhost\", strconv.Itoa(int(rd))),","\t\tdynamoAddress: net.JoinHostPort(\"localhost\", strconv.Itoa(int(dn))),","type Node struct {","\tgrpcServer *grpc.Server","\tgrpcService *GRPCServer","\tredisServer *RedisServer","\tdynamoServer *DynamoDBServer","\topsCancel context.CancelFunc","\tengine raftengine.Engine","\tcloseFactory func() error","func newNode(grpcAddress, raftAddress, redisAddress, dynamoAddress string, engine raftengine.Engine, closeFactory func() error, grpcs *grpc.Server, grpcService *GRPCServer, rd *RedisServer, ds *DynamoDBServer, opsCancel context.CancelFunc) Node {","\treturn Node{","\t\tgrpcAddress: grpcAddress,","\t\traftAddress: raftAddress,","\t\tredisAddress: redisAddress,","\t\tdynamoAddress: dynamoAddress,","\t\tgrpcServer: grpcs,","\t\tgrpcService: grpcService,","\t\tredisServer: rd,","\t\tdynamoServer: ds,","\t\topsCancel: opsCancel,","\t\tengine: engine,","\t\tcloseFactory: closeFactory,","//nolint:unparam","func createNode(t *testing.T, n int) ([]Node, []string, []string) {","\tconst (","\t\twaitTimeout = 5 * time.Second","\t\twaitInterval = 100 * time.Millisecond","\t)","\tt.Helper()","\tctx := context.Background()","\tports := assignPorts(n)","\tnodes, grpcAdders, redisAdders, peers := setupNodes(t, ctx, n, ports)","\twaitForNodeListeners(t, ctx, nodes, waitTimeout, waitInterval)","\twaitForRaftReadiness(t, nodes, peers, waitTimeout, waitInterval)","\treturn nodes, grpcAdders, redisAdders","type listeners struct {","\tgrpc net.Listener","\tredis net.Listener","\tdynamo net.Listener","func bindListeners(ctx context.Context, lc *net.ListenConfig, port portsAdress) (portsAdress, listeners, bool, error) {","\tgrpcSock, err := lc.Listen(ctx, \"tcp\", port.grpcAddress)","\tif err != nil {","\t\tif errors.Is(err, unix.EADDRINUSE) {","\t\t\treturn port, listeners{}, true, nil","\t\treturn port, listeners{}, false, errors.WithStack(err)","\tredisSock, err := lc.Listen(ctx, \"tcp\", port.redisAddress)","\t\t_ = grpcSock.Close()","\tdynamoSock, err := lc.Listen(ctx, \"tcp\", port.dynamoAddress)","\t\t_ = redisSock.Close()","\treturn port, listeners{","\t\tgrpc: grpcSock,","\t\tredis: redisSock,","\t\tdynamo: dynamoSock,","\t}, false, nil","func waitForNodeListeners(t *testing.T, ctx context.Context, nodes []Node, waitTimeout, waitInterval time.Duration) {","\td := &net.Dialer{Timeout: time.Second}","\t\trequire.Eventually(t, func() bool {","\t\t\tconn, err := d.DialContext(ctx, \"tcp\", n.grpcAddress)","\t\t\tif err != nil {","\t\t\t\treturn false","\t\t\t_ = conn.Close()","\t\t\tconn, err = d.DialContext(ctx, \"tcp\", n.redisAddress)","\t\t\treturn true","\t\t}, waitTimeout, waitInterval)","func waitForRaftReadiness(t *testing.T, nodes []Node, peers []raftengine.Server, waitTimeout, waitInterval time.Duration) {","\t// Existing tests assume hosts[0] (node 0) is the cluster leader — the","\t// previous hashicorp setup ensured this by giving node 0 an immediate","\t// election timeout while others waited 10s. etcd/raft elections are","\t// randomised, so whoever wins the first election is effectively random.","\t// Nudge leadership onto node 0 if a different node won.","\tensureNodeZeroIsLeader(t, nodes, peers, waitTimeout, waitInterval)","\trequire.Eventually(t, func() bool {","\t\tvar leaderAddr string","\t\tfor _, n := range nodes {","\t\t\tleader := n.engine.Leader().Address","\t\t\tif leader == \"\" {","\t\t\tif leaderAddr == \"\" {","\t\t\t\tleaderAddr = leader","\t\t\t} else if leader != leaderAddr {","\t\t// Confirm the leader address belongs to the configured peers.","\t\tfor _, p := range peers {","\t\t\tif p.Address == leaderAddr {","\t\t\t\treturn true","\t\treturn false","\t}, waitTimeout, waitInterval)","// ensureNodeZeroIsLeader waits for any node to become leader, then (if","// necessary) triggers a leadership transfer to node 0 so downstream","// tests that assume hosts[0] is authoritative keep working.","func ensureNodeZeroIsLeader(t *testing.T, nodes []Node, peers []raftengine.Server, waitTimeout, waitInterval time.Duration) {","\tif len(nodes) == 0 || len(peers) == 0 {","\t\treturn","\ttargetAddr := peers[0].Address","\t// Step 1: wait until some node is leader so we know the cluster is live.","\t\t\tif n.engine.State() == raftengine.StateLeader {","\t}, waitTimeout, waitInterval, \"no node became leader\")","\t// Step 2: if node 0 isn't already leader, ask the current leader to","\t// transfer leadership to it. This is best-effort — a transfer can","\t// race with another election, in which case the Eventually below","\t// will retry.","\t\tif nodes[0].engine.State() == raftengine.StateLeader {","\t\t\tif n.engine.State() != raftengine.StateLeader {","\t\t\t\tcontinue","\t\t\tadmin, ok := n.engine.(raftengine.Admin)","\t\t\tif !ok {","\t\t\ttransferCtx, cancel := context.WithTimeout(context.Background(), waitInterval)","\t\t\t_ = admin.TransferLeadershipToServer(transferCtx, peers[0].ID, targetAddr)","\t\t\tcancel()","\t\t\tbreak","\t}, waitTimeout, waitInterval, \"node 0 did not become leader\")","func assignPorts(n int) []portsAdress {","\tports := make([]portsAdress, n)","\tfor i := range n {","\t\tports[i] = portAssigner()","\treturn ports","func buildTestPeers(n int, ports []portsAdress) []raftengine.Server {","\tpeers := make([]raftengine.Server, 0, n)","\t\tpeers = append(peers, raftengine.Server{","\t\t\tSuffrage: \"voter\",","\t\t\tID: strconv.Itoa(i),","\t\t\tAddress: ports[i].raftAddress,","\t\t})","\treturn peers","func setupNodes(t *testing.T, ctx context.Context, n int, ports []portsAdress) ([]Node, []string, []string, []raftengine.Server) {","\tvar grpcAdders []string","\tvar redisAdders []string","\tvar nodes []Node","\tlc := net.ListenConfig{}","\tlis := make([]listeners, n)","\t\tvar (","\t\t\tbound portsAdress","\t\t\tl listeners","\t\t\tretry bool","\t\t\terr error","\t\t)","\t\tfor {","\t\t\tbound, l, retry, err = bindListeners(ctx, &lc, ports[i])","\t\t\trequire.NoError(t, err)","\t\t\tif retry {","\t\t\t\tports[i] = portAssigner()","\t\t\tports[i] = bound","\t\t\tlis[i] = l","\tpeers := buildTestPeers(n, ports)","\tleaderRedisMap := make(map[string]string, len(ports))","\tfor _, p := range ports {","\t\tleaderRedisMap[p.raftAddress] = p.redisAddress","\tfactory := newTestFactory()","\t\tst := store.NewMVCCStore()","\t\t// Share a single HLC between the FSM and the coordinator so the FSM can","\t\t// advance physicalCeiling (via HLC lease Raft entries) and the coordinator","\t\t// reads it inside Next() to floor timestamps above the previous leader's window.","\t\thlc := kv.NewHLC()","\t\tfsm := kv.NewKvFSMWithHLC(st, hlc)","\t\tport := ports[i]","\t\tgrpcSock := lis[i].grpc","\t\tredisSock := lis[i].redis","\t\tdynamoSock := lis[i].dynamo","\t\tresult, err := factory.Create(raftengine.FactoryConfig{","\t\t\tLocalID: strconv.Itoa(i),","\t\t\tLocalAddress: port.raftAddress,","\t\t\tDataDir: t.TempDir(),","\t\t\tPeers: peers,","\t\t\tBootstrap: true,","\t\t\tStateMachine: fsm,","\t\trequire.NoError(t, err)","\t\ts := grpc.NewServer(internalutil.GRPCServerOptions()...)","\t\ttrx := kv.NewTransactionWithProposer(result.Engine)","\t\tcoordinator := kv.NewCoordinatorWithEngine(trx, result.Engine, kv.WithHLC(hlc))","\t\trelay := NewRedisPubSubRelay()","\t\troutedStore := kv.NewLeaderRoutedStore(st, coordinator)","\t\tgs := NewGRPCServer(routedStore, coordinator, WithCloseStore())","\t\topsCtx, opsCancel := context.WithCancel(ctx)","\t\tgo coordinator.RunHLCLeaseRenewal(opsCtx)","\t\tif result.RegisterTransport != nil {","\t\t\tresult.RegisterTransport(s)","\t\tpb.RegisterRawKVServer(s, gs)","\t\tpb.RegisterTransactionalKVServer(s, gs)","\t\tpb.RegisterInternalServer(s, NewInternalWithEngine(trx, result.Engine, coordinator.Clock(), relay))","\t\tinternalraftadmin.RegisterOperationalServices(opsCtx, s, result.Engine, []string{\"Example\"})","\t\tgrpcAdders = append(grpcAdders, port.grpcAddress)","\t\tredisAdders = append(redisAdders, port.redisAddress)","\t\tgo func(srv *grpc.Server, lis net.Listener) {","\t\t\tassert.NoError(t, srv.Serve(lis))","\t\t}(s, grpcSock)","\t\tdc := NewDeltaCompactor(st, coordinator)","\t\tgo func() { _ = dc.Run(opsCtx) }()","\t\trd := NewRedisServer(redisSock, port.redisAddress, routedStore, coordinator, leaderRedisMap, relay,","\t\t\tWithRedisCompactor(dc),","\t\tgo func(server *RedisServer) {","\t\t\tassert.NoError(t, server.Run())","\t\t}(rd)","\t\tds := NewDynamoDBServer(dynamoSock, routedStore, coordinator)","\t\tgo func() {","\t\t\tassert.NoError(t, ds.Run())","\t\t}()","\t\tnodes = append(nodes, newNode(","\t\t\tport.grpcAddress,","\t\t\tport.raftAddress,","\t\t\tport.redisAddress,","\t\t\tport.dynamoAddress,","\t\t\tresult.Engine,","\t\t\tresult.Close,","\t\t\ts,","\t\t\tgs,","\t\t\trd,","\t\t\tds,","\t\t\topsCancel,","\t\t))","\treturn nodes, grpcAdders, redisAdders, peers",[1401],{"_1089":1090,"_1091":1402,"_454":1403,"_1094":57},236,[1404,184,1096,1405,1406,1407,1408,1409,184,1107,1111,1112,1116,1117,184,1410,1411,1412,1413,184,1414,1415,1132,184,1416,184,1417,184,1118,1418,1419,1117,184,1420,1421,1422,1423,1117,184,1424,1425,1426,1427,1428,1429,1152,1132,184,1430,1431,1282,1152,1432,1433,1434,1137,1435,1152,1436,1437,1438,1137,1439,1152,1440,1441,1442,1137,1443,1152,1132,184,1444,1445,1282,1152,1446,1132,184,1447,184,1448,1449,1450,1152,1451,1132,184,1452,1453,1454,1152,184,1455,1456,1457,1458,1459,1460,1461,1462,1463,1152,184,1464,1465,1461,1466,1467,1468,1137,1469,1152,184,1470,1233,1461,1152,1471,1472,1152,1473,1132,184,1474,1475,1476,1477,1478,1479,1132,184,1480,1481,1233,1482,1483,1137,1484,1152,1485,1233,1486,1152,1487,1132,184,1488,1489,1490,1491,1492,1493,1494,1495,1496,1497,1498,1219,1233,1499,1152,184,1500,1501,1152,1502,1132,184,1503,1504,1505,1506,1507,1508,1137,1152,1509,1132,184,1510,1511,1454,1152,1512,1132,184,1513,1514,1233,1454,1152,1515,1516,1454,1152,1517,1132,184,1518,1519,1520,1521,1522,1523,1524,1525,1526,1527,1528,1529,1530,1531,1532,1152,184,1533,1534,1535,1536,1537,1538,1539,1131,1233,1540,1152,184,1541,1542,1543,1544,1545,1546,1547,1132],"package main","\t\"fmt\"","\t\"log/slog\"","\t\"os\"","\t\"path/filepath\"","\t\"strings\"","type raftGroupRuntime struct {","\tspec groupSpec","\tengine raftengine.Engine","\tstore store.MVCCStore","\tregisterTransport func(grpc.ServiceRegistrar)","\tcloseFactory func() error // releases factory-created resources (transport, stores)","const raftEngineMarkerPerm = 0o600","type raftEngineType string","\traftEngineEtcd raftEngineType = \"etcd\"","\traftEngineMarkerFile string = \"raft-engine\"","var (","\tErrUnsupportedRaftEngine = errors.New(\"unsupported raft engine\")","\tErrRaftEngineDataDir = errors.New(\"raft data dir belongs to a different raft engine\")","\tErrLegacyHashicorpDataDir = errors.New(\"raft data dir contains legacy hashicorp/raft artifacts; hashicorp backend has been removed, manual migration to etcd is required\")","func parseRaftEngineType(raw string) (raftEngineType, error) {","\tswitch engineType := raftEngineType(strings.ToLower(strings.TrimSpace(raw))); engineType {","\tcase \"\", raftEngineEtcd:","\t\treturn raftEngineEtcd, nil","\tdefault:","\t\treturn \"\", errors.Wrapf(ErrUnsupportedRaftEngine, \"%q\", raw)","func (r *raftGroupRuntime) Close() {","\tif r == nil {","\tif r.engine != nil {","\t\tif err := r.engine.Close(); err != nil {","\t\t\tslog.Warn(\"failed to close raft engine\", \"error\", err)","\t\tr.engine = nil","\tif r.closeFactory != nil {","\t\tif err := r.closeFactory(); err != nil {","\t\t\tslog.Warn(\"failed to close factory resources\", \"error\", err)","\t\tr.closeFactory = nil","\tif r.store != nil {","\t\tif err := r.store.Close(); err != nil {","\t\t\tslog.Warn(\"failed to close store\", \"error\", err)","\t\tr.store = nil","func (r *raftGroupRuntime) registerGRPC(server grpc.ServiceRegistrar) {","\tif r == nil || r.registerTransport == nil || server == nil {","\tr.registerTransport(server)","const raftDirPerm = 0o755","func groupDataDir(baseDir, raftID string, groupID uint64, multi bool) string {","\tif !multi {","\t\treturn filepath.Join(baseDir, raftID)","\treturn filepath.Join(baseDir, raftID, fmt.Sprintf(\"group-%d\", groupID))","func ensureRaftEngineDataDir(dir string, engineType raftEngineType) error {","\tif err := os.MkdirAll(dir, raftDirPerm); err != nil {","\t\treturn errors.WithStack(err)","\t// Refuse to start on top of a dir that still holds hashicorp/raft","\t// artifacts. The hashicorp backend has been removed and silently","\t// overwriting its state with etcd markers would commit to an","\t// incompatible engine over committed data. Fail fast; operators must","\t// migrate the dir explicitly before restarting.","\tif hashicorpArtifacts, err := hasHashicorpRaftArtifacts(dir); err != nil {","\t\treturn err","\t} else if hashicorpArtifacts {","\t\treturn errors.Wrapf(ErrLegacyHashicorpDataDir, \"%s\", dir)","\tmarkerPath := filepath.Join(dir, raftEngineMarkerFile)","\tif current, ok, err := readRaftEngineMarker(markerPath); err != nil {","\t} else if ok {","\t\tif current != engineType {","\t\t\treturn errors.Wrapf(ErrRaftEngineDataDir, \"%s is initialized for %s, not %s\", dir, current, engineType)","\t\treturn nil","\tdetected, ok, err := detectRaftEngineFromDataDir(dir)","\tif ok && detected != engineType {","\t\treturn errors.Wrapf(ErrRaftEngineDataDir, \"%s contains %s state, not %s\", dir, detected, engineType)","\treturn writeRaftEngineMarker(markerPath, engineType)","// hasHashicorpRaftArtifacts reports whether dir contains any files that","// were produced by the removed hashicorp/raft backend (raft.db plus the","// boltdb log/stable files). Used to refuse startup on a legacy data dir","// rather than silently overwriting it with an etcd-shaped cluster.","func hasHashicorpRaftArtifacts(dir string) (bool, error) {","\treturn hasRaftArtifacts(dir, \"raft.db\", \"logs.dat\", \"stable.dat\")","func readRaftEngineMarker(path string) (raftEngineType, bool, error) {","\tdata, err := os.ReadFile(path)","\t\tif os.IsNotExist(err) {","\t\t\treturn \"\", false, nil","\t\treturn \"\", false, errors.WithStack(err)","\tengineType, err := parseRaftEngineType(strings.TrimSpace(string(data)))","\t\treturn \"\", false, errors.Wrapf(err, \"invalid raft engine marker %s\", path)","\treturn engineType, true, nil","func detectRaftEngineFromDataDir(dir string) (raftEngineType, bool, error) {","\tetcdArtifacts, err := hasRaftArtifacts(dir,","\t\t\"wal\",","\t\t\"snap\",","\t\tfilepath.Join(\"member\", \"wal\"),","\t\tfilepath.Join(\"member\", \"snap\"),","\t\t\"etcd-raft-state.bin\",","\t\t\"etcd-raft-meta.bin\",","\t\t\"etcd-raft-entries.bin\",","\t\t\"etcd-raft-peers.bin\",","\t\t\"etcd-fsm-snapshot.bin\",","\t\treturn \"\", false, err","\tif etcdArtifacts {","\t\treturn raftEngineEtcd, true, nil","\treturn \"\", false, nil","func hasRaftArtifacts(dir string, paths ...string) (bool, error) {","\tfor _, rel := range paths {","\t\tif _, err := os.Stat(filepath.Join(dir, rel)); err == nil {","\t\t\treturn true, nil","\t\t} else if !os.IsNotExist(err) {","\t\t\treturn false, errors.WithStack(err)","\treturn false, nil","func writeRaftEngineMarker(path string, engineType raftEngineType) error {","\tif err := os.WriteFile(path, []byte(string(engineType)+\"\\n\"), raftEngineMarkerPerm); err != nil {","\treturn syncDataDir(filepath.Dir(path))","func syncDataDir(path string) error {","\tdir, err := os.Open(path)","\tdefer dir.Close()","\tif err := dir.Sync(); err != nil {","\treturn nil","func buildRuntimeForGroup(","\traftID string,","\tgroup groupSpec,","\tbaseDir string,","\tmulti bool,","\tbootstrap bool,","\tbootstrapServers []raftengine.Server,","\tst store.MVCCStore,","\tsm raftengine.StateMachine,","\tfactory raftengine.Factory,",") (*raftGroupRuntime, error) {","\tdir := groupDataDir(baseDir, raftID, group.id, multi)","\tengineType := raftEngineType(factory.EngineType())","\tif err := ensureRaftEngineDataDir(dir, engineType); err != nil {","\t\treturn nil, err","\tresult, err := factory.Create(raftengine.FactoryConfig{","\t\tLocalID: raftID,","\t\tLocalAddress: group.address,","\t\tDataDir: dir,","\t\tPeers: bootstrapServers,","\t\tBootstrap: bootstrap,","\t\tStateMachine: sm,","\t\treturn nil, errors.WithStack(err)","\treturn &raftGroupRuntime{","\t\tspec: group,","\t\tengine: result.Engine,","\t\tstore: st,","\t\tregisterTransport: result.RegisterTransport,","\t\tcloseFactory: result.Close,","\t}, nil",[1549],{"_1089":1090,"_1091":1550,"_454":1551,"_1094":57},737,[1404,184,1096,1097,1552,1553,1554,1406,1099,1555,1407,1408,1409,1104,184,1556,1557,1105,1106,1107,1108,1109,1558,1110,1111,1112,1559,1116,1117,184,1420,1560,1561,1562,1563,1564,1565,1566,1567,1568,1569,1570,1571,1572,1573,1574,1575,1576,1117,184,1118,1577,1578,1579,1580,1581,1582,1583,1584,1117,184,1172,1585,1586,1587,1132,184,1588,1589,1590,1591,1592,1593,1594,1595,1596,1597,1598,1599,1600,1601,1602,1603,1604,1605,1606,1607,1608,1609,1610,1132,184,1611,1612,184,1613,184,1614,1615,1616,1617,1618,1619,1620,1621,1622,1623,1624,1625,1626,1627,1628,1629,1630,1631,1632,1633,1137,1634,1635,1636,1137,1637,1638,1639,1640,1641,1642,1643,1137,1644,1645,1646,1647,1648,1649,1650,1651,1652,1653,1654,1655,1656,1657,1658,1645,1659,1660,1661,1662,1650,1651,1663,1653,1664,1665,1666,1667,1658,1645,1668,1669,1670,1671,1650,1651,1672,1653,1673,1674,1666,1667,1658,1137,184,1675,1676,1677,1678,1679,1265,1680,1681,1682,1683,1684,1685,1686,1687,1137,1688,1689,1690,184,1265,1691,1692,1693,1694,1695,1696,1697,1698,1699,1700,1701,1702,1703,1142,1137,184,1704,1705,1706,1707,1708,1709,1710,1711,1152,184,1712,1713,1714,1152,1132,184,1715,1716,1717,1718,1152,1719,1132,184,1720,1721,1722,1723,1724,1725,1726,1137,1727,1728,1726,1137,1729,1152,1730,1233,1540,1152,1731,1732,1233,1540,1152,1733,1132,184,1734,1735,1736,1737,1738,1739,1740,1152,1741,1742,1743,1744,1745,1746,1132,184,1747,1748,1749,1750,1751,1752,1753,1754,1142,1137,1152,1755,1756,184,1757,1233,1540,1152,1737,1758,1759,1760,1761,1132,184,1762,1763,1764,1525,1765,1766,1767,1768,1769,1770,1771,1772,1773,1774,1775,1152,1776,1777,1152,1778,1779,1780,1751,1781,1782,1293,1142,1783,1784,1785,1293,1142,1786,1137,1152,1787,184,1788,1233,1540,1152,1789,1233,1790,1532,1152,1737,1791,1792,1793,1794,1795,1796,1797,1798,1799,1761,1132,184,1800,1801,1802,1803,1804,1805,1806,1142,1137,1152,1807,1808,1233,1540,1152,1737,1809,1810,1811,1761,1132,184,1812,1813,1814,1815,1816,1817,1818,1819,1820,1821,1822,1131,184,1823,1824,1825,1728,1726,1137,1826,1827,1828,1540,1152,184,1829,1830,1831,1832,1833,1834,1835,1836,1507,1726,1137,1152,184,1533,1837,1838,1839,1840,1841,1842,1131,1233,1540,1152,1843,1844,1845,1846,1137,1131,1847,1132,184,1848,1849,1850,1851,184,1852,1233,1461,1152,1853,1854,1855,1856,184,1857,1233,1461,1152,184,1858,1859,1860,1736,1861,1862,1863,1864,1865,1866,1867,1868,1869,1870,1871,1454,1152,1872,1873,1874,1875,1876,1219,1877,1878,1879,1880,1881,1882,1883,1884,1885,1886,1887,1888,1219,1889,184,1890,184,1891,1233,1454,1152,1843,1238,1131,184,1892,184,1893,1233,1461,1152,1894,1895,1233,1461,1152,1896,1897,1233,1461,1152,1898,1899,1233,1461,1152,184,1900,1901,1902,1903,1904,1905,1906,1907,1908,1909,1910,1911,1912,1913,1914,1915,184,1916,1517,1132,184,1917,1918,1233,1282,1152,1919,1920,1152,1921,1233,1282,1152,1922,1923,1152,1924,1132,184,1925,1926,1927,1928,1152,1929,1930,1152,1931,1932,1152,1933,1233,1934,1152,1935,1936,1132,184,1937,1938,1939,1928,1152,1940,1941,1152,1942,1943,1152,1944,1233,1934,1152,1945,1946,1132,184,1947,1948,1949,1950,1137,1469,1152,1132,184,1951,1948,1952,1953,1954,1955,1956,1137,1957,1958,1959,1142,1137,1469,1152,1132,184,1960,1948,1961,1962,1963,1964,1137,1454,1152,1132,184,1965,1948,1952,1966,1967,1469,1152,1132,184,1968,1948,1969,1970,1971,1964,1137,1454,1152,1132,184,1972,1948,1952,1973,1974,1469,1152,1132,184,1975,1948,1976,1977,1971,1964,1137,1454,1152,1132,184,1978,1948,1952,1979,1980,1469,1152,1132,184,1981,1948,1982,1983,1971,1964,1137,1454,1152,1132,184,1984,1985,1132,184,1986,1987,1988,1132,184,1989,1990,1991,1992,1152,1993,1233,1540,1152,1994,1995,1540,1152,1996,1997,1998,1999,2000,2001,1137,2002,1152,2003,1132],"\t\"encoding/json\"","\t\"flag\"","\t\"io\"","\t\"net/http\"","\t\"github.com/bootjp/elastickv/adapter\"","\t\"github.com/bootjp/elastickv/distribution\"","\t\"github.com/bootjp/elastickv/monitoring\"","\t\"golang.org/x/sync/errgroup\"","\taddress = flag.String(\"address\", \":50051\", \"gRPC/Raft address\")","\tredisAddress = flag.String(\"redisAddress\", \":6379\", \"Redis address\")","\tdynamoAddress = flag.String(\"dynamoAddress\", \":8000\", \"DynamoDB-compatible API address\")","\ts3Address = flag.String(\"s3Address\", \":9000\", \"S3-compatible API address\")","\ts3Region = flag.String(\"s3Region\", \"us-east-1\", \"S3 signing region\")","\ts3CredsFile = flag.String(\"s3CredentialsFile\", \"\", \"Path to a JSON file containing static S3 credentials\")","\ts3PathStyle = flag.Bool(\"s3PathStyleOnly\", true, \"Only accept path-style S3 requests\")","\tmetricsAddress = flag.String(\"metricsAddress\", \"127.0.0.1:9090\", \"Prometheus metrics address\")","\tmetricsToken = flag.String(\"metricsToken\", \"\", \"Bearer token for Prometheus metrics; required for non-loopback metricsAddress\")","\tpprofAddress = flag.String(\"pprofAddress\", \"localhost:6060\", \"TCP host+port for pprof debug endpoints; empty to disable\")","\tpprofToken = flag.String(\"pprofToken\", \"\", \"Bearer token for pprof; required for non-loopback pprofAddress\")","\traftID = flag.String(\"raftId\", \"\", \"Raft ID\")","\traftDataDir = flag.String(\"raftDataDir\", \"/var/lib/elastickv\", \"Raft data directory\")","\traftBootstrap = flag.Bool(\"raftBootstrap\", false, \"Bootstrap cluster\")","\traftRedisMap = flag.String(\"raftRedisMap\", \"\", \"Map of Raft address to Redis address (raftAddr=redisAddr,...)\")","\traftS3Map = flag.String(\"raftS3Map\", \"\", \"Map of Raft address to S3 address (raftAddr=s3Addr,...)\")","\traftDynamoMap = flag.String(\"raftDynamoMap\", \"\", \"Map of Raft address to DynamoDB address (raftAddr=dynamoAddr,...)\")","\tkvParts = 2","\tdefaultFileMode = 0755","\traftObserveInterval = 5 * time.Second","\tdemoTickInterval = 10 * time.Millisecond","\tdemoHeartbeatTick = 1","\tdemoElectionTick = 10","\tdemoMaxSizePerMsg = 1 << 20","\tdemoMaxInflightMsg = 256","\tslog.SetDefault(slog.New(slog.NewJSONHandler(os.Stdout, &slog.HandlerOptions{","\t\tLevel: slog.LevelInfo,","\t})))","type config struct {","\taddress string","\tredisAddress string","\tdynamoAddress string","\ts3Address string","\ts3Region string","\ts3CredsFile string","\ts3PathStyle bool","\tmetricsAddress string","\tmetricsToken string","\tpprofAddress string","\tpprofToken string","\traftID string","\traftDataDir string","\traftBootstrap bool","\traftRedisMap string","\traftS3Map string","\traftDynamoMap string","\t// raftPeers, when non-empty, seeds the etcd raft factory with the","\t// full cluster membership. Demo mode populates it for every node so","\t// non-bootstrap nodes start with a known peer list instead of","\t// failing with \"no persisted peers and no peer list was supplied\".","\traftPeers []raftengine.Server","func main() {","\tflag.Parse()","\teg, runCtx := errgroup.WithContext(context.Background())","\tif *raftID != \"\" {","\t\t// Single node mode","\t\tcfg := config{","\t\t\taddress: *address,","\t\t\tredisAddress: *redisAddress,","\t\t\tdynamoAddress: *dynamoAddress,","\t\t\ts3Address: *s3Address,","\t\t\ts3Region: *s3Region,","\t\t\ts3CredsFile: *s3CredsFile,","\t\t\ts3PathStyle: *s3PathStyle,","\t\t\tmetricsAddress: *metricsAddress,","\t\t\tmetricsToken: *metricsToken,","\t\t\tpprofAddress: *pprofAddress,","\t\t\tpprofToken: *pprofToken,","\t\t\traftID: *raftID,","\t\t\traftDataDir: *raftDataDir,","\t\t\traftBootstrap: *raftBootstrap,","\t\t\traftRedisMap: *raftRedisMap,","\t\t\traftS3Map: *raftS3Map,","\t\t\traftDynamoMap: *raftDynamoMap,","\t\tif err := run(runCtx, eg, cfg); err != nil {","\t\t\tslog.Error(err.Error())","\t\t\tos.Exit(1)","\t} else {","\t\t// Demo cluster mode (3 nodes)","\t\tslog.Info(\"Starting demo cluster with 3 nodes...\")","\t\tdemoMetricsToken := effectiveDemoMetricsToken(*metricsToken)","\t\tdemoPprofAddresses := []string{\"127.0.0.1:6061\", \"127.0.0.1:6062\", \"127.0.0.1:6063\"}","\t\tif strings.TrimSpace(*pprofAddress) == \"\" {","\t\t\tdemoPprofAddresses = []string{\"\", \"\", \"\"}","\t\tnodes := []config{","\t\t\t{","\t\t\t\taddress: \"127.0.0.1:50051\",","\t\t\t\tredisAddress: \"127.0.0.1:63791\",","\t\t\t\tdynamoAddress: \"127.0.0.1:63801\",","\t\t\t\ts3Address: \"127.0.0.1:63901\",","\t\t\t\ts3Region: \"us-east-1\",","\t\t\t\ts3PathStyle: true,","\t\t\t\tmetricsAddress: \"0.0.0.0:9091\",","\t\t\t\tmetricsToken: demoMetricsToken,","\t\t\t\tpprofAddress: demoPprofAddresses[0],","\t\t\t\traftID: \"n1\",","\t\t\t\traftDataDir: \"\", // In-memory","\t\t\t\traftBootstrap: true,","\t\t\t},","\t\t\t\taddress: \"127.0.0.1:50052\",","\t\t\t\tredisAddress: \"127.0.0.1:63792\",","\t\t\t\tdynamoAddress: \"127.0.0.1:63802\",","\t\t\t\ts3Address: \"127.0.0.1:63902\",","\t\t\t\tmetricsAddress: \"0.0.0.0:9092\",","\t\t\t\tpprofAddress: demoPprofAddresses[1],","\t\t\t\traftID: \"n2\",","\t\t\t\traftDataDir: \"\",","\t\t\t\traftBootstrap: false,","\t\t\t\taddress: \"127.0.0.1:50053\",","\t\t\t\tredisAddress: \"127.0.0.1:63793\",","\t\t\t\tdynamoAddress: \"127.0.0.1:63803\",","\t\t\t\ts3Address: \"127.0.0.1:63903\",","\t\t\t\tmetricsAddress: \"0.0.0.0:9093\",","\t\t\t\tpprofAddress: demoPprofAddresses[2],","\t\t\t\traftID: \"n3\",","\t\t// Build raftRedisMap/raftS3Map/raftDynamoMap strings.","\t\tvar redisMapParts []string","\t\tvar s3MapParts []string","\t\tvar dynamoMapParts []string","\t\tpeers := make([]raftengine.Server, 0, len(nodes))","\t\t\tredisMapParts = append(redisMapParts, n.address+\"=\"+n.redisAddress)","\t\t\ts3MapParts = append(s3MapParts, n.address+\"=\"+n.s3Address)","\t\t\tdynamoMapParts = append(dynamoMapParts, n.address+\"=\"+n.dynamoAddress)","\t\t\tpeers = append(peers, raftengine.Server{","\t\t\t\tSuffrage: \"voter\",","\t\t\t\tID: n.raftID,","\t\t\t\tAddress: n.address,","\t\t\t})","\t\traftRedisMapStr := strings.Join(redisMapParts, \",\")","\t\traftS3MapStr := strings.Join(s3MapParts, \",\")","\t\traftDynamoMapStr := strings.Join(dynamoMapParts, \",\")","\t\t\tn.raftRedisMap = raftRedisMapStr","\t\t\tn.raftS3Map = raftS3MapStr","\t\t\tn.raftDynamoMap = raftDynamoMapStr","\t\t\tn.raftPeers = peers","\t\t\t// etcd raft requires every member of a fresh cluster to","\t\t\t// bootstrap with the same peer list. Override the per-node","\t\t\t// raftBootstrap flag in demo mode so n2/n3 don't fail with","\t\t\t// \"no persisted peers and no peer list was supplied\".","\t\t\tn.raftBootstrap = true","\t\t\tcfg := n // capture loop variable","\t\t\tif err := run(runCtx, eg, cfg); err != nil {","\t\t\t\tslog.Error(err.Error())","\t\t\t\tos.Exit(1)","\t\t// All three nodes were started with the same raftPeers list and","\t\t// raftBootstrap=true above, so the etcd cluster is fully formed","\t\t// at startup. joinCluster (AddVoter via raftadmin against","\t\t// nodes[0]) is no longer needed and would actively misbehave","\t\t// under etcd's randomised elections — nodes[0] is not guaranteed","\t\t// to be leader, so the AddVoter RPC would either hit a follower","\t\t// and be rejected, or add duplicates to an already-complete","\t\t// configuration.","\tif err := eg.Wait(); err != nil {","\t\tslog.Error(err.Error())","\t\tos.Exit(1)","func effectiveDemoMetricsToken(token string) string {","\ttoken = strings.TrimSpace(token)","\tif token != \"\" {","\t\treturn token","\treturn \"demo-metrics-token\"","// setupFSMStore creates and returns the MVCCStore for the Raft FSM.","// When raftDataDir is non-empty the store is persisted under that directory;","// otherwise a temporary directory is used and registered for cleanup on exit.","func setupFSMStore(raftDataDir string, cleanup *internalutil.CleanupStack) (store.MVCCStore, error) {","\tif raftDataDir != \"\" {","\t\tif err := os.MkdirAll(raftDataDir, defaultFileMode); err != nil {","\t\t\treturn nil, errors.WithStack(err)","\t\tst, err := store.NewPebbleStore(filepath.Join(raftDataDir, \"fsm.db\"))","\t\tif err != nil {","\t\treturn st, nil","\tfsmDir, err := os.MkdirTemp(\"\", \"elastickv-fsm-*\")","\tcleanup.Add(func() { os.RemoveAll(fsmDir) })","\tst, err := store.NewPebbleStore(fsmDir)","\treturn st, nil","func setupGRPC(ctx context.Context, engine raftengine.Engine, registerTransport func(grpc.ServiceRegistrar), st store.MVCCStore, coordinator *kv.Coordinate, distServer *adapter.DistributionServer, relay *adapter.RedisPubSubRelay, proposalObserver kv.ProposalObserver) (*grpc.Server, *adapter.GRPCServer) {","\ts := grpc.NewServer(internalutil.GRPCServerOptions()...)","\ttrx := kv.NewTransactionWithProposer(engine, kv.WithProposalObserver(proposalObserver))","\troutedStore := kv.NewLeaderRoutedStore(st, coordinator)","\tgs := adapter.NewGRPCServer(routedStore, coordinator, adapter.WithCloseStore())","\tif registerTransport != nil {","\t\tregisterTransport(s)","\tpb.RegisterRawKVServer(s, gs)","\tpb.RegisterTransactionalKVServer(s, gs)","\tpb.RegisterInternalServer(s, adapter.NewInternalWithEngine(trx, engine, coordinator.Clock(), relay))","\tpb.RegisterDistributionServer(s, distServer)","\tinternalraftadmin.RegisterOperationalServices(ctx, s, engine, []string{\"RawKV\"})","\treturn s, gs","func setupRedis(ctx context.Context, lc net.ListenConfig, st store.MVCCStore, coordinator *kv.Coordinate, addr, redisAddr, raftRedisMapStr string, relay *adapter.RedisPubSubRelay, readTracker *kv.ActiveTimestampTracker, deltaCompactor *adapter.DeltaCompactor) (*adapter.RedisServer, error) {","\tleaderRedis := make(map[string]string)","\tif raftRedisMapStr != \"\" {","\t\tparts := strings.SplitSeq(raftRedisMapStr, \",\")","\t\tfor part := range parts {","\t\t\tkv := strings.Split(part, \"=\")","\t\t\tif len(kv) == kvParts {","\t\t\t\tleaderRedis[kv[0]] = kv[1]","\t// Ensure self is in map (override if present)","\tleaderRedis[addr] = redisAddr","\tl, err := lc.Listen(ctx, \"tcp\", redisAddr)","\treturn adapter.NewRedisServer(l, redisAddr, routedStore, coordinator, leaderRedis, relay,","\t\tadapter.WithRedisActiveTimestampTracker(readTracker),","\t\tadapter.WithRedisCompactor(deltaCompactor),","\t), nil","func setupS3(","\tctx context.Context,","\tlc net.ListenConfig,","\tcoordinator *kv.Coordinate,","\taddr string,","\ts3Addr string,","\traftS3MapStr string,","\tregion string,","\tcredentialsFile string,","\tpathStyleOnly bool,","\treadTracker *kv.ActiveTimestampTracker,",") (*adapter.S3Server, error) {","\tif !pathStyleOnly {","\t\treturn nil, errors.New(\"virtual-hosted style S3 requests are not implemented\")","\tif coordinator == nil {","\t\treturn nil, errors.New(\"coordinator must not be nil\")","\tleaderS3 := make(map[string]string)","\tif raftS3MapStr != \"\" {","\t\tparts := strings.SplitSeq(raftS3MapStr, \",\")","\t\t\tpart = strings.TrimSpace(part)","\t\t\tif part == \"\" {","\t\t\tkv := strings.SplitN(part, \"=\", kvParts)","\t\t\tif len(kv) != kvParts {","\t\t\t\tslog.Warn(\"ignoring invalid raft-s3 map entry; expected format addr=s3addr\", \"entry\", part)","\t\t\tleaderS3[strings.TrimSpace(kv[0])] = strings.TrimSpace(kv[1])","\tleaderS3[addr] = s3Addr","\tl, err := lc.Listen(ctx, \"tcp\", s3Addr)","\tstaticCreds, err := loadS3StaticCredentials(credentialsFile)","\t\t_ = l.Close()","\treturn adapter.NewS3Server(","\t\tl,","\t\ts3Addr,","\t\troutedStore,","\t\tcoordinator,","\t\tleaderS3,","\t\tadapter.WithS3Region(region),","\t\tadapter.WithS3StaticCredentials(staticCreds),","\t\tadapter.WithS3ActiveTimestampTracker(readTracker),","func setupDynamo(ctx context.Context, lc net.ListenConfig, st store.MVCCStore, coordinator *kv.Coordinate, addr, dynamoAddr, raftDynamoMapStr string, observer monitoring.DynamoDBRequestObserver) (*adapter.DynamoDBServer, error) {","\tleaderDynamo := make(map[string]string)","\tif raftDynamoMapStr != \"\" {","\t\tfor part := range strings.SplitSeq(raftDynamoMapStr, \",\") {","\t\t\tpair := strings.SplitN(part, \"=\", kvParts)","\t\t\tif len(pair) == kvParts {","\t\t\t\tleaderDynamo[pair[0]] = pair[1]","\tleaderDynamo[addr] = dynamoAddr","\tl, err := lc.Listen(ctx, \"tcp\", dynamoAddr)","\treturn adapter.NewDynamoDBServer(l, routedStore, coordinator,","\t\tadapter.WithDynamoDBRequestObserver(observer),","\t\tadapter.WithDynamoDBLeaderMap(leaderDynamo),","// openRaftEngine creates the etcd-backed raft engine for a demo node. It","// resolves the data dir (using a temp dir when cfg.raftDataDir is empty),","// refuses to start on top of legacy hashicorp/raft state, and registers","// cleanup callbacks for the data dir, engine and factory resources.","func openRaftEngine(cfg config, fsm raftengine.StateMachine, cleanup *internalutil.CleanupStack) (*raftengine.FactoryResult, error) {","\tfactory := etcdraftengine.NewFactory(etcdraftengine.FactoryConfig{","\t\tTickInterval: demoTickInterval,","\t\tHeartbeatTick: demoHeartbeatTick,","\t\tElectionTick: demoElectionTick,","\t\tMaxSizePerMsg: demoMaxSizePerMsg,","\t\tMaxInflightMsg: demoMaxInflightMsg,","\traftDir := cfg.raftDataDir","\tif raftDir == \"\" {","\t\ttmp, err := os.MkdirTemp(\"\", \"elastickv-raft-*\")","\t\tcleanup.Add(func() { os.RemoveAll(tmp) })","\t\traftDir = tmp","\t} else if err := os.MkdirAll(raftDir, defaultFileMode); err != nil {","\t// Refuse to start on top of hashicorp/raft artifacts from a previous","\t// deployment. The backend has been removed and silently overwriting","\t// its state with etcd markers could commit to an incompatible engine","\t// over committed data. Fail fast so operators have to migrate","\t// explicitly.","\tfor _, legacy := range []string{\"raft.db\", \"logs.dat\", \"stable.dat\"} {","\t\tif _, err := os.Stat(filepath.Join(raftDir, legacy)); err == nil {","\t\t\treturn nil, errors.WithStack(errors.Newf(\"legacy hashicorp/raft artifact %q found in %s; hashicorp backend has been removed, manual migration required\", legacy, raftDir))","\t\tLocalID: cfg.raftID,","\t\tLocalAddress: cfg.address,","\t\tDataDir: raftDir,","\t\tPeers: cfg.raftPeers,","\t\tBootstrap: cfg.raftBootstrap,","\t\tStateMachine: fsm,","\tcleanup.Add(func() {","\t\t_ = result.Engine.Close()","\t\tif result.Close != nil {","\t\t\t_ = result.Close()","\treturn result, nil","func run(ctx context.Context, eg *errgroup.Group, cfg config) error {","\tvar lc net.ListenConfig","\tcleanup := internalutil.CleanupStack{}","\tdefer cleanup.Run()","\tst, err := setupFSMStore(cfg.raftDataDir, &cleanup)","\tcleanup.Add(func() { st.Close() })","\thlc := kv.NewHLC()","\tfsm := kv.NewKvFSMWithHLC(st, hlc)","\treadTracker := kv.NewActiveTimestampTracker()","\tresult, err := openRaftEngine(cfg, fsm, &cleanup)","\tmetricsRegistry := monitoring.NewRegistry(cfg.raftID, cfg.address)","\tproposalObserver := metricsRegistry.RaftProposalObserver(1)","\tengine := result.Engine","\tcoordinator := kv.NewCoordinatorWithEngine(trx, engine, kv.WithHLC(hlc))","\tdefer func() {","\t\t// Release the leader-loss callback slot on the engine before","\t\t// the process exits. The engine itself is closed elsewhere in","\t\t// the shutdown path; both orderings are safe, but releasing","\t\t// the closure here matches the symmetric construction order.","\t\t_ = coordinator.Close()","\t}()","\tdistEngine := distribution.NewEngineWithDefaultRoute()","\tdistCatalog := distribution.NewCatalogStore(st)","\tif _, err := distribution.EnsureCatalogSnapshot(ctx, distCatalog, distEngine); err != nil {","\tdistServer := adapter.NewDistributionServer(","\t\tdistEngine,","\t\tdistCatalog,","\t\tadapter.WithDistributionCoordinator(coordinator),","\t\tadapter.WithDistributionActiveTimestampTracker(readTracker),","\tmetricsRegistry.RaftObserver().Start(ctx, []monitoring.RaftRuntime{{","\t\tGroupID: 1,","\t\tStatusReader: engine,","\t\tConfigReader: engine,","\t}}, raftObserveInterval)","\tcompactor := kv.NewFSMCompactor(","\t\t[]kv.FSMCompactRuntime{{","\t\t\tGroupID: 1,","\t\t\tStatusReader: engine,","\t\t\tStore: st,","\t\t}},","\t\tkv.WithFSMCompactorActiveTimestampTracker(readTracker),","\trelay := adapter.NewRedisPubSubRelay()","\ts, grpcSvc := setupGRPC(ctx, engine, result.RegisterTransport, st, coordinator, distServer, relay, proposalObserver)","\tgrpcSock, err := lc.Listen(ctx, \"tcp\", cfg.address)","\tdeltaCompactor := adapter.NewDeltaCompactor(st, coordinator)","\trd, err := setupRedis(ctx, lc, st, coordinator, cfg.address, cfg.redisAddress, cfg.raftRedisMap, relay, readTracker, deltaCompactor)","\tcleanup.Add(rd.Stop)","\ts3s, err := setupS3(ctx, lc, st, coordinator, cfg.address, cfg.s3Address, cfg.raftS3Map, cfg.s3Region, cfg.s3CredsFile, cfg.s3PathStyle, readTracker)","\tcleanup.Add(s3s.Stop)","\tds, err := setupDynamo(ctx, lc, st, coordinator, cfg.address, cfg.dynamoAddress, cfg.raftDynamoMap, metricsRegistry.DynamoDBObserver())","\tcleanup.Add(ds.Stop)","\tmetricsL, ms, pprofL, ps, err := setupObservabilityServers(ctx, lc, &cleanup, cfg, metricsRegistry.Handler())","\teg.Go(func() error { coordinator.RunHLCLeaseRenewal(ctx); return nil })","\teg.Go(catalogWatcherTask(ctx, distCatalog, distEngine))","\teg.Go(func() error { return compactor.Run(ctx) })","\teg.Go(func() error { return deltaCompactor.Run(ctx) })","\teg.Go(grpcShutdownTask(ctx, s, grpcSock, cfg.address, grpcSvc))","\teg.Go(grpcServeTask(s, grpcSock, cfg.address))","\teg.Go(redisShutdownTask(ctx, rd, cfg.redisAddress))","\teg.Go(redisServeTask(rd, cfg.redisAddress))","\teg.Go(s3ShutdownTask(ctx, s3s, cfg.s3Address))","\teg.Go(s3ServeTask(s3s, cfg.s3Address))","\teg.Go(dynamoShutdownTask(ctx, ds, cfg.dynamoAddress))","\teg.Go(dynamoServeTask(ds, cfg.dynamoAddress))","\teg.Go(monitoring.MetricsShutdownTask(ctx, ms, cfg.metricsAddress))","\teg.Go(monitoring.MetricsServeTask(ms, metricsL, cfg.metricsAddress))","\teg.Go(monitoring.PprofShutdownTask(ctx, ps, cfg.pprofAddress))","\teg.Go(monitoring.PprofServeTask(ps, pprofL, cfg.pprofAddress))","\tcleanup.Release()","func setupObservabilityServers(ctx context.Context, lc net.ListenConfig, cleanup *internalutil.CleanupStack, cfg config, metricsHandler http.Handler) (metricsL net.Listener, ms *http.Server, pprofL net.Listener, ps *http.Server, err error) {","\tmetricsL, ms, err = setupMetricsHTTPServer(ctx, lc, cfg.metricsAddress, cfg.metricsToken, metricsHandler)","\tif metricsL != nil {","\t\tcleanup.Add(func() { _ = metricsL.Close() })","\tpprofL, ps, err = setupPprofHTTPServer(ctx, lc, cfg.pprofAddress, cfg.pprofToken)","\tif pprofL != nil {","\t\tcleanup.Add(func() { _ = pprofL.Close() })","\treturn","func setupMetricsHTTPServer(ctx context.Context, lc net.ListenConfig, metricsAddress string, metricsToken string, handler http.Handler) (net.Listener, *http.Server, error) {","\tmetricsAddress = strings.TrimSpace(metricsAddress)","\tif metricsAddress == \"\" || handler == nil {","\t\treturn nil, nil, nil","\tif _, _, err := net.SplitHostPort(metricsAddress); err != nil {","\t\treturn nil, nil, errors.Wrapf(err, \"invalid metricsAddress %q\", metricsAddress)","\tif monitoring.AddressRequiresToken(metricsAddress) && strings.TrimSpace(metricsToken) == \"\" {","\t\treturn nil, nil, errors.New(\"metricsToken is required when metricsAddress is not loopback\")","\tmetricsL, err := lc.Listen(ctx, \"tcp\", metricsAddress)","\t\treturn nil, nil, errors.WithStack(err)","\tms := monitoring.NewMetricsServer(handler, metricsToken)","\treturn metricsL, ms, nil","func setupPprofHTTPServer(ctx context.Context, lc net.ListenConfig, pprofAddress string, pprofToken string) (net.Listener, *http.Server, error) {","\tpprofAddress = strings.TrimSpace(pprofAddress)","\tif pprofAddress == \"\" {","\tif _, _, err := net.SplitHostPort(pprofAddress); err != nil {","\t\treturn nil, nil, errors.Wrapf(err, \"invalid pprofAddress %q\", pprofAddress)","\tif monitoring.AddressRequiresToken(pprofAddress) && strings.TrimSpace(pprofToken) == \"\" {","\t\treturn nil, nil, errors.New(\"pprofToken is required when pprofAddress is not loopback\")","\tpprofL, err := lc.Listen(ctx, \"tcp\", pprofAddress)","\tps := monitoring.NewPprofServer(pprofToken)","\treturn pprofL, ps, nil","func catalogWatcherTask(ctx context.Context, distCatalog *distribution.CatalogStore, distEngine *distribution.Engine) func() error {","\treturn func() error {","\t\tif err := distribution.RunCatalogWatcher(ctx, distCatalog, distEngine, slog.Default()); err != nil {","\t\t\treturn errors.Wrapf(err, \"catalog watcher failed\")","func grpcShutdownTask(ctx context.Context, server *grpc.Server, listener net.Listener, address string, closer io.Closer) func() error {","\t\t<-ctx.Done()","\t\tslog.Info(\"Shutting down gRPC server\", \"address\", address, \"reason\", ctx.Err())","\t\tserver.GracefulStop()","\t\tif err := listener.Close(); err != nil && !errors.Is(err, net.ErrClosed) {","\t\t\tslog.Error(\"Failed to close gRPC listener\", \"address\", address, \"err\", err)","\t\tif closer != nil {","\t\t\tif err := closer.Close(); err != nil {","\t\t\t\tslog.Error(\"Failed to close gRPC service\", \"address\", address, \"err\", err)","func grpcServeTask(server *grpc.Server, listener net.Listener, address string) func() error {","\t\tslog.Info(\"Starting gRPC server\", \"address\", address)","\t\terr := server.Serve(listener)","\t\tif err == nil || errors.Is(err, grpc.ErrServerStopped) || errors.Is(err, net.ErrClosed) {","\t\t\treturn nil","func redisShutdownTask(ctx context.Context, redisServer *adapter.RedisServer, address string) func() error {","\t\tslog.Info(\"Shutting down Redis server\", \"address\", address, \"reason\", ctx.Err())","\t\tredisServer.Stop()","func redisServeTask(redisServer *adapter.RedisServer, address string) func() error {","\t\tslog.Info(\"Starting Redis server\", \"address\", address)","\t\terr := redisServer.Run()","\t\tif err == nil || errors.Is(err, net.ErrClosed) {","func dynamoShutdownTask(ctx context.Context, dynamoServer *adapter.DynamoDBServer, address string) func() error {","\t\tslog.Info(\"Shutting down DynamoDB server\", \"address\", address, \"reason\", ctx.Err())","\t\tdynamoServer.Stop()","func dynamoServeTask(dynamoServer *adapter.DynamoDBServer, address string) func() error {","\t\tslog.Info(\"Starting DynamoDB server\", \"address\", address)","\t\terr := dynamoServer.Run()","func s3ShutdownTask(ctx context.Context, s3Server *adapter.S3Server, address string) func() error {","\t\tslog.Info(\"Shutting down S3 server\", \"address\", address, \"reason\", ctx.Err())","\t\ts3Server.Stop()","func s3ServeTask(s3Server *adapter.S3Server, address string) func() error {","\t\tslog.Info(\"Starting S3 server\", \"address\", address)","\t\terr := s3Server.Run()","type s3CredentialFile struct {","\tCredentials []s3CredentialEntry `json:\"credentials\"`","type s3CredentialEntry struct {","\tAccessKeyID string `json:\"access_key_id\"`","\tSecretAccessKey string `json:\"secret_access_key\"`","func loadS3StaticCredentials(path string) (map[string]string, error) {","\tpath = strings.TrimSpace(path)","\tif path == \"\" {","\t\treturn nil, nil","\tbody, err := os.ReadFile(path)","\tfile := s3CredentialFile{}","\tif err := json.Unmarshal(body, &file); err != nil {","\tout := make(map[string]string, len(file.Credentials))","\tfor _, cred := range file.Credentials {","\t\taccessKeyID := strings.TrimSpace(cred.AccessKeyID)","\t\tsecretAccessKey := strings.TrimSpace(cred.SecretAccessKey)","\t\tif accessKeyID == \"\" || secretAccessKey == \"\" {","\t\t\treturn nil, errors.New(\"s3 credentials file contains an empty access key or secret key\")","\t\tout[accessKeyID] = secretAccessKey","\treturn out, nil",[2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016,2017],{"_1066":45,"_45":2039},{"_1066":2019,"_155":875,"_1089":2037,"_1091":2038},{"_1066":2019,"_155":875,"_1089":2035,"_1091":2036},{"_1066":2019,"_155":875,"_1089":2033,"_1091":2034},{"_1066":45,"_45":2032},{"_1066":2019,"_155":875,"_1089":2030,"_1091":2031},{"_1066":45,"_45":2029},{"_1066":2019,"_155":849,"_1089":2027,"_1091":2028},{"_1066":2019,"_155":849,"_1089":2025,"_1091":2026},{"_1066":45,"_45":2024},{"_1066":2019,"_155":793,"_1089":2022,"_1091":2023},{"_1066":2019,"_155":793,"_1089":2020,"_1091":2021},{"_1066":45,"_45":2018},"\n* No additional code edits were required in this follow-up pass, so no new commit was created and no `make_pr` call was made.\n\n**Testing**\n* ✅ `git log --oneline -n 5`\n* ✅ `go test ./cmd/server -run TestDoesNotExist -count=1`\n* ✅ `go test . -run TestEnsureRaftEngineDataDir -count=1`\n* ⚠️ `timeout 90s go test ./... -run TestDetectRaftEngineFromDataDirRejectsLegacyHashicorpArtifacts -count=1` (timed out in this environment before producing output)","repo_file_citation",268,312,238,244,"\n* Confirmed the adapter test helper includes leadership transfer logic to force node 0 leader in tests that assume `hosts[0]` leadership. ",125,131,94,103,"\n * Main runtime still fails fast on legacy Hashicorp artifact directories via `ensureRaftEngineDataDir` and `hasHashicorpRaftArtifacts`. ",409,417,"\n * Demo startup now explicitly rejects legacy Hashicorp raft artifacts (`raft.db`, `logs.dat`, `stable.dat`) before creating an etcd engine. ",422,429,195,205,86,90,"### Summary\n* Verified the two review issues called out in the PR thread are already addressed on the current branch:\n * Demo cluster startup now passes a full peer list to every node (`raftPeers`) and starts demo nodes with bootstrap enabled, which avoids the “no persisted peers and no peer list was supplied” failure path for non-bootstrap nodes. ",{"_90":308,"_41":82,"_94":308,"_2042":2043,"_2044":2045,"_2046":2047,"_130":-5,"_117":2048},[81],"input_items",[2066,2067,2068,2069,2070,2071,2072,2073,2074,2075,2076],"external_post_config",{"_2049":2050,"_247":181,"_2051":288,"_258":-5,"_2052":241,"_2053":-5,"_2054":2055,"_2056":2057,"_2058":-5,"_2059":-5,"_2060":2061,"_2062":15,"_2063":57,"_2064":52,"_2065":15},"user_model_slug","slug",1776886873.948122,"installation_id",78531334,"pr_number","repo_id","review_trigger","comment_id",4299399784,"comment_type","issue","pr_write_guard_token","pending_pr_reaction_id","pending_comment_reaction_id",349701715,"comment_if_no_findings","comment_on_error","share_url","is_parallel_review",{"_90":459,"_94":308,"_454":2096},{"_295":296,"_297":2091,"_2092":302,"_2093":2094,"_304":-5,"_90":2095},{"_90":2077,"_297":2089,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2090,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2089,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2088,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2087,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2086,"_155":875,"_2079":2080,"_2081":2082},{"_90":2077,"_297":2084,"_155":849,"_2079":2080,"_2081":2085},{"_90":2077,"_297":2083,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2078,"_155":875,"_2079":2080,"_2081":2082},"pull_request_comment","**_{_{![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)}} Validate demo Raft data dir before creating engine**\n\nThis code opens the etcd engine directly from `raftDir` without any compatibility check for legacy Hashicorp Raft artifacts; the previous `setupStorage` path rejected `logs.dat`/`stable.dat` before startup. In a restart/upgrade where `--raftDataDir` still contains legacy state, the node can initialize a fresh etcd Raft store instead of failing fast, which effectively ignores prior committed history and risks silent data loss. Add the same data-dir engine validation used in the main runtime before calling `factory.Create`.\n\nUseful? React with 👍 / 👎.","side","RIGHT","line",546,"\n### 💡 Codex Review\n\nHere are some automated review suggestions for this pull request.\n\n**Reviewed commit:** `c5dc58a523`\n \n\n

ℹ️ About Codex in GitHub

","**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Keep rejecting legacy Hashicorp raft artifacts**\n\n`detectRaftEngineFromDataDir` now only checks etcd markers, so a pre-marker data dir that still contains Hashicorp artifacts (`raft.db`, `logs.dat`, `stable.dat`) is treated as empty and gets an etcd marker written. On upgrade this can allow bootstrapping an incompatible engine over existing state instead of failing fast with `ErrRaftEngineDataDir`, which risks losing committed cluster history.\n\nUseful? React with 👍 / 👎.",151,"**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Pass peer config when creating demo Raft engines**\n\nThis `Create` call never sets `Peers`, so in demo mode the non-bootstrap nodes (`raftBootstrap=false` for n2/n3 in the same file) start with an empty peer list and etcd rejects startup before `joinCluster` runs. I reproduced this by running `./server` and seeing node startup fail with “no persisted peers and no peer list was supplied”. As written, the 3-node demo path cannot form a cluster.\n\nUseful? React with 👍 / 👎.","\n### 💡 Codex Review\n\nHere are some automated review suggestions for this pull request.\n\n**Reviewed commit:** `a35245a411`\n \n\n

ℹ️ About Codex in GitHub

","\n\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n>

\n>

⚙️ Run configuration

\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro\n> \n> **Run ID**: `179f3410-b62a-4058-9639-fd78a3b293ad`\n> \n>

\n> \n>

\n>

📥 Commits

\n> \n> Reviewing files that changed from the base of the PR and between b95750d6e9239aee45d7b68ac8b55dd890a25e86 and 02782f08228ce8643709cfcf2f338a7fb29aeeff.\n> \n>

\n> \n>

\n>

⛔ Files ignored due to path filters (1)

\n> \n> * `go.sum` is excluded by `!**/*.sum`\n> \n>

\n> \n>

\n>

📒 Files selected for processing (63)

\n> \n> ```ascii\n> _____________________________\n> < Don't hate the know-it-all. >\n> -----------------------------\n> \\\n> \\ (\\__/)\n> (•ㅅ•)\n> / 　づ\n> ```\n\n\n\n\n\n\n

✨ Finishing Touches

\n\n

📝 Generate docstrings

\n\n- [ ] Create stacked PR\n- [ ] Commit on current branch\n\n

🧪 Generate unit tests (beta)

\n\n- [ ] Create PR with unit tests\n- [ ] Commit unit tests in branch `chore/drop-hashicorp-raft`\n\n

\n\n

❤️ Share

\n\n_{Comment `@coderabbitai help` to get the list of available commands and usage tips.}\n\n","> [!WARNING]\n> You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!","/gemini review @codex review","## Summary\n- Delete the `internal/raftengine/hashicorp` backend, the etcd/hashicorp FSM adapter, `internal/raftstore`, and `cmd/etcd-raft-migrate` / `cmd/etcd-raft-rollback`.\n- Flip `kv/` to implement `raftengine.StateMachine` directly — `kvFSM.Apply([]byte)`, `Snapshot() (raftengine.Snapshot, error)`, `Restore(io.Reader)`. Drop the legacy `NewCoordinator(*raft.Raft)` / `NewTransaction` / `NewLeaderProxy` shims.\n- Replace `raft.ServerAddress` / `raft.ServerID` / `raft.Server` / `raft.Voter` with plain `string` and `raftengine.Server` throughout `kv/`, `adapter/`, `main.go`, `shard_config.go`, `cmd/server/demo.go`.\n- Rewrite the in-process test clusters (`kv/sharded_integration_test.go`, `adapter/test_util.go`, `adapter/s3_test.go`, `adapter/distribution_milestone1_e2e_test.go`) on top of the etcd factory with `t.TempDir()` data dirs.\n- Remove hashicorp-specific tests that exercised AddVoter / InmemTransport / boltdb legacy detection (`adapter/add_voter_join_test.go`, `adapter/dynamodb_failure_test.go`, `adapter/redis_list_raft_benchmark_test.go`, bootstrap and mixed-artifact cases in `multiraft_runtime_test.go`).\n- `go mod tidy` drops `hashicorp/raft`, `Jille/raft-grpc-transport`, `hashicorp/go-hclog` and transitive hashicorp deps.\n\nStats: 64 files, +487 / -3703.\n\n## Test plan\n- [x] `go build ./...`\n- [x] `go vet ./...`\n- [x] `go test ./kv/...` (passes in ~5s)\n- [x] `go test ./internal/...` (etcd engine conformance, raftadmin, s3keys)\n- [ ] `go test ./adapter/...` — heavy sequential test `Test_consistency_satisfy_write_after_read_sequence` (9999 × 3 sequential Puts on a 3-node loopback etcd cluster) hangs on `Propose(context.Background())` where it used to complete quickly with hashicorp's InmemTransport. Parallel variant (`Test_consistency_satisfy_write_after_read_for_parallel`, 1000 goroutines) passes in <1s. Other adapter tests pass individually. Needs follow-up on either test timing or etcd engine behavior under slow sequential back-pressure.\n- [ ] bootstrap e2e (`main_bootstrap_e2e_test.go`) — now only exercises the etcd engine variant.\n\n## Notes for reviewers\n- `adapter/test_util.go` now uses the etcd factory with a temp dir per node. Leader election relies on etcd's randomized election timeouts rather than the previous \"node 0 has electionTimeout=0, others wait 10s\" trick; this means the leader is not deterministic, but `waitForRaftReadiness` converges on whichever node wins.\n- `cmd/server/demo.go` now goes through the engine factory instead of constructing a raft instance directly. `setupStorage` / `bootstrapClusterIfNeeded` are gone.\n- `multiraft_runtime.go` no longer tries to detect mixed hashicorp/etcd artifacts — only etcd markers remain.","base_ref","head_ref","02782f08228ce8643709cfcf2f338a7fb29aeeff","pull_request_info",[2097],{"_1066":45,"_45":2098},"@codex address that feedback — commits 02782f08 (demo peers + legacy artifact rejection) and c5dc58a5 (test leader transfer).",[2599,2600],[],{"_1071":1072,"_45":1073,"_1074":1075},{"_1046":2590},{"_319":2589},{"_319":2132},{"_287":288,"_278":289,"_290":291,"_292":57,"_293":15,"_294":15,"_295":296,"_297":298,"_299":251,"_300":125,"_301":302,"_303":127,"_304":305,"_306":-5,"_307":-5,"_308":2131,"_310":311,"_312":313,"_314":315,"_316":317},{"_41":121,"_178":179,"_180":181,"_182":15,"_183":184,"_185":186,"_187":2118,"_189":-5,"_190":-5,"_191":2119,"_193":2120,"_195":2121,"_197":2122,"_199":2123,"_201":2124,"_203":-5,"_204":205,"_206":207,"_208":209,"_210":2125,"_53":-5,"_117":212,"_213":2126,"_215":2127,"_217":218,"_219":15},{"_131":2111},[2109,2110],{"_142":156,"_144":145,"_146":147,"_148":157,"_150":151,"_152":153,"_154":31,"_155":-5},{"_142":143,"_144":145,"_146":147,"_148":149,"_150":151,"_152":153,"_154":31,"_155":-5},[2112,2113,2114],{"_162":2117,"_164":175},{"_162":2116,"_164":171},{"_162":2115,"_164":165},{"_166":167,"_90":168,"_117":169},{"_166":172,"_90":168,"_117":173},{"_166":176,"_90":168,"_117":177},{"_280":281,"_282":283,"_284":184,"_285":-5,"_286":57},[241],[184],[184],{"_241":2128},{"_223":224,"_225":226,"_227":228,"_229":230,"_231":232,"_233":234,"_235":236,"_237":238,"_239":240},{},[],{"_222":57},{"_220":57,"_221":184},{"_41":243,"_166":244,"_245":2129,"_247":181,"_248":249,"_250":251,"_252":253,"_254":255,"_256":257,"_258":62,"_259":15,"_260":-5,"_261":-5,"_262":-5,"_263":-5,"_264":-5,"_265":-5,"_154":266,"_267":-5,"_53":2130},{"_272":273,"_41":274,"_90":275,"_276":277,"_278":279},{"_269":15,"_270":15,"_271":15},{"_272":273,"_166":273,"_318":-5,"_276":277,"_41":274},[2133,2134,2135,2136,2137,2138,2139,2140,2141,2142,2143,2144,2145,2146,2147,2148,2149,2150,2151,2152,2153,2154,2155,2156,2157,2158,2159,2160,2161,2162,2163,2164,2165,2166,2167,2168,2169,2170,2171,2172,2173,2174,2175,2176,2177,2178,2179,2180,2181,2182,2183,2184,2185,2186,2187,2188,2189,2190,2191,2192,2193,2194,2195,2196,2197,2198,2199,2200,2201,2202,2203,2204,2205,2206,2207,2208,2209,2210,2211,2212,2213,2214,2215,2216,2217,2218,2219,2220,2221,2222,2223,2224,2225,2226,2227,2228,2229,2230,2231,2232,2233,2234,2235,2236,2237,2238,2239,2240,2241,2242,2243,2244,2245,2246],{"_148":1024,"_436":2585},{"_148":449,"_436":2581},{"_148":449,"_436":2576},{"_148":445,"_436":2573},{"_148":1000,"_436":2570},{"_148":449,"_436":2566},{"_148":463,"_436":2561},{"_148":463,"_436":2557},{"_148":449,"_436":2554},{"_148":449,"_436":2552},{"_148":463,"_436":2548},{"_148":449,"_436":2546},{"_148":463,"_436":2542},{"_148":449,"_436":2539},{"_148":449,"_436":2537},{"_148":463,"_436":2533},{"_148":449,"_436":2531},{"_148":463,"_436":2527},{"_148":449,"_436":2524},{"_148":449,"_436":2522},{"_148":463,"_436":2518},{"_148":449,"_436":2516},{"_148":463,"_436":2512},{"_148":449,"_436":2509},{"_148":449,"_436":2507},{"_148":463,"_436":2503},{"_148":449,"_436":2501},{"_148":463,"_436":2497},{"_148":449,"_436":2494},{"_148":449,"_436":2492},{"_148":463,"_436":2488},{"_148":449,"_436":2486},{"_148":463,"_436":2482},{"_148":449,"_436":2479},{"_148":449,"_436":2477},{"_148":463,"_436":2473},{"_148":449,"_436":2471},{"_148":463,"_436":2467},{"_148":449,"_436":2464},{"_148":449,"_436":2462},{"_148":463,"_436":2458},{"_148":449,"_436":2456},{"_148":449,"_436":2454},{"_148":463,"_436":2450},{"_148":449,"_436":2448},{"_148":449,"_436":2446},{"_148":463,"_436":2442},{"_148":449,"_436":2440},{"_148":463,"_436":2436},{"_148":449,"_436":2433},{"_148":449,"_436":2431},{"_148":449,"_436":2429},{"_148":463,"_436":2425},{"_148":449,"_436":2422},{"_148":449,"_436":2420},{"_148":449,"_436":2418},{"_148":463,"_436":2414},{"_148":449,"_436":2411},{"_148":449,"_436":2409},{"_148":449,"_436":2407},{"_148":463,"_436":2403},{"_148":449,"_436":2400},{"_148":449,"_436":2398},{"_148":449,"_436":2396},{"_148":463,"_436":2392},{"_148":449,"_436":2389},{"_148":449,"_436":2387},{"_148":449,"_436":2385},{"_148":463,"_436":2381},{"_148":449,"_436":2378},{"_148":449,"_436":2376},{"_148":463,"_436":2372},{"_148":449,"_436":2370},{"_148":463,"_436":2366},{"_148":449,"_436":2363},{"_148":449,"_436":2361},{"_148":449,"_436":2359},{"_148":463,"_436":2355},{"_148":449,"_436":2352},{"_148":449,"_436":2350},{"_148":463,"_436":2346},{"_148":449,"_436":2344},{"_148":463,"_436":2340},{"_148":463,"_436":2336},{"_148":449,"_436":2333},{"_148":449,"_436":2331},{"_148":463,"_436":2327},{"_148":449,"_436":2325},{"_148":463,"_436":2321},{"_148":449,"_436":2318},{"_148":449,"_436":2316},{"_148":463,"_436":2312},{"_148":449,"_436":2310},{"_148":463,"_436":2306},{"_148":449,"_436":2303},{"_148":449,"_436":2301},{"_148":463,"_436":2297},{"_148":449,"_436":2295},{"_148":463,"_436":2291},{"_148":449,"_436":2288},{"_148":449,"_436":2286},{"_148":463,"_436":2282},{"_148":449,"_436":2280},{"_148":463,"_436":2276},{"_148":449,"_436":2273},{"_148":449,"_436":2271},{"_148":463,"_436":2267},{"_148":449,"_436":2265},{"_148":463,"_436":2261},{"_148":449,"_436":2258},{"_148":463,"_436":2256},{"_148":449,"_436":2252},{"_148":445,"_436":2250},{"_148":435,"_436":2247},{"_438":439,"_85":2248},{"_101":-5,"_41":441,"_442":2249,"_444":111},[],{"_444":2251,"_438":439},{"_90":448},{"_451":2253,"_438":439,"_453":441},{"_454":2254,"_456":-5,"_41":-5,"_457":458,"_94":91,"_90":459},[2255],{"_45":461,"_90":462},{"_451":2257,"_438":439,"_453":441},{"_41":466,"_457":458,"_45":461,"_90":467},{"_451":2259,"_438":439,"_453":441},{"_454":-5,"_470":471,"_41":-5,"_472":2260,"_90":474},[],{"_451":2262,"_438":439,"_453":441},{"_454":2263,"_41":478,"_472":2264,"_90":474},[],[],{"_451":2266,"_438":439,"_453":441},{"_482":483,"_484":485,"_90":486},{"_451":2268,"_438":439,"_453":441},{"_489":-5,"_490":491,"_492":2269,"_494":495,"_496":31,"_497":31,"_41":483,"_498":499,"_444":111,"_90":500},[2270],{"_490":502,"_90":503},{"_451":2272,"_438":439,"_453":441},{"_506":507,"_482":483,"_41":-5,"_166":508,"_90":509},{"_451":2274,"_438":439,"_453":441},{"_454":-5,"_470":512,"_41":-5,"_472":2275,"_90":474},[],{"_451":2277,"_438":439,"_453":441},{"_454":2278,"_41":517,"_472":2279,"_90":474},[],[],{"_451":2281,"_438":439,"_453":441},{"_482":521,"_484":522,"_90":486},{"_451":2283,"_438":439,"_453":441},{"_489":525,"_490":526,"_492":2284,"_494":495,"_496":528,"_497":31,"_41":521,"_498":529,"_444":111,"_90":500},[2285],{"_490":531,"_90":503},{"_451":2287,"_438":439,"_453":441},{"_506":534,"_482":521,"_41":-5,"_166":508,"_90":509},{"_451":2289,"_438":439,"_453":441},{"_454":-5,"_470":537,"_41":-5,"_472":2290,"_90":474},[],{"_451":2292,"_438":439,"_453":441},{"_454":2293,"_41":542,"_472":2294,"_90":474},[],[],{"_451":2296,"_438":439,"_453":441},{"_482":546,"_484":547,"_90":486},{"_451":2298,"_438":439,"_453":441},{"_489":550,"_490":551,"_492":2299,"_494":495,"_496":31,"_497":31,"_41":546,"_498":553,"_444":111,"_90":500},[2300],{"_490":555,"_155":556,"_557":558,"_90":559},{"_451":2302,"_438":439,"_453":441},{"_506":562,"_482":546,"_41":-5,"_166":508,"_90":509},{"_451":2304,"_438":439,"_453":441},{"_454":-5,"_470":565,"_41":-5,"_472":2305,"_90":474},[],{"_451":2307,"_438":439,"_453":441},{"_454":2308,"_41":570,"_472":2309,"_90":474},[],[],{"_451":2311,"_438":439,"_453":441},{"_482":574,"_484":575,"_90":486},{"_451":2313,"_438":439,"_453":441},{"_489":578,"_490":579,"_492":2314,"_494":495,"_496":581,"_497":31,"_41":574,"_498":582,"_444":111,"_90":500},[2315],{"_490":584,"_90":503},{"_451":2317,"_438":439,"_453":441},{"_506":587,"_482":574,"_41":-5,"_166":508,"_90":509},{"_451":2319,"_438":439,"_453":441},{"_454":-5,"_470":590,"_41":-5,"_472":2320,"_90":474},[],{"_451":2322,"_438":439,"_453":441},{"_454":2323,"_41":595,"_472":2324,"_90":474},[],[],{"_451":2326,"_438":439,"_453":441},{"_482":599,"_484":600,"_90":486},{"_451":2328,"_438":439,"_453":441},{"_489":603,"_490":604,"_492":2329,"_494":495,"_496":31,"_497":31,"_41":599,"_498":606,"_444":111,"_90":500},[2330],{"_490":608,"_155":609,"_557":610,"_90":559},{"_451":2332,"_438":439,"_453":441},{"_506":613,"_482":599,"_41":-5,"_166":508,"_90":509},{"_451":2334,"_438":439,"_453":441},{"_454":-5,"_470":616,"_41":-5,"_472":2335,"_90":474},[],{"_451":2337,"_438":439,"_453":441},{"_454":2338,"_41":621,"_472":2339,"_90":474},[],[],{"_451":2341,"_438":439,"_453":441},{"_489":625,"_490":626,"_492":2342,"_494":495,"_496":628,"_497":31,"_41":629,"_498":630,"_444":111,"_90":500},[2343],{"_490":632,"_90":503},{"_451":2345,"_438":439,"_453":441},{"_482":635,"_484":636,"_90":486},{"_451":2347,"_438":439,"_453":441},{"_489":639,"_490":640,"_492":2348,"_494":495,"_496":642,"_497":31,"_41":643,"_498":644,"_444":111,"_90":500},[2349],{"_490":646,"_90":503},{"_451":2351,"_438":439,"_453":441},{"_506":649,"_482":635,"_41":-5,"_166":650,"_90":509},{"_451":2353,"_438":439,"_453":441},{"_454":-5,"_470":653,"_41":-5,"_472":2354,"_90":474},[],{"_451":2356,"_438":439,"_453":441},{"_454":2357,"_41":658,"_472":2358,"_90":474},[],[],{"_451":2360,"_438":439,"_453":441},{"_482":643,"_484":662,"_90":486},{"_451":2362,"_438":439,"_453":441},{"_506":665,"_482":643,"_41":-5,"_166":508,"_90":509},{"_451":2364,"_438":439,"_453":441},{"_454":-5,"_470":668,"_41":-5,"_472":2365,"_90":474},[],{"_451":2367,"_438":439,"_453":441},{"_454":2368,"_41":673,"_472":2369,"_90":474},[],[],{"_451":2371,"_438":439,"_453":441},{"_482":677,"_484":678,"_90":486},{"_451":2373,"_438":439,"_453":441},{"_489":-5,"_490":681,"_492":2374,"_494":495,"_496":683,"_497":684,"_41":685,"_498":686,"_444":687,"_90":500},[2375],{"_490":689,"_90":503},{"_451":2377,"_438":439,"_453":441},{"_506":692,"_482":677,"_41":-5,"_166":650,"_90":509},{"_451":2379,"_438":439,"_453":441},{"_454":-5,"_470":695,"_41":-5,"_472":2380,"_90":474},[],{"_451":2382,"_438":439,"_453":441},{"_454":2383,"_41":700,"_472":2384,"_90":474},[],[],{"_451":2386,"_438":439,"_453":441},{"_482":685,"_484":704,"_90":486},{"_451":2388,"_438":439,"_453":441},{"_506":707,"_482":685,"_41":-5,"_166":508,"_90":509},{"_451":2390,"_438":439,"_453":441},{"_454":-5,"_470":710,"_41":-5,"_472":2391,"_90":474},[],{"_451":2393,"_438":439,"_453":441},{"_454":2394,"_41":715,"_472":2395,"_90":474},[],[],{"_451":2397,"_438":439,"_453":441},{"_482":719,"_484":720,"_90":486},{"_451":2399,"_438":439,"_453":441},{"_506":723,"_482":719,"_41":-5,"_166":650,"_90":509},{"_451":2401,"_438":439,"_453":441},{"_454":-5,"_470":726,"_41":-5,"_472":2402,"_90":474},[],{"_451":2404,"_438":439,"_453":441},{"_454":2405,"_41":731,"_472":2406,"_90":474},[],[],{"_451":2408,"_438":439,"_453":441},{"_482":735,"_484":736,"_90":486},{"_451":2410,"_438":439,"_453":441},{"_506":739,"_482":735,"_41":-5,"_166":650,"_90":509},{"_451":2412,"_438":439,"_453":441},{"_454":-5,"_470":742,"_41":-5,"_472":2413,"_90":474},[],{"_451":2415,"_438":439,"_453":441},{"_454":2416,"_41":747,"_472":2417,"_90":474},[],[],{"_451":2419,"_438":439,"_453":441},{"_482":751,"_484":752,"_90":486},{"_451":2421,"_438":439,"_453":441},{"_506":755,"_482":751,"_41":-5,"_166":650,"_90":509},{"_451":2423,"_438":439,"_453":441},{"_454":-5,"_470":758,"_41":-5,"_472":2424,"_90":474},[],{"_451":2426,"_438":439,"_453":441},{"_454":2427,"_41":763,"_472":2428,"_90":474},[],[],{"_451":2430,"_438":439,"_453":441},{"_482":629,"_484":767,"_90":486},{"_451":2432,"_438":439,"_453":441},{"_506":770,"_482":629,"_41":-5,"_166":508,"_90":509},{"_451":2434,"_438":439,"_453":441},{"_454":-5,"_470":773,"_41":-5,"_472":2435,"_90":474},[],{"_451":2437,"_438":439,"_453":441},{"_454":2438,"_41":778,"_472":2439,"_90":474},[],[],{"_451":2441,"_438":439,"_453":441},{"_482":782,"_484":783,"_90":486},{"_451":2443,"_438":439,"_453":441},{"_489":786,"_490":787,"_492":2444,"_494":495,"_496":31,"_497":31,"_41":782,"_498":789,"_444":111,"_90":500},[2445],{"_490":791,"_166":792,"_155":793,"_90":794},{"_451":2447,"_438":439,"_453":441},{"_506":797,"_482":782,"_41":-5,"_166":508,"_90":509},{"_451":2449,"_438":439,"_453":441},{"_482":800,"_484":801,"_90":486},{"_451":2451,"_438":439,"_453":441},{"_489":804,"_490":805,"_492":2452,"_494":495,"_496":31,"_497":31,"_41":800,"_498":807,"_444":111,"_90":500},[2453],{"_490":809,"_166":792,"_155":793,"_90":794},{"_451":2455,"_438":439,"_453":441},{"_506":812,"_482":800,"_41":-5,"_166":508,"_90":509},{"_451":2457,"_438":439,"_453":441},{"_482":815,"_484":816,"_90":486},{"_451":2459,"_438":439,"_453":441},{"_489":819,"_490":820,"_492":2460,"_494":495,"_496":31,"_497":31,"_41":815,"_498":822,"_444":111,"_90":500},[2461],{"_490":824,"_90":503},{"_451":2463,"_438":439,"_453":441},{"_506":827,"_482":815,"_41":-5,"_166":508,"_90":509},{"_451":2465,"_438":439,"_453":441},{"_454":-5,"_470":830,"_41":-5,"_472":2466,"_90":474},[],{"_451":2468,"_438":439,"_453":441},{"_454":2469,"_41":835,"_472":2470,"_90":474},[],[],{"_451":2472,"_438":439,"_453":441},{"_482":839,"_484":840,"_90":486},{"_451":2474,"_438":439,"_453":441},{"_489":843,"_490":844,"_492":2475,"_494":495,"_496":31,"_497":31,"_41":839,"_498":846,"_444":111,"_90":500},[2476],{"_490":848,"_166":849,"_155":849,"_90":794},{"_451":2478,"_438":439,"_453":441},{"_506":852,"_482":839,"_41":-5,"_166":508,"_90":509},{"_451":2480,"_438":439,"_453":441},{"_454":-5,"_470":855,"_41":-5,"_472":2481,"_90":474},[],{"_451":2483,"_438":439,"_453":441},{"_454":2484,"_41":860,"_472":2485,"_90":474},[],[],{"_451":2487,"_438":439,"_453":441},{"_482":864,"_484":865,"_90":486},{"_451":2489,"_438":439,"_453":441},{"_489":868,"_490":869,"_492":2490,"_494":495,"_496":31,"_497":31,"_41":864,"_498":871,"_444":111,"_90":500},[2491],{"_490":873,"_166":874,"_155":875,"_90":794},{"_451":2493,"_438":439,"_453":441},{"_506":878,"_482":864,"_41":-5,"_166":508,"_90":509},{"_451":2495,"_438":439,"_453":441},{"_454":-5,"_470":881,"_41":-5,"_472":2496,"_90":474},[],{"_451":2498,"_438":439,"_453":441},{"_454":2499,"_41":886,"_472":2500,"_90":474},[],[],{"_451":2502,"_438":439,"_453":441},{"_482":890,"_484":891,"_90":486},{"_451":2504,"_438":439,"_453":441},{"_489":894,"_490":895,"_492":2505,"_494":495,"_496":31,"_497":31,"_41":890,"_498":897,"_444":111,"_90":500},[2506],{"_490":899,"_155":874,"_557":900,"_90":559},{"_451":2508,"_438":439,"_453":441},{"_506":903,"_482":890,"_41":-5,"_166":508,"_90":509},{"_451":2510,"_438":439,"_453":441},{"_454":-5,"_470":906,"_41":-5,"_472":2511,"_90":474},[],{"_451":2513,"_438":439,"_453":441},{"_454":2514,"_41":911,"_472":2515,"_90":474},[],[],{"_451":2517,"_438":439,"_453":441},{"_482":915,"_484":916,"_90":486},{"_451":2519,"_438":439,"_453":441},{"_489":919,"_490":920,"_492":2520,"_494":495,"_496":31,"_497":31,"_41":915,"_498":922,"_444":111,"_90":500},[2521],{"_490":924,"_166":874,"_155":875,"_90":794},{"_451":2523,"_438":439,"_453":441},{"_506":927,"_482":915,"_41":-5,"_166":508,"_90":509},{"_451":2525,"_438":439,"_453":441},{"_454":-5,"_470":930,"_41":-5,"_472":2526,"_90":474},[],{"_451":2528,"_438":439,"_453":441},{"_454":2529,"_41":935,"_472":2530,"_90":474},[],[],{"_451":2532,"_438":439,"_453":441},{"_482":939,"_484":940,"_90":486},{"_451":2534,"_438":439,"_453":441},{"_489":943,"_490":944,"_492":2535,"_494":495,"_496":31,"_497":31,"_41":939,"_498":946,"_444":111,"_90":500},[2536],{"_490":948,"_90":503},{"_451":2538,"_438":439,"_453":441},{"_506":951,"_482":939,"_41":-5,"_166":508,"_90":509},{"_451":2540,"_438":439,"_453":441},{"_454":-5,"_470":954,"_41":-5,"_472":2541,"_90":474},[],{"_451":2543,"_438":439,"_453":441},{"_454":2544,"_41":959,"_472":2545,"_90":474},[],[],{"_451":2547,"_438":439,"_453":441},{"_482":963,"_484":964,"_90":486},{"_451":2549,"_438":439,"_453":441},{"_489":967,"_490":968,"_492":2550,"_494":495,"_496":31,"_497":31,"_41":963,"_498":970,"_444":111,"_90":500},[2551],{"_490":972,"_155":-5,"_90":973},{"_451":2553,"_438":439,"_453":441},{"_506":976,"_482":963,"_41":-5,"_166":508,"_90":509},{"_451":2555,"_438":439,"_453":441},{"_454":-5,"_470":979,"_41":-5,"_472":2556,"_90":474},[],{"_451":2558,"_438":439,"_453":441},{"_454":2559,"_41":984,"_472":2560,"_90":474},[],[],{"_451":2562,"_438":439,"_453":441},{"_454":2563,"_41":989,"_90":990},[2564],{"_45":992,"_993":2565,"_90":45},[],{"_451":2567,"_438":439,"_453":441},{"_454":2568,"_456":-5,"_41":-5,"_457":-5,"_94":308,"_90":459},[2569],{"_45":992,"_90":999},{"_438":439,"_85":2571},{"_101":-5,"_41":441,"_442":2572,"_444":1004},[],{"_444":2574,"_438":439},{"_1007":2575,"_90":1009},[],{"_451":2577,"_438":439,"_453":1012},{"_454":2578,"_456":-5,"_41":-5,"_457":-5,"_94":308,"_90":459},[2579,2580],{"_45":1017,"_90":999},{"_45":1016,"_90":999},{"_451":2582,"_438":439,"_453":1012},{"_454":2583,"_456":-5,"_41":-5,"_457":-5,"_94":1021,"_90":459},[2584],{"_45":1023,"_90":999},{"_1026":2586},{"_1028":-5,"_1029":-5,"_1030":1031,"_1032":1033,"_494":495,"_1034":15,"_1035":-5,"_41":439,"_1036":1037,"_166":-5,"_155":1038,"_1039":184,"_1040":1041,"_444":2587,"_75":2588,"_1044":1033},{"_90":448},[],[],[2591],{"_41":1049,"_1050":2592,"_1052":1053,"_1054":1053,"_454":2593,"_444":1056,"_456":-5,"_1057":31,"_1058":2594,"_1060":283,"_1061":-5},{"_94":308,"_166":-5,"_1058":2598},{"_1066":45,"_1067":2597},{"_1062":2595},{"_1064":2596},[],[1069],{},{"_90":459,"_94":91,"_454":2614},{"_90":1078,"_1079":2601},[2602,2603,2604],{"_155":875,"_1084":-5,"_1085":2611,"_1087":-5},{"_155":849,"_1084":-5,"_1085":2608,"_1087":-5},{"_155":793,"_1084":-5,"_1085":2605,"_1087":-5},[2606],{"_1089":1090,"_1091":1092,"_454":2607,"_1094":57},[1095,184,1096,1097,1098,1099,1100,1101,1102,1103,1104,184,1105,1106,1107,1108,1109,1110,1111,1112,1113,1114,1115,1116,1117,184,1118,1119,1120,1121,1122,1123,1117,184,1124,1125,1126,1127,1128,1129,1130,1131,1132,184,1133,1134,1135,1136,1137,1138,1139,1140,1141,1142,1137,1143,1144,1145,1137,1146,1147,1148,1142,1137,1149,1150,1151,1142,1137,1152,1132,184,1153,1154,1155,1156,1157,1158,1159,1160,1161,1132,184,1118,1162,1163,1164,1165,1166,1117,184,1167,1168,1169,1170,1171,184,1172,1173,1174,1175,1176,1132,184,1177,1178,1179,1180,1181,1182,1183,1184,1185,1186,1187,1188,1189,1190,1191,1192,1152,1132,184,1193,1158,1159,1160,1161,1194,1195,1196,1197,1198,1199,1200,1132,184,1201,1202,1203,1204,1205,1206,1207,1208,1209,1210,1211,1212,1213,1152,1132,184,1214,1215,1216,1217,1218,1219,184,1220,184,1221,184,1222,1223,184,1224,1225,184,1226,1132,184,1227,1228,1229,1230,1132,184,1231,1232,1233,1234,1235,1137,1236,1152,184,1237,1233,1238,1234,1235,1137,1236,1152,184,1239,1233,1238,1240,1234,1235,1137,1236,1152,184,1241,1242,1243,1244,1245,1132,184,1246,1220,1247,1134,1248,1249,1250,1251,1142,1252,1253,1250,1251,1142,1252,1254,1255,1152,1132,184,1256,1220,184,1257,1258,1259,1260,1261,1262,184,1263,1264,1265,1266,1267,1251,1142,1268,1269,1270,1251,1142,1137,1271,1272,1273,1274,1142,1137,1275,1276,1132,184,1277,1278,1279,1280,1220,184,1281,1282,1152,1283,184,1284,1263,1265,1285,1274,1142,1137,1275,1286,184,1287,1288,1289,1290,1263,1291,1254,1137,1265,1292,1293,1142,1294,1295,1251,1142,1296,1297,1298,1299,1137,1275,1300,1132,184,1301,1302,1303,1304,1152,1305,1132,184,1306,1307,1303,1308,1309,1310,1311,1312,1152,1313,1132,184,1314,1220,1315,1316,1317,1318,1319,1303,1320,1321,1322,1323,1324,1325,1326,1327,1328,1329,1330,1293,1142,1331,1332,1299,1137,1152,184,1333,1334,1335,1336,1152,184,1337,184,1303,1338,1339,1340,1341,1342,1343,184,1344,1345,1346,1347,184,1348,1349,1350,1351,1352,1353,1354,1312,1355,184,1356,1357,1358,1359,1360,1361,1362,1363,1364,1365,1137,1366,1367,1368,1369,184,1370,1371,1372,1373,1374,184,1375,1376,1377,1378,1325,1379,1380,1381,184,1382,1383,1384,1385,184,1386,1387,1388,1389,1390,1391,1392,1393,1394,1395,1396,1397,1398,1152,184,1399,1132],[2609],{"_1089":1090,"_1091":1402,"_454":2610,"_1094":57},[1404,184,1096,1405,1406,1407,1408,1409,184,1107,1111,1112,1116,1117,184,1410,1411,1412,1413,184,1414,1415,1132,184,1416,184,1417,184,1118,1418,1419,1117,184,1420,1421,1422,1423,1117,184,1424,1425,1426,1427,1428,1429,1152,1132,184,1430,1431,1282,1152,1432,1433,1434,1137,1435,1152,1436,1437,1438,1137,1439,1152,1440,1441,1442,1137,1443,1152,1132,184,1444,1445,1282,1152,1446,1132,184,1447,184,1448,1449,1450,1152,1451,1132,184,1452,1453,1454,1152,184,1455,1456,1457,1458,1459,1460,1461,1462,1463,1152,184,1464,1465,1461,1466,1467,1468,1137,1469,1152,184,1470,1233,1461,1152,1471,1472,1152,1473,1132,184,1474,1475,1476,1477,1478,1479,1132,184,1480,1481,1233,1482,1483,1137,1484,1152,1485,1233,1486,1152,1487,1132,184,1488,1489,1490,1491,1492,1493,1494,1495,1496,1497,1498,1219,1233,1499,1152,184,1500,1501,1152,1502,1132,184,1503,1504,1505,1506,1507,1508,1137,1152,1509,1132,184,1510,1511,1454,1152,1512,1132,184,1513,1514,1233,1454,1152,1515,1516,1454,1152,1517,1132,184,1518,1519,1520,1521,1522,1523,1524,1525,1526,1527,1528,1529,1530,1531,1532,1152,184,1533,1534,1535,1536,1537,1538,1539,1131,1233,1540,1152,184,1541,1542,1543,1544,1545,1546,1547,1132],[2612],{"_1089":1090,"_1091":1550,"_454":2613,"_1094":57},[1404,184,1096,1097,1552,1553,1554,1406,1099,1555,1407,1408,1409,1104,184,1556,1557,1105,1106,1107,1108,1109,1558,1110,1111,1112,1559,1116,1117,184,1420,1560,1561,1562,1563,1564,1565,1566,1567,1568,1569,1570,1571,1572,1573,1574,1575,1576,1117,184,1118,1577,1578,1579,1580,1581,1582,1583,1584,1117,184,1172,1585,1586,1587,1132,184,1588,1589,1590,1591,1592,1593,1594,1595,1596,1597,1598,1599,1600,1601,1602,1603,1604,1605,1606,1607,1608,1609,1610,1132,184,1611,1612,184,1613,184,1614,1615,1616,1617,1618,1619,1620,1621,1622,1623,1624,1625,1626,1627,1628,1629,1630,1631,1632,1633,1137,1634,1635,1636,1137,1637,1638,1639,1640,1641,1642,1643,1137,1644,1645,1646,1647,1648,1649,1650,1651,1652,1653,1654,1655,1656,1657,1658,1645,1659,1660,1661,1662,1650,1651,1663,1653,1664,1665,1666,1667,1658,1645,1668,1669,1670,1671,1650,1651,1672,1653,1673,1674,1666,1667,1658,1137,184,1675,1676,1677,1678,1679,1265,1680,1681,1682,1683,1684,1685,1686,1687,1137,1688,1689,1690,184,1265,1691,1692,1693,1694,1695,1696,1697,1698,1699,1700,1701,1702,1703,1142,1137,184,1704,1705,1706,1707,1708,1709,1710,1711,1152,184,1712,1713,1714,1152,1132,184,1715,1716,1717,1718,1152,1719,1132,184,1720,1721,1722,1723,1724,1725,1726,1137,1727,1728,1726,1137,1729,1152,1730,1233,1540,1152,1731,1732,1233,1540,1152,1733,1132,184,1734,1735,1736,1737,1738,1739,1740,1152,1741,1742,1743,1744,1745,1746,1132,184,1747,1748,1749,1750,1751,1752,1753,1754,1142,1137,1152,1755,1756,184,1757,1233,1540,1152,1737,1758,1759,1760,1761,1132,184,1762,1763,1764,1525,1765,1766,1767,1768,1769,1770,1771,1772,1773,1774,1775,1152,1776,1777,1152,1778,1779,1780,1751,1781,1782,1293,1142,1783,1784,1785,1293,1142,1786,1137,1152,1787,184,1788,1233,1540,1152,1789,1233,1790,1532,1152,1737,1791,1792,1793,1794,1795,1796,1797,1798,1799,1761,1132,184,1800,1801,1802,1803,1804,1805,1806,1142,1137,1152,1807,1808,1233,1540,1152,1737,1809,1810,1811,1761,1132,184,1812,1813,1814,1815,1816,1817,1818,1819,1820,1821,1822,1131,184,1823,1824,1825,1728,1726,1137,1826,1827,1828,1540,1152,184,1829,1830,1831,1832,1833,1834,1835,1836,1507,1726,1137,1152,184,1533,1837,1838,1839,1840,1841,1842,1131,1233,1540,1152,1843,1844,1845,1846,1137,1131,1847,1132,184,1848,1849,1850,1851,184,1852,1233,1461,1152,1853,1854,1855,1856,184,1857,1233,1461,1152,184,1858,1859,1860,1736,1861,1862,1863,1864,1865,1866,1867,1868,1869,1870,1871,1454,1152,1872,1873,1874,1875,1876,1219,1877,1878,1879,1880,1881,1882,1883,1884,1885,1886,1887,1888,1219,1889,184,1890,184,1891,1233,1454,1152,1843,1238,1131,184,1892,184,1893,1233,1461,1152,1894,1895,1233,1461,1152,1896,1897,1233,1461,1152,1898,1899,1233,1461,1152,184,1900,1901,1902,1903,1904,1905,1906,1907,1908,1909,1910,1911,1912,1913,1914,1915,184,1916,1517,1132,184,1917,1918,1233,1282,1152,1919,1920,1152,1921,1233,1282,1152,1922,1923,1152,1924,1132,184,1925,1926,1927,1928,1152,1929,1930,1152,1931,1932,1152,1933,1233,1934,1152,1935,1936,1132,184,1937,1938,1939,1928,1152,1940,1941,1152,1942,1943,1152,1944,1233,1934,1152,1945,1946,1132,184,1947,1948,1949,1950,1137,1469,1152,1132,184,1951,1948,1952,1953,1954,1955,1956,1137,1957,1958,1959,1142,1137,1469,1152,1132,184,1960,1948,1961,1962,1963,1964,1137,1454,1152,1132,184,1965,1948,1952,1966,1967,1469,1152,1132,184,1968,1948,1969,1970,1971,1964,1137,1454,1152,1132,184,1972,1948,1952,1973,1974,1469,1152,1132,184,1975,1948,1976,1977,1971,1964,1137,1454,1152,1132,184,1978,1948,1952,1979,1980,1469,1152,1132,184,1981,1948,1982,1983,1971,1964,1137,1454,1152,1132,184,1984,1985,1132,184,1986,1987,1988,1132,184,1989,1990,1991,1992,1152,1993,1233,1540,1152,1994,1995,1540,1152,1996,1997,1998,1999,2000,2001,1137,2002,1152,2003,1132],[2615,2616,2617,2618,2619,2620,2621,2622,2623,2624,2625,2626,2627],{"_1066":45,"_45":2039},{"_1066":2019,"_155":875,"_1089":2037,"_1091":2038},{"_1066":2019,"_155":875,"_1089":2035,"_1091":2036},{"_1066":2019,"_155":875,"_1089":2033,"_1091":2034},{"_1066":45,"_45":2032},{"_1066":2019,"_155":875,"_1089":2030,"_1091":2031},{"_1066":45,"_45":2029},{"_1066":2019,"_155":849,"_1089":2027,"_1091":2028},{"_1066":2019,"_155":849,"_1089":2025,"_1091":2026},{"_1066":45,"_45":2024},{"_1066":2019,"_155":793,"_1089":2022,"_1091":2023},{"_1066":2019,"_155":793,"_1089":2020,"_1091":2021},{"_1066":45,"_45":2018},[2630,2631,2632,2633,2634,2635,2636,2637,2638,2639,2640],{"_2049":2050,"_247":181,"_2051":288,"_258":-5,"_2052":241,"_2053":-5,"_2054":2055,"_2056":2057,"_2058":-5,"_2059":-5,"_2060":2061,"_2062":15,"_2063":57,"_2064":52,"_2065":15},{"_90":459,"_94":308,"_454":2641},{"_295":296,"_297":2091,"_2092":302,"_2093":2094,"_304":-5,"_90":2095},{"_90":2077,"_297":2089,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2090,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2089,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2088,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2087,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2086,"_155":875,"_2079":2080,"_2081":2082},{"_90":2077,"_297":2084,"_155":849,"_2079":2080,"_2081":2085},{"_90":2077,"_297":2083,"_155":-5,"_2079":-5,"_2081":-5},{"_90":2077,"_297":2078,"_155":875,"_2079":2080,"_2081":2082},[2642],{"_1066":45,"_45":2098},"task_e_69e9245920d483249168fff3c7053f51",1776886873.128306,"Github Mention: chore(raft): drop hashicorp/raft backend, kv/ on raftengine natively","has_generated_title","has_unread_turn","denormalized_metadata",{"_2674":31,"_2675":2676,"_2677":-5,"_2678":-5,"_2669":2679,"_2680":-5,"_2681":-5,"_2682":-5,"_2683":-5},"task_status_display",{"_2662":2663,"_2664":181,"_128":125,"_2665":-5,"_2666":2667},"creator_workspace","external_pull_requests",[2655],{"_41":2656,"_2657":81,"_2658":2659,"_2660":2094},"github-724122345-590","assistant_turn_id","pull_request",{"_287":288,"_278":289,"_290":291,"_292":57,"_293":15,"_294":15,"_295":296,"_297":298,"_299":251,"_300":125,"_301":302,"_303":127,"_304":305,"_306":-5,"_307":-5,"_308":2661,"_310":311,"_312":313,"_314":315,"_316":317},"codex_updated_sha",{"_272":273,"_166":273,"_318":-5,"_276":277,"_41":274},"latest_turn_status_display",{"_2668":81,"_110":111,"_2669":-5,"_92":2670,"_2671":-5,"_2672":-5,"_2673":2667,"_112":-5},"environment_label","fix_task_id","initial_intent","pr","turn_id","diff_stats",[],"image_asset_pointer_citations","issue_counts","intent","num_follow_ups","repo_name_map",{},"last_user_turn_created_at","last_turn_status",{"_2684":-5,"_2685":-5,"_2686":-5},"last_pushed_turn_id","start_branch_name","pushed_branch_name","cached_pull_request_data","files_modified","lines_added","lines_removed","dd",{"_2698":2699,"_2700":2701},"disablePrefetch","shouldPrefetchAccount","shouldPrefetchUser","shouldPrefetchSystemHints","promoteCss","disableSSR","stripModulepreloadImports","statsigGateEvaluationsPromise",["P",2697],"traceId","10374739507766755872","traceTime",1776944931485]