ℹ️ About Codex in GitHub

\n
\n\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\n- Open a pull request for review\n- Mark a draft as ready\n- Comment \"@codex review\".\n\nIf Codex has suggestions, it will comment; otherwise it will react with 👍.\n\n\n\n\nCodex can also answer questions or update the PR. Try commenting \"@codex address that feedback\".\n \n

","path","side","line","Done in commit `4294387`. Removed `prev_energy` from `compute_round()` signature and its docstring parameter entry, dropped the `prev_energy` variable and kwarg from `compute_transcript()`, and updated the module-level Public API hint to show the remaining optional parameters with brackets.","backend/src/edcmbone/metrics/compute.py","RIGHT",309,"### Summary\n* Restored `energy_step` backward compatibility so it now accepts both the current signature and the legacy call pattern that includes `prev_energy`, preventing the “multiple values for `dissonance`” failure described in review feedback. The legacy `prev_energy` value is explicitly accepted and ignored. \n* Added a defensive argument validation path in `energy_step` that raises a clear `TypeError` if required inputs are missing. \n* Updated the module-level metric docs to reflect `k`/stored tension as clamped to `[0,1]` and documented both supported `energy_step` signatures in the public API section. \n* Committed the change on the current branch with commit: `a085ed6`. \n\n**Testing**\n* ⚠️ `pytest -q Tests/test_backend.py -k energy_step` (no matching test selected; pytest exited with code 5 and reported all tests deselected).\n* ⚠️ `pytest -q Tests/test_backend.py` (environment/import-path limitation: `ModuleNotFoundError` for `edcmbone` modules).\n* ⚠️ `python - <<'PY' ...` (direct runtime check blocked by the same package import issue: `ImportError` for `edcmbone.canon`).\n* ✅ `git add backend/src/edcmbone/metrics/compute.py && git commit -m \"fix(metrics): restore legacy energy_step call compatibility\"`\n\nAlso completed per instruction:\n* ✅ Created a follow-up PR message via `make_pr` with title/body summarizing this fix on top of the original PR.\n\n [View task →](https://chatgpt.com/s/cd_6a03d58f91a081919218e3c2a71d7a55)",127,"@copilot apply changes based on [this feedback](https://github.com/The-Interdependency/edcmbone/pull/43#discussion_r3230874770)","@codex repair based on this comment","## Pull request overview\n\nThis PR performs a small “cleanliness” pass across the metrics layer and corrects documentation around κ (kappa) and the metric matrix/projection definitions, addressing issues #38 and #39.\n\n**Changes:**\n- Simplifies the RC-circuit helper by removing an unused `prev_energy` argument from `energy_step()` and updates the call site accordingly.\n- Removes dead/unused code in projection/risk helpers and hardens alert firing by supporting `\"below\"` thresholds and raising on unknown directions.\n- Updates `matrix.py` documentation to correctly describe κ ∈ [0, 1] and clarifies that `A_MATRIX` is currently documentation-only (not used by `compute.py`).\n\n### Reviewed changes\n\nCopilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.\n\n| File | Description |\n| ---- | ----------- |\n| backend/src/edcmbone/metrics/compute.py | Removes unused `energy_step` parameter, cleans imports, adjusts defaults, and fixes `_compute_D` docstring. |\n| backend/src/edcmbone/metrics/projection.py | Removes dead variable in `gini_tbf` and adds `\"below\"` + validation handling in `fire_alerts`. |\n| backend/src/edcmbone/metrics/risk.py | Wraps `broken_return` output (and formula doc) in `clamp()` for consistency. |\n| backend/src/edcmbone/metrics/matrix.py | Corrects κ range documentation and adds notes clarifying the current `A_MATRIX` vs implementation divergence. |\n\n\n

Comments suppressed due to low confidence (1)

\n\n**backend/src/edcmbone/metrics/compute.py:131**\n* The module docstring still states stored tension `k` is \"≥ 0\" (unbounded), but `energy_step()` clamps `kappa` via `clamp(...)` which restricts it to [0, 1] (and `matrix.py` now documents κ ∈ [0, 1]). Please update the module docstring’s k/kappa range to match the implementation.\n```\ndef energy_step(prev_kappa, dissonance, alpha=0.85, delta_max=0.3):\n \"\"\"Compute one step of the RC-circuit energy model.\n\n s_{t+1} = alpha * s_t + E_t - delta_t\n delta_t = min(delta_max, g(y_t, y_{t-1}))\n```\n

\n\n\n\n---\n\n💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.","`compute_round()` still accepts `prev_energy` and its docstring documents it, but the parameter is no longer used anywhere in `compute_round()` (and `energy_step()` no longer takes it). This leaves a dead kwarg threaded through `compute_transcript()` and can confuse callers; consider removing `prev_energy` from the `compute_round` signature + docstring and dropping the `prev_energy` plumbing in `compute_transcript()`.","\n### 💡 Codex Review\n\nHere are some automated review suggestions for this pull request.\n\n**Reviewed commit:** `7c5e2da8aa`\n \n\n

ℹ️ About Codex in GitHub

","**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Preserve backward-compatible `energy_step` call semantics**\n\nChanging `energy_step` from `(prev_energy, prev_kappa, dissonance, ...)` to `(prev_kappa, dissonance, ...)` introduces an immediate runtime break for existing callers that pass two positional args plus `dissonance=` by keyword (the in-repo test at `Tests/test_backend.py:374` now maps `0.0` to `dissonance` positionally and also supplies `dissonance=0.9`, causing `TypeError: got multiple values for argument 'dissonance'`). This API change needs either compatibility handling or all call sites/tests updated in the same commit.\n\nUseful? React with 👍 / 👎.","Comments in the same thread:\n\n**_{_{![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)}} Keep `compute_round` compatible with `prev_energy` callers**\n\nRemoving `prev_energy` from `compute_round` is a backward-incompatible API change for existing integrations that still pass `prev_energy=` (the parameter existed in the prior signature and this function is exported via `edcmbone.metrics`). In this commit those calls now fail immediately with `TypeError: unexpected keyword argument 'prev_energy'`, even though the value was previously ignored, so preserving it as an optional no-op argument would avoid breaking downstream code.\n\nUseful? React with 👍 / 👎.",263,"base_ref","head_ref","pull_request_info",[408],{"_344":57,"_57":409},"@codex[agent] none downstream yet (path=backend/src/edcmbone/metrics/compute.py line=263 side=RIGHT)",[440,441,442],[],{"_306":439},{"_303":438},{"_303":437},{"_266":267,"_257":268,"_269":270,"_271":70,"_272":18,"_273":18,"_274":275,"_276":277,"_278":228,"_279":138,"_280":281,"_282":140,"_283":-5,"_284":-5,"_285":286,"_287":-5,"_288":-5,"_289":436,"_291":292,"_293":294,"_295":296,"_297":298},{"_53":134,"_172":-5,"_173":174,"_175":176,"_177":18,"_178":179,"_180":181,"_182":425,"_184":-5,"_185":-5,"_186":18,"_187":426,"_189":179,"_190":179,"_191":427,"_193":428,"_195":429,"_197":-5,"_198":199,"_200":201,"_202":203,"_204":430,"_66":-5,"_130":206,"_207":431,"_209":432,"_211":212,"_213":18,"_214":18},{"_144":418},[419,420,421],{"_156":424,"_158":169},{"_156":423,"_158":165},{"_156":422,"_158":159},{"_160":161,"_104":162,"_130":163},{"_160":166,"_104":162,"_130":167},{"_160":170,"_104":162,"_130":171},{"_259":260,"_261":-5,"_262":-5,"_263":-5,"_264":-5,"_265":-5},[218],{"_218":433},{},{},[],{"_217":70},{"_215":70,"_216":179},{"_53":220,"_160":176,"_221":434,"_223":224,"_225":226,"_227":228,"_229":230,"_231":232,"_233":234,"_235":75,"_236":18,"_237":-5,"_238":-5,"_239":-5,"_240":-5,"_241":-5,"_242":-5,"_243":244,"_245":-5,"_66":435},{"_251":252,"_53":253,"_104":254,"_255":256,"_257":258},{"_247":18,"_248":18,"_249":18,"_250":18},{"_251":299,"_160":299,"_300":-5,"_255":301,"_53":302},[],[],[],{"_104":340,"_108":105,"_341":447},{"_104":337,"_338":446},{"_104":311,"_312":313,"_314":315,"_316":443,"_318":-5},{"_104":316,"_319":320,"_139":140,"_321":-5,"_288":322,"_323":444,"_325":326,"_327":328,"_329":326,"_330":331,"_332":445},{"_334":335,"_336":-5},[],[],[448],{"_344":57,"_57":345},[479,480,481],[],{"_306":478},{"_303":477},{"_303":476},{"_266":267,"_257":268,"_269":270,"_271":70,"_272":18,"_273":18,"_274":275,"_276":277,"_278":228,"_279":138,"_280":281,"_282":140,"_283":-5,"_284":-5,"_285":286,"_287":-5,"_288":-5,"_289":475,"_291":292,"_293":294,"_295":296,"_297":298},{"_53":134,"_172":-5,"_173":174,"_175":176,"_177":18,"_178":179,"_180":181,"_182":464,"_184":-5,"_185":-5,"_186":18,"_187":465,"_189":179,"_190":179,"_191":466,"_193":467,"_195":468,"_197":-5,"_198":199,"_200":201,"_202":203,"_204":469,"_66":-5,"_130":206,"_207":470,"_209":471,"_211":212,"_213":18,"_214":18},{"_144":457},[458,459,460],{"_156":463,"_158":169},{"_156":462,"_158":165},{"_156":461,"_158":159},{"_160":161,"_104":162,"_130":163},{"_160":166,"_104":162,"_130":167},{"_160":170,"_104":162,"_130":171},{"_259":260,"_261":-5,"_262":-5,"_263":-5,"_264":-5,"_265":-5},[218],{"_218":472},{},{},[],{"_217":70},{"_215":70,"_216":179},{"_53":220,"_160":176,"_221":473,"_223":224,"_225":226,"_227":228,"_229":230,"_231":232,"_233":234,"_235":75,"_236":18,"_237":-5,"_238":-5,"_239":-5,"_240":-5,"_241":-5,"_242":-5,"_243":244,"_245":-5,"_66":474},{"_251":252,"_53":253,"_104":254,"_255":256,"_257":258},{"_247":18,"_248":18,"_249":18,"_250":18},{"_251":299,"_160":299,"_300":-5,"_255":301,"_53":302},[],[],[],{"_104":340,"_108":105,"_341":486},{"_104":337,"_338":485},{"_104":311,"_312":313,"_314":315,"_316":482,"_318":-5},{"_104":316,"_319":320,"_139":140,"_321":-5,"_288":322,"_323":483,"_325":326,"_327":328,"_329":326,"_330":331,"_332":484},{"_334":335,"_336":-5},[],[],[487],{"_344":57,"_57":345},[490,491,492,493,494,495,496,497,498,499,500,501],{"_355":356,"_223":224,"_357":267,"_235":-5,"_319":218,"_358":18,"_359":-5,"_360":-5,"_361":362,"_363":311,"_364":-5,"_365":-5,"_366":367,"_368":18,"_369":70,"_370":65,"_371":18,"_372":-5},{"_104":340,"_108":289,"_341":502},{"_274":275,"_276":277,"_404":281,"_405":140,"_285":-5,"_104":406},{"_104":385,"_276":402,"_387":391,"_388":392,"_389":403},{"_104":385,"_276":401,"_387":391,"_388":392,"_389":395},{"_104":385,"_276":400,"_387":-5,"_388":-5,"_389":-5},{"_104":385,"_276":399,"_387":391,"_388":392,"_389":393},{"_104":385,"_276":398,"_387":-5,"_388":-5,"_389":-5},{"_104":385,"_276":397,"_387":391,"_388":392,"_389":395},{"_104":385,"_276":396,"_387":391,"_388":392,"_389":393},{"_104":385,"_276":394,"_387":391,"_388":392,"_389":395},{"_104":385,"_276":390,"_387":391,"_388":392,"_389":393},{"_104":385,"_276":386,"_387":-5,"_388":-5,"_389":-5},[503],{"_344":57,"_57":409},"task_e_6a03d7701f6c83209fe3692577361dd0",1778636656.12296,"Github Mention: fix: metrics layer cleanliness + matrix.py doc corrections","has_generated_title","has_unread_turn","denormalized_metadata",{"_535":43,"_536":537,"_538":-5,"_539":-5,"_529":540,"_541":-5,"_542":-5,"_543":-5,"_544":-5},"task_status_display",{"_523":524,"_525":176,"_141":138,"_526":-5,"_527":311},"creator_workspace","external_pull_requests",[516],{"_53":517,"_518":95,"_519":520,"_521":140},"github-1158893709-43","assistant_turn_id","pull_request",{"_266":267,"_257":268,"_269":270,"_271":70,"_272":18,"_273":18,"_274":275,"_276":277,"_278":228,"_279":138,"_280":281,"_282":140,"_283":-5,"_284":-5,"_285":286,"_287":-5,"_288":-5,"_289":522,"_291":292,"_293":294,"_295":296,"_297":298},"codex_updated_sha",{"_251":299,"_160":299,"_300":-5,"_255":301,"_53":302},"latest_turn_status_display",{"_528":95,"_123":124,"_529":530,"_106":531,"_532":-5,"_533":-5,"_534":311,"_125":-5},"environment_label","fix_task_id","initial_intent","turn_id","diff_stats",{"_325":326,"_327":328,"_329":326},[],"image_asset_pointer_citations","issue_counts","intent","num_follow_ups","repo_name_map",{},"last_user_turn_created_at","last_turn_status",{"_325":-5,"_327":-5,"_329":-5},"last_pushed_turn_id","start_branch_name","pushed_branch_name","cached_pull_request_data","dd",{"_559":560,"_561":562},"disablePrefetch","shouldPrefetchAccount","shouldPrefetchUser","shouldPrefetchSystemHints","manageRootRouteStylesheet","mobileWebHandoffEnabled","promoteCss","disableSSR","stripModulepreloadImports","paidCampaignAppRedirect","statsigGateEvaluationsPromise",["P",558],"traceId","17273348856699400851","traceTime",1789485707237]