ℹ️ About Codex in GitHub

\n
\n\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\n- Open a pull request for review\n- Mark a draft as ready\n- Comment \"@codex review\".\n\nIf Codex has suggestions, it will comment; otherwise it will react with 👍.\n\n\n\n\nCodex can also answer questions or update the PR. Try commenting \"@codex address that feedback\".\n \n

","side","line","**_{_{![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)}} Enforce corpus-wide song-ID coverage for song holdout**\n\nWhen the target has a `song_id` but an alternate transcription of that composition is a pre-v10 or uncurated record with `song_id = None`, the specified equality filter retains that record and leaks the held-out song into the corpus. Refusing only a target that lacks an ID therefore does not make the experiment fail-closed; song-holdout mode must also reject, migrate, or exclude every participating source with unknown identity (and validate the corpus-wide mapping) before material construction.\n\nUseful? React with 👍 / 👎.","RIGHT","\n\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n>

\n>

⚙️ Run configuration

\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro Plus\n> \n> **Run ID**: `8f3a7c34-c255-495f-af1c-404218772bcb`\n> \n>

\n> \n>

\n>

📥 Commits

\n> \n> Reviewing files that changed from the base of the PR and between 8fff78157d666adcc5e0aa6e0f507c758d3b8b28 and 8965184448ddd05ec1b21dc395b9bc262e7edfca.\n> \n>

\n> \n>

\n>

📒 Files selected for processing (4)

\n> \n> * `docs/adr/0031-canonical-song-identity.md`\n> * `docs/adr/README.md`\n> * `docs/audit/2026-07-generator-reachability-metric-inventory.md`\n> * `docs/decisions.log.md`\n> \n>

\n> \n> ```ascii\n> _______________________________________________________________________________________________\n> < bm = Δc/Δt: Bug momentum equals change in code over change in time. Can't argue with physics. >\n> -----------------------------------------------------------------------------------------------\n> \\\n> \\ (\\__/)\n> (•ㅅ•)\n> / 　づ\n> ```\n\n\n\n\n\n

✨ Finishing Touches

\n\n

🧪 Generate unit tests (beta)

\n\n- [ ] Create PR with unit tests\n- [ ] Commit unit tests in branch `claude/adr-canonical-song-identity`\n\n

\n\n

\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=PhysShell/griff&utm_content=157)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n

❤️ Share

\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n

\n\n\n_{Comment `@coderabbitai help` to get the list of available commands.}\n\n","## What\n\n**ADR-0031** proposes a canonical **song identity** for the corpus — the Phase-1 prerequisite the [Generator Reachability Lab Phase 0 audit](https://github.com/PhysShell/griff/blob/main/docs/audit/2026-07-generator-reachability-metric-inventory.md) (#154) named: without it, **song-level holdout is not implementable fail-closed** (two transcriptions of one song have different `sha256`, so a \"song holdout\" silently keeps one and excludes the other), which also weakens the human-similarity benchmark's \"split by source identity\" law (#153).\n\nDocs-only; **Status: Proposed** — binds nothing until accepted (`docs/adr/README.md`). Implementation is a separate red→green slice once accepted.\n\n## The decision\n\nAdd an optional, **curator-assigned** `SourceRef.song_id: Option` (schema **v10**) at the **Work** level:\n\n- griff already has the **Manifestation** level (`SourceRef.sha256`, v9) and the **span** level (`EnsembleRef`, v4) — this adds the missing **Work** (composition) level above them.\n- Follows the established **optional-field, forward-compatible** pattern (like `rights` v7, `EnsembleRef` v4, `sha256` v9): pre-v10 records load as `None` and round-trip byte-identically.\n- **Curator-assigned, never content-derived** (like rights v7). Groups files that are the same composition **for leakage-safe holdout / source-identity splits only** — explicitly **no** cover-detection, arrangement-equivalence, or production-scoring claim.\n- **Fail-closed:** `HoldoutTargetSong` requires `song_id`; a record without it can't be song-held-out (typed refusal / migrate), never a basename/title fallback.\n\n## Prior art\n\nSurveyed in `decisions.log.md` (prior-art-first rule): **FRBR** (Work → Expression → Manifestation → Item) and **MusicBrainz** (Work ↔ Recording ↔ Release, ISWC work code) — both separate the abstract *work* from its *manifestations*. `SongId` is the Work level; no external id scheme (ISWC/MBID) is adopted as the stored value.\n\n## Also\n\n- `docs/adr/README.md` — index row 0031.\n- `docs/decisions.log.md` — prior-art Y-statement.\n- `…-metric-inventory.md` §3 — back-reference to the ADR from the Phase-1-prerequisite note.\n\nDocs-only → CI (Rust-only) green. Not merging without an explicit human GO.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)\n\nhttps://claude.ai/code/session_012T7SRMiXmZe5v1imtrKMPi","base_ref","head_ref","pull_request_info",[532],{"_471":57,"_57":533},"@codex — accepted, sharp catch. Fixed in `8965184`.\n\nYou're right: guarding only the *target* isn't fail-closed. An alternate transcription of the target composition that is a pre-v10 / uncurated record (`song_id = None`) would be silently retained by an equality filter (`exclude where song_id == target`), re-leaking the held-out song.\n\nStrengthened the `HoldoutTargetSong` contract in the ADR: it now requires **`song_id` coverage over the corpus**, and additionally **excludes (or refuses the run on) every source with `song_id = None`** before material construction — an unidentified record can't be proven *not* to be an alternate of the target, so it must not remain. The manifest `songs` cross-check validates coverage. The Consequences note is aligned (a `HoldoutTargetSong` run excludes pre-v10 `None` records until curated).\n\nStill a Proposed, docs-only ADR (binds nothing); the schema-v10 implementation will carry this contract into its red→green tests. Not merging without an explicit human GO.",[566,567],[],{"_323":565},{"_320":564},{"_320":563},{"_286":287,"_277":288,"_289":290,"_291":70,"_292":18,"_293":18,"_294":295,"_296":297,"_298":248,"_299":137,"_300":301,"_302":303,"_304":-5,"_305":-5,"_306":307,"_308":-5,"_309":-5,"_310":562,"_312":313,"_314":313,"_315":316,"_317":318},{"_53":133,"_171":172,"_173":174,"_175":18,"_176":177,"_178":179,"_180":549,"_182":-5,"_183":184,"_185":18,"_186":550,"_188":551,"_190":552,"_192":553,"_194":554,"_196":555,"_198":-5,"_199":200,"_201":202,"_203":204,"_205":556,"_66":-5,"_129":207,"_208":557,"_210":558,"_212":213,"_214":18,"_215":18},{"_143":542},[543,544,545],{"_155":548,"_157":168},{"_155":547,"_157":164},{"_155":546,"_157":158},{"_159":160,"_103":161,"_129":162},{"_159":165,"_103":161,"_129":166},{"_159":169,"_103":161,"_129":170},{"_279":280,"_281":-5,"_282":-5,"_283":-5,"_284":-5,"_285":-5},[238],[218],[218],{"_238":559},{"_220":221,"_222":223,"_224":225,"_226":227,"_228":229,"_230":231,"_232":233,"_234":235,"_236":237},{},[],{"_219":70},{"_216":70,"_217":218},{"_53":240,"_159":241,"_242":560,"_244":174,"_245":246,"_247":248,"_249":250,"_251":252,"_253":254,"_255":75,"_256":18,"_257":-5,"_258":-5,"_259":-5,"_260":-5,"_261":-5,"_262":-5,"_263":264,"_265":-5,"_66":561},{"_271":272,"_53":273,"_103":274,"_275":276,"_277":278},{"_267":18,"_268":18,"_269":18,"_270":18},{"_271":272,"_159":272,"_319":-5,"_275":276,"_53":273},[],[],[],{"_103":460,"_107":104,"_342":573},{"_103":327,"_328":568},[569],{"_331":332,"_333":-5,"_334":570,"_336":-5},[571],{"_338":339,"_340":341,"_342":572,"_344":70},[345,218,346,347,218,348,218,349,350,218,351,352,353,354,355,356,218,357,358,359,360,218,361,362,363,364,365,366,367,368,369,370,371,372,373,374,218,375,376,377,378,379,380,381,382,218,383,218,384,385,386,218,387,388,389,390,391,392,393,218,394,395,396,397,398,399,218,400,401,402,403,404,405,406,407,408,409,410,218,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,218,427,428,429,430,218,431,432,433,434,218,435,218,436,218,437,438,439,440,441,442,443,444,218,445,218,446,447,448,449,450,218,451,218,452,453,454,455,456,457,458,459],[574,575,576,577,578,579,580,581,582],{"_471":57,"_57":485},{"_471":473,"_331":332,"_338":483,"_340":484},{"_471":57,"_57":482},{"_471":473,"_331":332,"_338":480,"_340":481},{"_471":57,"_57":479},{"_471":473,"_331":332,"_338":477,"_340":478},{"_471":57,"_57":476},{"_471":473,"_331":332,"_338":474,"_340":475},{"_471":57,"_57":472},[585,586,587,588,589],{"_495":496,"_244":174,"_497":287,"_255":-5,"_498":238,"_499":18,"_500":-5,"_501":-5,"_502":503,"_504":505,"_506":-5,"_507":-5,"_508":509,"_510":18,"_511":70,"_512":65,"_513":18,"_514":-5},{"_103":460,"_107":310,"_342":590},{"_294":295,"_296":527,"_528":301,"_529":139,"_306":-5,"_103":530},{"_103":520,"_296":526,"_331":-5,"_522":-5,"_523":-5},{"_103":520,"_296":524,"_331":332,"_522":525,"_523":-5},{"_103":520,"_296":521,"_331":-5,"_522":-5,"_523":-5},[591],{"_471":57,"_57":533},"task_e_6a66577aae9483209295b4c638612a8a",1785091962.68209,"GitHub Mention: docs(adr): ADR-0031 — canonical curator-assigned song identity (schema v10)","has_generated_title","has_unread_turn","denormalized_metadata",{"_623":43,"_624":625,"_626":-5,"_627":-5,"_618":628,"_629":-5,"_630":-5,"_631":-5,"_632":-5},"task_status_display",{"_611":612,"_613":174,"_140":137,"_614":-5,"_615":616},"creator_workspace","external_pull_requests",[604],{"_53":605,"_606":94,"_607":608,"_609":139},"github-1242348854-157","assistant_turn_id","pull_request",{"_286":287,"_277":288,"_289":290,"_291":70,"_292":18,"_293":18,"_294":295,"_296":297,"_298":248,"_299":137,"_300":301,"_302":303,"_304":-5,"_305":-5,"_306":307,"_308":-5,"_309":-5,"_310":610,"_312":313,"_314":313,"_315":316,"_317":318},"codex_updated_sha",{"_271":272,"_159":272,"_319":-5,"_275":276,"_53":273},"latest_turn_status_display",{"_617":94,"_122":123,"_618":-5,"_105":619,"_620":-5,"_621":-5,"_622":616,"_124":-5},"environment_label","fix_task_id","initial_intent","pr","turn_id","diff_stats",[],"image_asset_pointer_citations","issue_counts","intent","num_follow_ups","repo_name_map",{},"last_user_turn_created_at","last_turn_status",{"_633":-5,"_634":-5,"_635":-5},"last_pushed_turn_id","start_branch_name","pushed_branch_name","cached_pull_request_data","files_modified","lines_added","lines_removed","dd",{"_650":651,"_652":653},"disablePrefetch","shouldPrefetchAccount","shouldPrefetchUser","shouldPrefetchSystemHints","manageRootRouteStylesheet","mobileWebHandoffEnabled","promoteCss","disableSSR","stripModulepreloadImports","paidCampaignAppRedirect","statsigGateEvaluationsPromise",["P",649],"traceId","18186598118620352294","traceTime",1788800144178]