\n\n","base","head","base_sha","c277d8f887a16ca9d873c6eebd861f1490859ebc","head_sha","merge_commit_sha","1add65e27ca5e0f2fee527ee20fa6771410d7e7b","comments","diff","user",{"_237":284,"_150":284,"_285":-5,"_241":286,"_45":287},"commits",5,"changed_files",3,"additions",339,"deletions",83,"logbie","email","https://avatars.githubusercontent.com/u/1138960?v=4",1138960,"events",[],[],"messages",[],{"_95":823,"_99":96,"_312":824},{"_95":295,"_296":297},"partial_repo_snapshot","files",[298,299,300],{"_301":523,"_303":-5,"_304":524,"_306":-5},{"_301":406,"_303":-5,"_304":407,"_306":-5},{"_301":302,"_303":-5,"_304":305,"_306":-5},"path","History/dev-diary/2026/2026-08-14-issue-707-lint-keyword-on-tokens.md","contents","line_range_contents",[307],"missing_reason",{"_308":309,"_310":311,"_312":313,"_314":62},"line_range_start",1,"line_range_end",127,"content",[315,164,316,164,317,318,319,320,164,321,322,323,320,164,324,325,164,326,327,328,164,329,330,331,332,333,334,164,335,164,336,337,338,339,164,340,341,342,164,343,344,345,346,164,347,164,348,349,350,351,164,352,353,354,164,355,356,357,358,359,164,360,361,362,164,363,164,364,365,366,367,164,368,369,370,371,164,372,164,373,374,375,164,321,376,377,320,164,378,164,379,164,380,381,382,383,384,164,385,164,386,387,164,388,389,164,390,391,392,320,164,393,394,395,396,397,164,398,399,400,164,401,402,403,404,164,405],"contains_end_of_file","# 2026-08-14 — LINT-KEYWORD was a substring search, not a lint (#707)","## Symptom","```wfl","store s as \"MNOP\"","display s","```","```text","warning[LINT-KEYWORD]: Keyword 'NO' should be lowercase"," = Change to 'no'","The control confirms the mechanism: `\"MXYP\"` reports nothing. The rule matched","the substring `NO` inside `MNOP`, inside a string literal.","Comments went the same way — `// Note:` produced `Keyword 'No'`, `// TODO:`","produced `Keyword 'TO'` — as did ordinary words: `\"Ineligible\"` produced","`Keyword 'In'`.","Found while porting a PHP minifier, where the program needs the character-class","constant","`\"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_\"`. That string","contains `MNOP` and cannot be changed — it *is* the definition of `\\w`. Combined","with the companion `LINT-INDENT` defect (#706), it meant `--lint` could not be","used as a gate at all.","## Root cause","`KeywordCasingRule::apply` took the parsed `Program` and ignored it","(`_program`), then ran `source.find()` over the raw file for each of 26","keywords, in `UPPERCASE` and `Mixedcase` forms. No tokenization, no word","boundaries, no exclusion of strings or comments.","The `Mixedcase` half is what made it collide with English: `No`, `To`, `In`,","`For`, `Each`, `End`, `Check`, `If`, `Count`, `From` are ordinary words and","common prefixes, so any file with prose comments was likely to trip several.","It was also a **false negative**. `source.find` returns only the first hit, so","the rule emitted at most one diagnostic per keyword per casing — 52 for a file","of any size. A file with fifty genuine `STORE` keywords reported one. The rule","could neither avoid reporting non-keywords nor finish reporting real ones.","## The fact that shaped the fix","WFL keywords are **case-sensitive**: `src/lexer/token.rs:17` is","`#[token(\"store\")]` with no `ignore(case)`. So `STORE` and `Store` never lex as","keywords — they lex as *identifiers*. `STORE s AS \"x\"` fails with","`Variable 'STORE s AS' is not defined`.","That rules out the obvious repair. \"Only report where the lexer produced a","keyword token\" would have reported **nothing**, silently deleting the lint while","looking like a fix.","The rule now flags **identifier tokens whose lowercased text is a keyword**,","which is what it was always reaching for. All four defects fall out at once:","string literals lex as string tokens, comments never reach the token stream,","`Ineligible` lowercases to a non-keyword, and iterating tokens reports every","occurrence rather than the first.","Keyword-ness is decided by lexing the lowercased word and checking it yields a","single non-identifier token — so the rule tracks the lexer instead of a","hardcoded list that drifts. The 26-keyword array is gone.","## The mechanic that was load-bearing","The lexer merges adjacent identifier words into one multi-word `Identifier`","token: `STORE counter` lexes as `Identifier(\"STORE counter\")`. Checking the","whole token text would have found no keyword — and silently deleted the lint","again, in a second way.","So the rule slices `byte_start..byte_end` out of the source and checks each","whitespace-separated word, offsetting the column accordingly. A multi-word","identifier cannot span lines (a newline flushes it), so the line is the token's","and the column is exact.","## Red evidence","5 of 10 linter tests failed against the old rule. The incidental one is the","nicest: the three-occurrence case returned two diagnostics — `STORE` once, plus","a bogus `TO` matched *inside the word* `STORE`.","---- test_keyword_casing_ignores_string_literals stdout ----","string literal contents must not be linted, got [... message: \"Keyword 'NO' should be lowercase\" ...]","Red: `74114dc`. Green: `f6ff1f1`. 10/10 after.","## Known limitation, unchanged by this work","`--lint` runs after parsing, so a mis-cased keyword that *breaks* parsing never","reaches the linter — `STORE alpha as 1` exits 2 with a parse error. LINT-KEYWORD","therefore only fires on mis-cased words that still parse, e.g. `store Count as 5`.","That is pre-existing CLI behavior, identical before and after, and is recorded","here so the rule's real reach is not overstated.","## Review round: the one token that is case-insensitive","Codex and Devin both caught, independently, that the first cut of this rewrite","lost coverage the old rule had.","`yes`/`no`/`true`/`false` are the single case-*insensitive* production in the","lexer:","```rust","#[regex(\"(?i:yes|no|true|false)\", ...)]","BooleanLiteral(bool),","So `store flag as YES` lexes as a `BooleanLiteral`, never as an `Identifier`,","and an identifier-only rule skipped it silently. The pre-#707 implementation","carried `yes` and `no` in its 26-keyword array and *did* warn on them — so the","claim that \"output for genuine hits is identical\" was false for exactly those","two keywords, in exactly the way a substring search happened to get right.","The rule now checks `BooleanLiteral` spans as well. Everything else in the","lexer is case-sensitive — `NothingLiteral` is `#[token(\"nothing\")]`, so","`Nothing` still arrives as an identifier and was always covered.","Worth recording as a general shape: replacing a crude mechanism with a precise","one silently drops whatever the crude mechanism covered by accident. The","regression was invisible in the six tests written for the reported defect,","because those tests were all about false *positives*.","Red: `90bfb69`. Green: the boolean-literal branch, 12/12 after.","src/linter/tests.rs",[408],{"_308":309,"_310":409,"_312":410,"_314":62},187,[411,412,413,164,414,415,416,417,418,164,419,420,421,164,422,164,423,424,425,426,164,414,427,428,429,430,431,432,426,164,414,433,434,435,436,437,438,439,426,164,440,441,442,443,444,445,417,446,164,447,420,421,164,448,426,164,449,414,450,451,452,453,454,455,426,164,456,414,457,458,452,453,459,455,426,164,460,414,461,462,452,453,463,455,426,164,464,414,465,466,164,467,468,469,470,471,472,455,473,474,475,426,164,476,414,477,478,479,164,480,481,482,452,483,484,485,455,426,164,486,414,487,488,479,452,453,489,455,426,164,414,490,491,417,418,164,492,493,164,494,452,483,484,495,455,452,496,484,497,455,426,164,498,499,500,501,502,414,503,504,505,506,507,508,509,510,511,512,513,514,515,511,516,517,515,518,426,164,519,414,520,521,452,453,522,455,426],"use super::*;","use crate::lexer::lex_wfl_with_positions;","use crate::parser::Parser;","#[test]","fn test_naming_convention_rule() {"," let input = \"store Counter as 5\";"," let tokens = lex_wfl_with_positions(input);"," let program = Parser::new(&tokens).parse().unwrap();"," let rule = NamingConventionRule;"," let mut reporter = DiagnosticReporter::new();"," let file_id = reporter.add_file(\"test.wfl\", input);"," let diagnostics = rule.apply(&program, &mut reporter, file_id);"," assert_eq!(diagnostics.len(), 1);"," assert!(diagnostics[0].message.contains(\"Counter\"));"," assert_eq!(diagnostics[0].code, \"LINT-NAME\");","}","fn test_snake_case_conversion() {"," assert_eq!(to_snake_case(\"camelCase\"), \"camel_case\");"," assert_eq!(to_snake_case(\"PascalCase\"), \"pascal_case\");"," assert_eq!(to_snake_case(\"snake_case\"), \"snake_case\");"," assert_eq!(to_snake_case(\"with space\"), \"with_space\");"," assert_eq!(to_snake_case(\"Mixed_Style\"), \"mixed_style\");","fn test_is_snake_case() {"," assert!(is_snake_case(\"snake_case\"));"," assert!(is_snake_case(\"simple\"));"," assert!(!is_snake_case(\"camelCase\"));"," assert!(!is_snake_case(\"PascalCase\"));"," assert!(!is_snake_case(\"with space\"));"," assert!(!is_snake_case(\"Mixed_Style\"));","/// Apply only `KeywordCasingRule` to `input` and return its diagnostics.","///","/// The rule does not consult the AST, so an input that intentionally fails to","/// parse (e.g. `STORE counter as 5`, where `STORE` lexes as an identifier)","/// falls back to an empty program rather than panicking.","fn keyword_casing_diagnostics(input: &str) -> Vec {"," let program = Parser::new(&tokens).parse().unwrap_or_default();"," let rule = KeywordCasingRule;"," rule.apply(&program, &mut reporter, file_id)","/// Regression for #707: keyword casing must not match inside string literals.","fn test_keyword_casing_ignores_string_literals() {"," let diagnostics = keyword_casing_diagnostics(\"store s as \\\"MNOP\\\"\");"," assert!("," diagnostics.is_empty(),"," \"string literal contents must not be linted, got {diagnostics:?}\""," );","/// Regression for #707: keyword casing must not match inside comments.","fn test_keyword_casing_ignores_comments() {"," let diagnostics = keyword_casing_diagnostics(\"// Note: this explains the next step\");"," \"comment text must not be linted, got {diagnostics:?}\"","/// Regression for #707: keyword casing must not match inside ordinary words.","fn test_keyword_casing_ignores_words_containing_keywords() {"," let diagnostics = keyword_casing_diagnostics(\"store label as \\\"Ineligible\\\"\");"," \"substrings of ordinary words must not be linted, got {diagnostics:?}\"","/// A genuinely mis-cased keyword must still be reported (backward compatibility).","fn test_keyword_casing_flags_uppercase_keyword() {"," let diagnostics = keyword_casing_diagnostics(\"STORE counter as 5\");"," assert_eq!(diagnostics.len(), 1, \"got {diagnostics:?}\");"," assert_eq!(diagnostics[0].code, \"LINT-KEYWORD\");"," assert_eq!(diagnostics[0].severity, Severity::Warning);"," assert_eq!("," diagnostics[0].message,"," \"Keyword 'STORE' should be lowercase\""," assert_eq!(diagnostics[0].notes, vec![\"Change to 'store'\".to_string()]);"," assert_eq!(diagnostics[0].line, 1);"," assert_eq!(diagnostics[0].column, 1);","/// Regression for #707: every occurrence is reported, not just the first.","fn test_keyword_casing_reports_every_occurrence() {"," let input = \"STORE alpha as 1\\nSTORE beta as 2\\nSTORE gamma as 3\";"," let diagnostics = keyword_casing_diagnostics(input);"," assert_eq!(diagnostics.len(), 3, \"got {diagnostics:?}\");"," let lines: Vec = diagnostics.iter().map(|d| d.line).collect();"," assert_eq!(lines, vec![1, 2, 3]);"," diagnostics"," .iter()"," .all(|d| d.message == \"Keyword 'STORE' should be lowercase\")","/// A correctly written program produces no keyword-casing diagnostics.","fn test_keyword_casing_clean_program() {"," let input = \"store counter as 5\\ndisplay counter\\n\";"," \"lowercase program must be clean, got {diagnostics:?}\"","fn test_linter_integration() {"," let input = \"store Counter as 5\\nstore snakecase as 10\";"," let linter = Linter::new();"," let (diagnostics, success) = linter.lint(&program, input, \"test.wfl\");"," assert!(!success);"," .any(|d| d.code == \"LINT-NAME\" && d.message.contains(\"Counter\"))"," !diagnostics"," .any(|d| d.code == \"LINT-NAME\" && d.message.contains(\"snakecase\"))","/// Regression for #707 review: `yes`/`no`/`true`/`false` lex case-insensitively","/// (`src/lexer/token.rs:446`), so `YES` becomes a `BooleanLiteral` rather than an","/// `Identifier`. The pre-#707 rule carried `yes`/`no` in its keyword array and","/// warned on them, so skipping non-identifier tokens would silently drop that","/// coverage.","fn test_keyword_casing_flags_mis_cased_boolean_literals() {"," for (source, expected) in ["," (\"store flag as YES\", \"YES\"),"," (\"store flag as No\", \"No\"),"," (\"store flag as TRUE\", \"TRUE\"),"," (\"store flag as False\", \"False\"),"," ] {"," let diagnostics = keyword_casing_diagnostics(source);"," assert_eq!("," diagnostics.len(),"," 1,"," \"`{source}` should report exactly one mis-cased literal, got {diagnostics:?}\""," );"," diagnostics[0].message,"," format!(\"Keyword '{expected}' should be lowercase\")"," }","/// Correctly-cased boolean literals must stay silent.","fn test_keyword_casing_accepts_lowercase_boolean_literals() {"," let diagnostics = keyword_casing_diagnostics(\"store flag as yes\\nstore other as false\");"," \"lowercase boolean literals must not be linted, got {diagnostics:?}\"","src/linter/mod.rs",[525],{"_308":309,"_310":526,"_312":527,"_314":62},565,[528,412,529,530,531,532,164,533,534,164,535,164,536,537,538,539,540,541,426,164,542,543,544,545,426,164,546,547,548,549,550,551,552,164,553,554,555,556,557,558,164,559,518,164,560,561,518,164,562,563,518,164,564,565,518,164,566,537,538,567,568,569,570,571,572,164,573,164,574,575,576,577,578,579,164,580,581,582,518,164,583,584,585,586,518,426,164,587,164,588,589,590,518,164,591,592,518,164,536,537,538,593,540,594,595,596,164,597,598,599,600,601,602,600,603,604,605,606,607,608,609,610,611,612,613,614,615,601,616,617,600,603,604,605,606,618,608,609,610,611,612,613,614,615,601,619,620,621,579,164,483,518,426,164,622,623,624,625,626,627,628,426,164,629,164,630,589,631,518,164,591,632,518,164,536,537,633,539,540,594,596,164,634,635,164,636,164,637,638,639,164,640,641,601,164,642,164,643,644,645,646,647,648,649,601,164,650,651,606,652,653,654,655,656,610,657,658,613,659,601,164,660,661,601,621,579,164,483,518,426,164,662,164,663,589,664,518,164,591,665,518,164,536,537,633,539,540,594,596,164,666,667,552,668,164,669,670,671,672,673,674,675,164,676,677,678,679,680,681,682,683,684,685,686,687,688,689,690,691,692,693,694,695,696,601,697,698,164,699,700,641,601,164,701,702,703,704,164,705,651,606,706,707,708,610,709,710,613,659,601,621,579,164,483,518,426,164,711,712,713,714,715,164,716,717,718,719,621,720,721,579,518,164,722,723,518,164,724,426,164,725,441,726,727,728,729,730,731,426,164,732,164,733,589,734,518,164,591,735,518,164,536,537,633,539,540,594,596,164,634,635,164,637,638,164,736,651,606,737,738,739,610,657,740,613,659,601,621,579,164,483,518,426,164,741,742,164,743,589,744,518,164,591,745,518,164,536,537,633,539,540,594,596,164,746,164,634,635,164,637,638,164,747,651,606,748,749,750,610,657,751,613,659,601,621,579,164,483,518,426,164,752,753,164,754,589,755,518,164,591,756,518,164,536,537,538,593,540,594,596,164,757,164,597,758,579,164,483,518,426,164,759,760,761,762,763,764,765,766,767,768,769,770,771,772,773,774,775,776,777,778,779,780,781,621,782,579,518,164,783,784,785,786,787,788,789,790,621,791,792,793,601,621,579,794,795,796,797,798,790,621,579,799,798,800,621,579,801,518,426,164,802,803,426,164,804,805,806,164,807,808,809,810,621,811,812,813,814,815,579,164,816,518,164,817,426,164,818,819,164,820,821,822,518,426],"use crate::diagnostics::{DiagnosticReporter, Severity, WflDiagnostic};","use crate::lexer::token::Token;","use crate::parser::ast::{Program, Statement};","use std::collections::HashMap;","use std::path::Path;","pub trait LintRule {"," fn code(&self) -> &'static str;"," fn description(&self) -> &'static str;"," fn apply("," &self,"," program: &Program,"," reporter: &mut DiagnosticReporter,"," file_id: usize,"," ) -> Vec;","pub struct Linter {"," rules: Vec>,"," max_line_length: usize,"," max_nesting_depth: usize,","impl Linter {"," pub fn new() -> Self {"," let mut linter = Self {"," rules: Vec::new(),"," max_line_length: 100, // Default max line length"," max_nesting_depth: 5, // Default max nesting depth"," };"," linter.add_rule(Box::new(NamingConventionRule));"," linter.add_rule(Box::new(IndentationRule));"," linter.add_rule(Box::new(KeywordCasingRule));"," linter.add_rule(Box::new(TrailingWhitespaceRule));"," linter.add_rule(Box::new(LineLengthRule));"," linter.add_rule(Box::new(NestingDepthRule));"," linter"," pub fn add_rule(&mut self, rule: Box) {"," self.rules.push(rule);"," pub fn set_max_line_length(&mut self, length: usize) {"," self.max_line_length = length;"," pub fn set_max_nesting_depth(&mut self, depth: usize) {"," self.max_nesting_depth = depth;"," pub fn lint("," source: &str,"," file_path: &str,"," ) -> (Vec, bool) {"," println!(\"Starting linting process...\");"," let mut reporter = DiagnosticReporter::new();"," let file_id = reporter.add_file(file_path, source);"," let mut all_diagnostics = Vec::new();"," for rule in &self.rules {"," println!(\"Applying rule: {}\", rule.code());"," let diagnostics = rule.apply(program, &mut reporter, file_id);"," println!(\"Rule {} found {} issues\", rule.code(), diagnostics.len());"," all_diagnostics.extend(diagnostics);"," }"," println!(\"Linting complete. Found {} issues\", all_diagnostics.len());"," let is_empty = all_diagnostics.is_empty();"," (all_diagnostics, is_empty)"," pub fn load_config(&mut self, dir: &Path) {"," let config = crate::config::load_config(dir);"," self.set_max_line_length(config.max_line_length);"," self.set_max_nesting_depth(config.max_nesting_depth);","struct NamingConventionRule;","impl LintRule for NamingConventionRule {"," fn code(&self) -> &'static str {"," \"LINT-NAME\""," fn description(&self) -> &'static str {"," \"Variable and action names should use snake_case\""," _reporter: &mut DiagnosticReporter,"," ) -> Vec {"," println!(\" NamingConventionRule: checking variable and action names\");"," let mut diagnostics = Vec::new();"," for statement in &program.statements {"," match statement {"," Statement::VariableDeclaration {"," name, line, column, .."," }"," | Statement::Assignment {"," } if !is_snake_case(name) => {"," let snake_case_name = to_snake_case(name);"," let diagnostic = WflDiagnostic::new("," Severity::Warning,"," format!(\"Variable name '{name}' should be snake_case\"),"," Some(format!(\"Rename to '{snake_case_name}'\")),"," \"LINT-NAME\".to_string(),"," file_id,"," *line,"," *column,"," None,"," );"," diagnostics.push(diagnostic);"," Statement::VariableDeclaration { .. } | Statement::Assignment { .. } => {}"," Statement::ActionDefinition {"," format!(\"Action name '{name}' should be snake_case\"),"," Statement::ActionDefinition { .. } => {}"," _ => {}"," }","#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]","pub enum RuleSeverity {"," Allow, // Rule is disabled"," Warn, // Rule generates warnings but doesn't cause failure"," #[default]"," Deny, // Rule generates errors and causes failure"," Forbid, // Rule generates errors and cannot be overridden","struct IndentationRule;","impl LintRule for IndentationRule {"," \"LINT-INDENT\""," \"Code should be indented with 4 spaces\""," _program: &Program,"," if let Ok(file) = reporter.files.get(file_id) {"," let source = file.source();"," let mut expected_indent = 0;"," for (line_idx, line) in source.lines().enumerate() {"," let line_num = line_idx + 1;"," let trimmed = line.trim_start();"," if trimmed.is_empty() || trimmed.starts_with(\"//\") || trimmed.starts_with('#') {"," continue;"," let indent_spaces = line.len() - trimmed.len();"," if (trimmed.starts_with(\"end \")"," || trimmed == \"end action\""," || trimmed == \"otherwise:\""," || trimmed == \"end check\")"," && expected_indent >= 4"," {"," expected_indent -= 4;"," if indent_spaces != expected_indent {"," diagnostics.push(WflDiagnostic::new("," format!("," \"Line should be indented with {expected_indent} spaces, found {indent_spaces}\""," ),"," Some(format!(\"Adjust indentation to {expected_indent} spaces\")),"," \"LINT-INDENT\".to_string(),"," line_num,"," 1, // Column is always 1 for indentation issues"," ));"," if trimmed.ends_with(':') || trimmed.contains(\"then:\") {"," expected_indent += 4;","struct KeywordCasingRule;","impl LintRule for KeywordCasingRule {"," \"LINT-KEYWORD\""," \"Keywords should be lowercase\""," let Ok(file) = reporter.files.get(file_id) else {"," return diagnostics;"," let source = file.source();"," // WFL keywords are case-sensitive, so `STORE` never lexes as a keyword —"," // it lexes as an identifier. A mis-cased keyword is therefore an"," // identifier token whose lowercase form *is* a keyword. Working from the"," // token stream (instead of raw substring search over the source) keeps"," // string literals and comments out of the rule entirely, never matches"," // inside a longer word, and reports every occurrence rather than the first."," let mut keyword_cache: HashMap = HashMap::new();"," for token in lex_wfl_with_positions(source) {"," // The lexer merges adjacent identifier words into one multi-word"," // identifier, so check each word separately. Words are ASCII and the"," // separators are spaces/tabs, so the byte offset within the token's"," // span is also the column offset. Multi-word identifiers never span"," // lines (a newline flushes them), so the line is the token's line."," let text = match token.token {"," Token::Identifier(ref name) => source"," .get(token.byte_start..token.byte_end)"," .unwrap_or(name.as_str()),"," // `yes`/`no`/`true`/`false` are the one case-*insensitive*"," // production in the lexer (`src/lexer/token.rs:446`), so `YES`"," // lexes as a boolean literal and never reaches the identifier"," // branch. The pre-#707 rule carried `yes`/`no` in its keyword"," // array and warned on them, so they are checked here to keep"," // that coverage rather than silently dropping it."," Token::BooleanLiteral(_) => {"," let Some(text) = source.get(token.byte_start..token.byte_end) else {"," continue;"," };"," text"," _ => continue,"," };"," for (offset, word) in word_positions(text) {"," if !word.chars().any(char::is_uppercase) {"," let lowercase = word.to_lowercase();"," let is_keyword = *keyword_cache"," .entry(lowercase.clone())"," .or_insert_with(|| is_keyword(&lowercase));"," if is_keyword {"," format!(\"Keyword '{word}' should be lowercase\"),"," Some(format!(\"Change to '{lowercase}'\")),"," \"LINT-KEYWORD\".to_string(),"," token.line,"," token.column + offset,","/// Split `text` into whitespace-separated words, paired with each word's byte","/// offset within `text`.","fn word_positions(text: &str) -> Vec<(usize, &str)> {"," let mut words = Vec::new();"," let mut start: Option = None;"," for (index, ch) in text.char_indices() {"," if ch.is_whitespace() {"," if let Some(word_start) = start.take() {"," words.push((word_start, &text[word_start..index]));"," } else if start.is_none() {"," start = Some(index);"," if let Some(word_start) = start {"," words.push((word_start, &text[word_start..]));"," words","/// Whether `lowercase` (already lowercased) is a WFL keyword.","/// Determined by lexing it: a keyword lexes to exactly one non-identifier token.","/// Asking the lexer keeps this rule in sync with the language automatically,","/// instead of a hardcoded keyword list that drifts.","fn is_keyword(lowercase: &str) -> bool {"," let tokens = lex_wfl_with_positions(lowercase);"," matches!(tokens.as_slice(), [only] if !matches!(only.token, Token::Identifier(_)))","struct TrailingWhitespaceRule;","impl LintRule for TrailingWhitespaceRule {"," \"LINT-WHITESPACE\""," \"Lines should not have trailing whitespace\""," if line.trim_end().len() < line.len() {"," \"Line has trailing whitespace\".to_string(),"," Some(\"Remove trailing whitespace\".to_string()),"," \"LINT-WHITESPACE\".to_string(),"," line.trim_end().len() + 1,","/// Rule for enforcing maximum line length","struct LineLengthRule;","impl LintRule for LineLengthRule {"," \"LINT-LENGTH\""," \"Lines should not exceed the maximum length\""," let max_length = 100;"," if line.len() > max_length {"," format!(\"Line exceeds maximum length of {max_length} characters\"),"," Some(format!(\"Shorten line to {max_length} characters or less\")),"," \"LINT-LENGTH\".to_string(),"," max_length + 1,","/// Rule for enforcing maximum nesting depth","struct NestingDepthRule;","impl LintRule for NestingDepthRule {"," \"LINT-COMPLEX\""," \"Nesting depth should not exceed the maximum\""," let max_depth = 5;"," check_nesting_depth(statement, 0, max_depth, &mut diagnostics, file_id);","fn check_nesting_depth("," statement: &Statement,"," current_depth: usize,"," max_depth: usize,"," diagnostics: &mut Vec,"," file_id: usize,",") {"," if current_depth > max_depth {"," match statement {"," Statement::IfStatement { line, column, .. }"," | Statement::WhileLoop { line, column, .. }"," | Statement::ForEachLoop { line, column, .. }"," | Statement::CountLoop { line, column, .. } => {"," diagnostics.push(WflDiagnostic::new("," Severity::Warning,"," format!(\"Nesting depth exceeds maximum of {max_depth}\"),"," Some(\"Refactor to reduce nesting\".to_string()),"," \"LINT-COMPLEX\".to_string(),"," file_id,"," *line,"," *column,"," None,"," ));"," _ => {}"," match statement {"," Statement::IfStatement {"," then_block,"," else_block,"," .."," } => {"," for stmt in then_block {"," check_nesting_depth(stmt, current_depth + 1, max_depth, diagnostics, file_id);"," if let Some(else_stmts) = else_block {"," for stmt in else_stmts {"," check_nesting_depth(stmt, current_depth + 1, max_depth, diagnostics, file_id);"," Statement::WhileLoop { body, .. }"," | Statement::ForEachLoop { body, .. }"," | Statement::CountLoop { body, .. }"," | Statement::TransactionStatement { body, .. } => {"," for stmt in body {"," Statement::ActionDefinition { body, .. } => {"," check_nesting_depth(stmt, current_depth, max_depth, diagnostics, file_id);"," _ => {}","fn is_snake_case(s: &str) -> bool {"," !s.contains(char::is_uppercase) && !s.contains(' ')","fn to_snake_case(s: &str) -> String {"," let mut result = String::new();"," let mut previous_char_is_lowercase = false;"," for (i, c) in s.char_indices() {"," if c.is_uppercase() {"," if i > 0 && previous_char_is_lowercase {"," result.push('_');"," result.push(c.to_lowercase().next().unwrap());"," } else if c == ' ' {"," result.push('_');"," } else {"," result.push(c);"," previous_char_is_lowercase = c.is_lowercase();"," result","#[cfg(test)]","mod tests;","impl Default for Linter {"," fn default() -> Self {"," Self::new()","message",[825,826,827,828,829,830,831],{"_832":49,"_49":842},{"_832":834,"_301":523,"_308":840,"_310":841},{"_832":49,"_49":839},{"_832":834,"_301":406,"_308":837,"_310":838},{"_832":49,"_49":836},{"_832":834,"_301":302,"_308":835,"_310":311},{"_832":49,"_49":833},"content_type","\n* No further code changes were necessary; the working tree remains clean. Therefore, no additional commit or follow-up pull request was created.\n\n**Testing**\n\n* ✅ `cargo test --lib linter::` — 12 passed, 0 failed, 0 ignored.\n* ✅ `git status --short --branch` — clean working tree on branch `work`.","repo_file_citation",99,"\n* Confirmed the dev diary records the root cause, Red commit `90bfb69`, Green result, and the distinction between case-insensitive boolean literals and case-sensitive nothing literals. ",157,186,"\n* Confirmed regression coverage for `YES`, `No`, `TRUE`, and `False`, along with negative coverage for correctly lowercase boolean literals. ",264,310,"### Summary\n\n* Verified that commit `7d31551` addresses the review regression by checking both identifier tokens and case-insensitive `BooleanLiteral` token spans while preserving the existing diagnostic wording and positions. ",{"_95":274,"_45":87,"_99":274,"_845":846,"_847":848,"_849":850,"_134":-5,"_121":851},[86],"input_items",[872,873,874,875,876,877,878,879,880,881,882],"external_post_config",{"_852":853,"_210":161,"_854":254,"_221":-5,"_855":204,"_856":18,"_857":-5,"_858":-5,"_859":860,"_861":862,"_863":-5,"_864":-5,"_865":866,"_867":18,"_868":62,"_869":57,"_870":18,"_871":-5},"user_model_slug","slug",1786727201.273456,"installation_id",66975063,"pr_number","repo_id","enable_internal_github_app_routing","gitlab_service_account_project_id","review_trigger","comment_id",5296047519,"comment_type","issue","pr_write_guard_token","pending_pr_reaction_id","pending_comment_reaction_id",398224056,"comment_if_no_findings","comment_on_error","share_url","is_parallel_review","review_summary_id",{"_95":823,"_99":274,"_312":902},{"_261":262,"_263":264,"_899":268,"_900":131,"_270":-5,"_95":901},{"_95":883,"_263":898,"_301":-5,"_885":-5,"_886":-5},{"_95":883,"_263":897,"_301":523,"_885":888,"_886":-5},{"_95":883,"_263":896,"_301":-5,"_885":-5,"_886":-5},{"_95":883,"_263":895,"_301":523,"_885":888,"_886":-5},{"_95":883,"_263":893,"_301":523,"_885":888,"_886":894},{"_95":883,"_263":892,"_301":-5,"_885":-5,"_886":-5},{"_95":883,"_263":890,"_301":406,"_885":888,"_886":891},{"_95":883,"_263":887,"_301":523,"_885":888,"_886":889},{"_95":883,"_263":884,"_301":-5,"_885":-5,"_886":-5},"pull_request_comment","## Pull request overview\n\nFixes `LINT-KEYWORD` false positives/negatives by switching from raw `source.find()` substring matching to token-based inspection, aligning the lint with what the lexer actually recognizes and allowing it to report every occurrence.\n\n**Changes:**\n- Reimplemented `KeywordCasingRule` to scan lexer tokens (identifiers) and detect mis-cased keywords via lowercasing + re-lexing, with correct per-occurrence positioning.\n- Added focused regression tests for the issue #707 cases (strings/comments/ordinary words) plus multi-occurrence reporting.\n- Added a dev-diary entry documenting the bug, the root cause, and the rationale behind the new approach.\n\n### Reviewed changes\n\nCopilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.\n\n| File | Description |\n| ---- | ----------- |\n| src/linter/mod.rs | Reworks `LINT-KEYWORD` implementation to operate on lexer output (and adds helper utilities). |\n| src/linter/tests.rs | Adds targeted unit tests covering #707 regressions and multi-occurrence reporting. |\n| History/dev-diary/2026/2026-08-14-issue-707-lint-keyword-on-tokens.md | Documents the defect and the design constraints that shaped the fix. |\n\n\n\n\n\n\n\n---\n\n💡 Add a `code-review` agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.","side","line","`KeywordCasingRule` currently only inspects `Token::Identifier` tokens. However `yes`/`no`/`true`/`false` are lexed case-insensitively as `Token::BooleanLiteral`, so mis-cased forms like `YES`/`No` will no longer be warned on even though they were part of the previous keyword list.","RIGHT",288,"The new keyword-casing tests don't cover mis-cased boolean literals (e.g. `YES`/`NO`). Since these lex as `BooleanLiteral` (case-insensitive), they are an easy regression target for this rule and should be covered to lock in the intended behavior.",103,"**Devin Review** found 2 potential issues.\n\n\n\n

\n\n","\n\n🔍 **Keyword set widened from 26 hardcoded words to the lexer's full ~181 keywords**\n\nDeriving keyword-ness from the lexer (`is_keyword` at `src/linter/mod.rs:335-338`) is much broader than the removed 26-word array: `src/lexer/token.rs` defines tokens for common English nouns such as `list`, `text`, `data`, `time`, `date`, `status`, `output`, `error`, `request`, `response`, `empty`, `test`, `start`, `new`, `one`, `any`. Any capitalized word inside a variable name whose lowercase form is one of these now warns, e.g. `store User Data as 5` yields \"Keyword 'Data' should be lowercase\" with the hint \"Change to 'data'\" — applying that hint would turn part of an identifier into a keyword and break the program. This is the rule's intended semantics (the tests use `store Count as 5`), but it materially expands the set of legitimate identifiers that now produce warnings, which matters because `--lint` is used as a gate. Worth confirming against `TestPrograms/`/`examples/` that no shipped program starts emitting new LINT-KEYWORD warnings.\n\n\n\n

\n\n\n\n---\n*Was this helpful? React with 👍 or 👎 to provide feedback.*",349,"\n\n🟡 **Wrongly capitalized yes/no values are no longer reported by the style checker**\n\nOnly words the language reader treats as names are examined (`Token::Identifier` filter at `src/linter/mod.rs:265-267`), while `YES`, `NO`, `Yes`, `No` are read as true/false values, so genuinely mis-capitalized yes/no words are silently skipped.\nImpact: Programs written with `YES`/`NO` instead of `yes`/`no` used to get a style warning and now get none, so the style check quietly stops covering those words.\n\n

Case-insensitive boolean literal regex keeps YES/NO out of the identifier stream

\n\n`src/lexer/token.rs:446` matches booleans case-insensitively (`#[regex(\"(?i:yes|no|true|false)\")]`), confirmed by `src/lexer/tests.rs:615-645` where `\"YES\"`, `\"NO\"`, `\"True\"`, `\"False\"` all lex to `Token::BooleanLiteral`. The new rule iterates tokens and skips anything that is not `Token::Identifier`, so those tokens never reach the word check. The old implementation had `\"yes\"` and `\"no\"` in its 26-keyword array (`src/linter/mod.rs` prior lines 273-274) and did report `store flag as YES` as `Keyword 'YES' should be lowercase`. So the PR claim that \"output for genuine hits is identical\" does not hold for these two keywords. A fix would additionally inspect `Token::BooleanLiteral` (and `NothingLiteral`-style literal) spans, comparing the source slice against its lowercase form.\n\n

\n\n

Prompt for agents

\n\n```\nKeywordCasingRule in src/linter/mod.rs now only inspects Token::Identifier tokens. Because src/lexer/token.rs:446 matches yes/no/true/false case-insensitively, inputs like `store flag as YES` lex to Token::BooleanLiteral and are never examined, so a genuinely mis-cased `YES`/`NO` produces no LINT-KEYWORD warning — a regression versus the removed substring implementation, which listed `yes` and `no` among its keywords. Consider also examining non-identifier tokens whose source slice (source[byte_start..byte_end]) contains uppercase characters and whose lowercase form differs, reporting them with the same message/hint, and add a regression test for `store flag as YES`.\n```\n\n

\n\n\n\n

\n\n\n\n---\n*Was this helpful? React with 👍 or 👎 to provide feedback.*","\n### 💡 Codex Review\n\nHere are some automated review suggestions for this pull request.\n\n**Reviewed commit:** `2aa19bec03`\n \n\n

ℹ️ About Codex in GitHub

\n
\n\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\n- Open a pull request for review\n- Mark a draft as ready\n- Comment \"@codex review\".\n\nIf Codex has suggestions, it will comment; otherwise it will react with 👍.\n\n\n\n\nCodex can also answer questions or update the PR. Try commenting \"@codex address that feedback\".\n \n

","**_{_{![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)}} Keep checking case-insensitive boolean tokens**\n\nFor inputs such as `store answer as YES` or `store answer as No`, the lexer emits `Token::BooleanLiteral` because its boolean regex is case-insensitive (`src/lexer/token.rs:446-453`), so this identifier-only branch skips the token entirely. The previous rule explicitly checked `yes` and `no`, meaning these valid, parseable inputs have now silently lost their `LINT-KEYWORD` warning despite the change's backward-compatibility claim; inspect non-lowercase boolean literal tokens before continuing.\n\nAGENTS.md reference: [AGENTS.md:L21-L21](https://github.com/WebFirstLanguage/wfl/blob/2aa19bec03c7394f6b62a0ce6a2dae711fdea10c/AGENTS.md#L21-L21)\n\nUseful? React with 👍 / 👎.","\n\n\n> [!WARNING]\n> ## Review limit reached\n> \n> `@logbie`, you've reached your PR review limit, so we couldn't start this review.\n> \n> **Next review available in:** **26 minutes**\n> \n> You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.\n> \n>

\n>

How can I continue?

\n> \n> After more reviews become available, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR.\n> \n> To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.\n> \n>

\n> \n> \n>

\n>

How do review limits work?

\n> \n> CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.\n> \n> For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.\n> \n> Please refer [docs](https://docs.coderabbit.ai/management/plans#rate-limits) for additional details.\n> \n>

\n> \n>

\n>

Review details

\n> \n>

\n>

⚙️ Run configuration

\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro Plus\n> \n> **Run ID**: `155d906b-1cdc-46d4-a055-df48839cf12e`\n> \n>

\n> \n>

\n>

📥 Commits

\n> \n> Reviewing files that changed from the base of the PR and between c277d8f887a16ca9d873c6eebd861f1490859ebc and 7d315514cc67c701ae65f44d9b0b2889393f1608.\n> \n>

\n> \n>

\n>

📒 Files selected for processing (3)

\n> \n> * `History/dev-diary/2026/2026-08-14-issue-707-lint-keyword-on-tokens.md`\n> * `src/linter/mod.rs`\n> * `src/linter/tests.rs`\n> \n>

\n> \n>

\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=WebFirstLanguage/wfl&utm_content=714)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n

❤️ Share

\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n

\n\n\n_{Comment `@coderabbitai help` to get the list of available commands.}\n\n","base_ref","head_ref","pull_request_info",[903],{"_832":49,"_49":904},"## Review findings — all addressed\n\n**@chatgpt-codex-connector and @devin-ai-integration — confirmed and fixed.** Both of you independently found a real regression, and you were right.\n\n`yes|no|true|false` is the only case-insensitive production in the lexer (`src/lexer/token.rs:446`, `#[regex(\"(?i:yes|no|true|false)\")]`), so `store flag as YES` lexes as `Token::BooleanLiteral` and never reached the identifier branch. The pre-#707 rule carried `yes` and `no` in its 26-keyword array and did warn on them — so this PR's claim that \"output for genuine hits is identical\" was false for exactly those two keywords. That claim has been corrected.\n\nFixed in `7d31551`: the rule now also checks `BooleanLiteral` spans. Red evidence first in `90bfb69` — `store flag as YES` reported 0 diagnostics where 1 was expected.\n\nI checked whether anything else was affected: `BooleanLiteral` is the *only* case-insensitive token. `NothingLiteral` is `#[token(\"nothing\")]` / `#[token(\"missing\")]` / `#[token(\"undefined\")]` — case-sensitive — so `Nothing` still lexes as an identifier and was covered all along. Coverage is now a superset of the old rule's, with none of the false positives.\n\nNew tests: `test_keyword_casing_flags_mis_cased_boolean_literals` (all four literals, in `YES` / `No` / `TRUE` / `False` forms) and `test_keyword_casing_accepts_lowercase_boolean_literals`. Linter module is 12/12.\n\nWorth naming the general shape, since it is the interesting part of this review: replacing a crude mechanism with a precise one silently drops whatever the crude mechanism covered *by accident*. Every test written for the reported defect was about false positives, so none of them could have caught a lost true positive. Recorded in the dev diary.\n",[933,934],[],{"_291":932},{"_288":931},{"_288":930},{"_253":254,"_243":255,"_256":257,"_258":18,"_259":62,"_260":18,"_261":262,"_263":264,"_265":214,"_266":129,"_267":268,"_269":131,"_270":271,"_272":-5,"_273":-5,"_274":929,"_276":277,"_278":279,"_280":281,"_282":283},{"_45":125,"_158":159,"_160":161,"_162":18,"_163":164,"_165":166,"_167":918,"_169":-5,"_170":-5,"_171":18,"_172":919,"_174":920,"_176":-5,"_177":921,"_179":922,"_181":923,"_183":-5,"_184":185,"_186":187,"_188":189,"_190":924,"_58":-5,"_121":192,"_193":-5,"_194":925,"_196":197,"_198":18,"_199":18},{"_135":913},[914,915],{"_146":917,"_148":155},{"_146":916,"_148":149},{"_150":151,"_95":152,"_121":153},{"_150":156,"_95":152,"_121":157},{"_246":247,"_248":72,"_249":-5,"_250":-5,"_251":-5,"_252":-5},[204],[245],{"_204":926},{"_202":203},{},[],{"_200":62,"_201":164},{"_45":206,"_150":207,"_208":927,"_210":161,"_211":212,"_213":214,"_215":216,"_217":218,"_219":220,"_221":67,"_222":18,"_223":-5,"_224":-5,"_225":-5,"_226":-5,"_227":-5,"_228":-5,"_229":230,"_231":-5,"_58":928},{"_237":238,"_45":239,"_95":240,"_241":242,"_243":244},{"_233":18,"_234":18,"_235":18,"_236":18},{"_237":284,"_150":284,"_285":-5,"_241":286,"_45":287},[],[],[],{"_95":823,"_99":96,"_312":948},{"_95":295,"_296":935},[936,937,938],{"_301":523,"_303":-5,"_304":945,"_306":-5},{"_301":406,"_303":-5,"_304":942,"_306":-5},{"_301":302,"_303":-5,"_304":939,"_306":-5},[940],{"_308":309,"_310":311,"_312":941,"_314":62},[315,164,316,164,317,318,319,320,164,321,322,323,320,164,324,325,164,326,327,328,164,329,330,331,332,333,334,164,335,164,336,337,338,339,164,340,341,342,164,343,344,345,346,164,347,164,348,349,350,351,164,352,353,354,164,355,356,357,358,359,164,360,361,362,164,363,164,364,365,366,367,164,368,369,370,371,164,372,164,373,374,375,164,321,376,377,320,164,378,164,379,164,380,381,382,383,384,164,385,164,386,387,164,388,389,164,390,391,392,320,164,393,394,395,396,397,164,398,399,400,164,401,402,403,404,164,405],[943],{"_308":309,"_310":409,"_312":944,"_314":62},[411,412,413,164,414,415,416,417,418,164,419,420,421,164,422,164,423,424,425,426,164,414,427,428,429,430,431,432,426,164,414,433,434,435,436,437,438,439,426,164,440,441,442,443,444,445,417,446,164,447,420,421,164,448,426,164,449,414,450,451,452,453,454,455,426,164,456,414,457,458,452,453,459,455,426,164,460,414,461,462,452,453,463,455,426,164,464,414,465,466,164,467,468,469,470,471,472,455,473,474,475,426,164,476,414,477,478,479,164,480,481,482,452,483,484,485,455,426,164,486,414,487,488,479,452,453,489,455,426,164,414,490,491,417,418,164,492,493,164,494,452,483,484,495,455,452,496,484,497,455,426,164,498,499,500,501,502,414,503,504,505,506,507,508,509,510,511,512,513,514,515,511,516,517,515,518,426,164,519,414,520,521,452,453,522,455,426],[946],{"_308":309,"_310":526,"_312":947,"_314":62},[528,412,529,530,531,532,164,533,534,164,535,164,536,537,538,539,540,541,426,164,542,543,544,545,426,164,546,547,548,549,550,551,552,164,553,554,555,556,557,558,164,559,518,164,560,561,518,164,562,563,518,164,564,565,518,164,566,537,538,567,568,569,570,571,572,164,573,164,574,575,576,577,578,579,164,580,581,582,518,164,583,584,585,586,518,426,164,587,164,588,589,590,518,164,591,592,518,164,536,537,538,593,540,594,595,596,164,597,598,599,600,601,602,600,603,604,605,606,607,608,609,610,611,612,613,614,615,601,616,617,600,603,604,605,606,618,608,609,610,611,612,613,614,615,601,619,620,621,579,164,483,518,426,164,622,623,624,625,626,627,628,426,164,629,164,630,589,631,518,164,591,632,518,164,536,537,633,539,540,594,596,164,634,635,164,636,164,637,638,639,164,640,641,601,164,642,164,643,644,645,646,647,648,649,601,164,650,651,606,652,653,654,655,656,610,657,658,613,659,601,164,660,661,601,621,579,164,483,518,426,164,662,164,663,589,664,518,164,591,665,518,164,536,537,633,539,540,594,596,164,666,667,552,668,164,669,670,671,672,673,674,675,164,676,677,678,679,680,681,682,683,684,685,686,687,688,689,690,691,692,693,694,695,696,601,697,698,164,699,700,641,601,164,701,702,703,704,164,705,651,606,706,707,708,610,709,710,613,659,601,621,579,164,483,518,426,164,711,712,713,714,715,164,716,717,718,719,621,720,721,579,518,164,722,723,518,164,724,426,164,725,441,726,727,728,729,730,731,426,164,732,164,733,589,734,518,164,591,735,518,164,536,537,633,539,540,594,596,164,634,635,164,637,638,164,736,651,606,737,738,739,610,657,740,613,659,601,621,579,164,483,518,426,164,741,742,164,743,589,744,518,164,591,745,518,164,536,537,633,539,540,594,596,164,746,164,634,635,164,637,638,164,747,651,606,748,749,750,610,657,751,613,659,601,621,579,164,483,518,426,164,752,753,164,754,589,755,518,164,591,756,518,164,536,537,538,593,540,594,596,164,757,164,597,758,579,164,483,518,426,164,759,760,761,762,763,764,765,766,767,768,769,770,771,772,773,774,775,776,777,778,779,780,781,621,782,579,518,164,783,784,785,786,787,788,789,790,621,791,792,793,601,621,579,794,795,796,797,798,790,621,579,799,798,800,621,579,801,518,426,164,802,803,426,164,804,805,806,164,807,808,809,810,621,811,812,813,814,815,579,164,816,518,164,817,426,164,818,819,164,820,821,822,518,426],[949,950,951,952,953,954,955],{"_832":49,"_49":842},{"_832":834,"_301":523,"_308":840,"_310":841},{"_832":49,"_49":839},{"_832":834,"_301":406,"_308":837,"_310":838},{"_832":49,"_49":836},{"_832":834,"_301":302,"_308":835,"_310":311},{"_832":49,"_49":833},[958,959,960,961,962,963,964,965,966,967,968],{"_852":853,"_210":161,"_854":254,"_221":-5,"_855":204,"_856":18,"_857":-5,"_858":-5,"_859":860,"_861":862,"_863":-5,"_864":-5,"_865":866,"_867":18,"_868":62,"_869":57,"_870":18,"_871":-5},{"_95":823,"_99":274,"_312":969},{"_261":262,"_263":264,"_899":268,"_900":131,"_270":-5,"_95":901},{"_95":883,"_263":898,"_301":-5,"_885":-5,"_886":-5},{"_95":883,"_263":897,"_301":523,"_885":888,"_886":-5},{"_95":883,"_263":896,"_301":-5,"_885":-5,"_886":-5},{"_95":883,"_263":895,"_301":523,"_885":888,"_886":-5},{"_95":883,"_263":893,"_301":523,"_885":888,"_886":894},{"_95":883,"_263":892,"_301":-5,"_885":-5,"_886":-5},{"_95":883,"_263":890,"_301":406,"_885":888,"_886":891},{"_95":883,"_263":887,"_301":523,"_885":888,"_886":889},{"_95":883,"_263":884,"_301":-5,"_885":-5,"_886":-5},[970],{"_832":49,"_49":904},"task_e_6a7f4b203de8832cafc5f75b51fb67c6",1786727200.24196,"GitHub Mention: fix(linter): match LINT-KEYWORD on identifier tokens, not raw substrings (#707)","has_generated_title","has_unread_turn","denormalized_metadata",{"_1002":35,"_1003":1004,"_1005":-5,"_1006":-5,"_997":1007,"_1008":-5,"_1009":-5,"_1010":-5,"_1011":-5},"task_status_display",{"_990":991,"_992":161,"_132":129,"_993":-5,"_994":995},"creator_workspace","external_pull_requests",[983],{"_45":984,"_985":86,"_986":987,"_988":131},"github-879879293-714","assistant_turn_id","pull_request",{"_253":254,"_243":255,"_256":257,"_258":18,"_259":62,"_260":18,"_261":262,"_263":264,"_265":214,"_266":129,"_267":268,"_269":131,"_270":271,"_272":-5,"_273":-5,"_274":989,"_276":277,"_278":279,"_280":281,"_282":283},"codex_updated_sha",{"_237":284,"_150":284,"_285":-5,"_241":286,"_45":287},"latest_turn_status_display",{"_996":86,"_114":115,"_997":-5,"_97":998,"_999":-5,"_1000":-5,"_1001":995,"_116":-5},"environment_label","fix_task_id","initial_intent","pr","turn_id","diff_stats",[],"image_asset_pointer_citations","issue_counts","intent","num_follow_ups","repo_name_map",{},"last_user_turn_created_at","last_turn_status",{"_1012":-5,"_1013":-5,"_1014":-5},"last_pushed_turn_id","start_branch_name","pushed_branch_name","cached_pull_request_data","files_modified","lines_added","lines_removed","dd",{"_1029":1030,"_1031":1032},"disablePrefetch","shouldPrefetchAccount","shouldPrefetchUser","shouldPrefetchSystemHints","manageRootRouteStylesheet","mobileWebHandoffEnabled","promoteCss","disableSSR","stripModulepreloadImports","paidCampaignAppRedirect","statsigGateEvaluationsPromise",["P",1028],"traceId","15470296179067441838","traceTime",1787811756896]